[PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe

[PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe

[Ye Bin]

When calculate "ucr1" UCR1_TRDYEN is duplicate.

Fixes: c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 drivers/tty/serial/imx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index ce8c472cf385..4e6ead1f650e 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2389,8 +2389,7 @@ static int imx_uart_probe(struct platform_device *pdev)
 
 	/* Disable interrupts before requesting them */
 	ucr1 = imx_uart_readl(sport, UCR1);
-	ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN |
-		 UCR1_TRDYEN | UCR1_RTSDEN);
+	ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN | UCR1_RTSDEN);
 	imx_uart_writel(sport, ucr1, UCR1);
 
 	if (!imx_uart_is_imx1(sport) && sport->dte_mode) {
-- 
2.25.4

Re: [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Hello,

On Thu, Sep 03, 2020 at 02:24:01PM +0800, Ye Bin wrote:
> When calculate "ucr1" UCR1_TRDYEN is duplicate.
> 
> Fixes: c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Not sure I'd use Fixes: to reference the commit that introduced this
duplication, as this fix is not critical at all.

Other than that:

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe

[Greg KH]

On Thu, Sep 03, 2020 at 09:35:41AM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Sep 03, 2020 at 02:24:01PM +0800, Ye Bin wrote:
> > When calculate "ucr1" UCR1_TRDYEN is duplicate.
> > 
> > Fixes: c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
> > Signed-off-by: Ye Bin <yebin10@huawei.com>
> 
> Not sure I'd use Fixes: to reference the commit that introduced this
> duplication, as this fix is not critical at all.

Agreed, I'm dropping that line.

thanks,

greg k-h