From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Ye Bin <yebin10@huawei.com>
Cc: chris.ruehl@gtsys.com.hk, gregkh@linuxfoundation.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe
Date: Thu, 3 Sep 2020 09:35:41 +0200 [thread overview]
Message-ID: <20200903073541.g57uoipyolsixfjn@pengutronix.de> (raw)
In-Reply-To: <20200903062401.692442-1-yebin10@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
Hello,
On Thu, Sep 03, 2020 at 02:24:01PM +0800, Ye Bin wrote:
> When calculate "ucr1" UCR1_TRDYEN is duplicate.
>
> Fixes: c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
> Signed-off-by: Ye Bin <yebin10@huawei.com>
Not sure I'd use Fixes: to reference the commit that introduced this
duplication, as this fix is not critical at all.
Other than that:
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-03 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 6:24 [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe Ye Bin
2020-09-03 7:35 ` Uwe Kleine-König [this message]
2020-09-04 15:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903073541.g57uoipyolsixfjn@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=chris.ruehl@gtsys.com.hk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).