linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ye Bin <yebin10@huawei.com>,
	chris.ruehl@gtsys.com.hk, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe
Date: Fri, 4 Sep 2020 17:11:25 +0200	[thread overview]
Message-ID: <20200904151125.GA3347894@kroah.com> (raw)
In-Reply-To: <20200903073541.g57uoipyolsixfjn@pengutronix.de>

On Thu, Sep 03, 2020 at 09:35:41AM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Sep 03, 2020 at 02:24:01PM +0800, Ye Bin wrote:
> > When calculate "ucr1" UCR1_TRDYEN is duplicate.
> > 
> > Fixes: c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
> > Signed-off-by: Ye Bin <yebin10@huawei.com>
> 
> Not sure I'd use Fixes: to reference the commit that introduced this
> duplication, as this fix is not critical at all.

Agreed, I'm dropping that line.

thanks,

greg k-h

      reply	other threads:[~2020-09-04 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03  6:24 [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe Ye Bin
2020-09-03  7:35 ` Uwe Kleine-König
2020-09-04 15:11   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200904151125.GA3347894@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris.ruehl@gtsys.com.hk \
    --cc=linux-serial@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=yebin10@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).