Linux-Serial Archive on
 help / color / Atom feed
From: Andy Shevchenko <>
To: Hsin-Yi Wang <>
	Greg Kroah-Hartman <>,
	Jiri Slaby <>,
	Matthias Brugger <>,
	Serge Semin <>,
	Changqi Hu <>,
	Frank Wunderlich <>,,,,
	Enric Balletbo i Serra <>
Subject: Re: [PATCH 1/2] tty: serial: print earlycon info after match->setup
Date: Mon, 14 Sep 2020 19:06:34 +0300
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Sep 11, 2020 at 05:39:26PM +0800, Hsin-Yi Wang wrote:
> 8250 devices may modify iotype in their own earlycon setup. For example:
> 8250_mtk and 8250_uniphier force iotype to be MMIO32. Print earlycon info
> after match->setup to reflect actual earlycon info.

But this means you do something which user didn't ask for...

> +static void __init earlycon_info(struct earlycon_device *device)

Can it be earlycon_pr_info() or earlycon_print_info() ?

With Best Regards,
Andy Shevchenko

  parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  9:39 Hsin-Yi Wang
2020-09-11  9:39 ` [PATCH 2/2] tty: serial: 8250_mtk: set regshift for mmio32 Hsin-Yi Wang
2020-09-14 16:06 ` Andy Shevchenko [this message]
2020-09-14 17:27   ` [PATCH 1/2] tty: serial: print earlycon info after match->setup Hsin-Yi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Serial Archive on

Archives are clonable:
	git clone --mirror linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ \
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone