Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2 1/2] tty: serial: print earlycon info after match->setup
@ 2020-09-15  5:48 Hsin-Yi Wang
  2020-09-15  5:48 ` [PATCH v2 2/2] tty: serial: 8250_mtk: set regshift for mmio32 Hsin-Yi Wang
  2020-09-18 11:03 ` [PATCH v2 1/2] tty: serial: print earlycon info after match->setup Andy Shevchenko
  0 siblings, 2 replies; 3+ messages in thread
From: Hsin-Yi Wang @ 2020-09-15  5:48 UTC (permalink / raw)
  To: linux-serial
  Cc: Greg Kroah-Hartman, Jiri Slaby, Matthias Brugger, Serge Semin,
	Changqi Hu, Frank Wunderlich, Hsin-Yi Wang, Andy Shevchenko,
	linux-arm-kernel, linux-mediatek, linux-kernel,
	Enric Balletbo i Serra, Eddie Huang

8250 devices may modify iotype in their own earlycon setup. For example:
8250_mtk and 8250_uniphier force iotype to be MMIO32. Print earlycon info
after match->setup to reflect actual earlycon info.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Change:
v1->v2: rename function
---
 drivers/tty/serial/earlycon.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
index 2ae9190b64bb9..b70877932d47d 100644
--- a/drivers/tty/serial/earlycon.c
+++ b/drivers/tty/serial/earlycon.c
@@ -56,7 +56,6 @@ static void __init earlycon_init(struct earlycon_device *device,
 				 const char *name)
 {
 	struct console *earlycon = device->con;
-	struct uart_port *port = &device->port;
 	const char *s;
 	size_t len;
 
@@ -70,6 +69,12 @@ static void __init earlycon_init(struct earlycon_device *device,
 	len = s - name;
 	strlcpy(earlycon->name, name, min(len + 1, sizeof(earlycon->name)));
 	earlycon->data = &early_console_dev;
+}
+
+static void __init earlycon_print_info(struct earlycon_device *device)
+{
+	struct console *earlycon = device->con;
+	struct uart_port *port = &device->port;
 
 	if (port->iotype == UPIO_MEM || port->iotype == UPIO_MEM16 ||
 	    port->iotype == UPIO_MEM32 || port->iotype == UPIO_MEM32BE)
@@ -140,6 +145,7 @@ static int __init register_earlycon(char *buf, const struct earlycon_id *match)
 
 	earlycon_init(&early_console_dev, match->name);
 	err = match->setup(&early_console_dev, buf);
+	earlycon_print_info(&early_console_dev);
 	if (err < 0)
 		return err;
 	if (!early_console_dev.con->write)
@@ -302,6 +308,7 @@ int __init of_setup_earlycon(const struct earlycon_id *match,
 	}
 	earlycon_init(&early_console_dev, match->name);
 	err = match->setup(&early_console_dev, options);
+	earlycon_print_info(&early_console_dev);
 	if (err < 0)
 		return err;
 	if (!early_console_dev.con->write)
-- 
2.28.0.618.gf4bc123cb7-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] tty: serial: 8250_mtk: set regshift for mmio32
  2020-09-15  5:48 [PATCH v2 1/2] tty: serial: print earlycon info after match->setup Hsin-Yi Wang
@ 2020-09-15  5:48 ` Hsin-Yi Wang
  2020-09-18 11:03 ` [PATCH v2 1/2] tty: serial: print earlycon info after match->setup Andy Shevchenko
  1 sibling, 0 replies; 3+ messages in thread
From: Hsin-Yi Wang @ 2020-09-15  5:48 UTC (permalink / raw)
  To: linux-serial
  Cc: Greg Kroah-Hartman, Jiri Slaby, Matthias Brugger, Serge Semin,
	Changqi Hu, Frank Wunderlich, Hsin-Yi Wang, Andy Shevchenko,
	linux-arm-kernel, linux-mediatek, linux-kernel,
	Enric Balletbo i Serra, Eddie Huang

To use mmio32, we also need to set regshift.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Change:
v1->v2: none
---
 drivers/tty/serial/8250/8250_mtk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
index 7b0dec14c8b80..41f4120abdf29 100644
--- a/drivers/tty/serial/8250/8250_mtk.c
+++ b/drivers/tty/serial/8250/8250_mtk.c
@@ -669,6 +669,7 @@ static int __init early_mtk8250_setup(struct earlycon_device *device,
 		return -ENODEV;
 
 	device->port.iotype = UPIO_MEM32;
+	device->port.regshift = 2;
 
 	return early_serial8250_setup(device, NULL);
 }
-- 
2.28.0.618.gf4bc123cb7-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/2] tty: serial: print earlycon info after match->setup
  2020-09-15  5:48 [PATCH v2 1/2] tty: serial: print earlycon info after match->setup Hsin-Yi Wang
  2020-09-15  5:48 ` [PATCH v2 2/2] tty: serial: 8250_mtk: set regshift for mmio32 Hsin-Yi Wang
@ 2020-09-18 11:03 ` Andy Shevchenko
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-09-18 11:03 UTC (permalink / raw)
  To: Hsin-Yi Wang
  Cc: open list:SERIAL DRIVERS, Greg Kroah-Hartman, Jiri Slaby,
	Matthias Brugger, Serge Semin, Changqi Hu, Frank Wunderlich,
	Andy Shevchenko, linux-arm Mailing List,
	moderated list:ARM/Mediatek SoC support,
	Linux Kernel Mailing List, Enric Balletbo i Serra, Eddie Huang

On Tue, Sep 15, 2020 at 8:50 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> 8250 devices may modify iotype in their own earlycon setup. For example:
> 8250_mtk and 8250_uniphier force iotype to be MMIO32. Print earlycon info
> after match->setup to reflect actual earlycon info.

Thanks for an update.
I prefer to see some flag that tells user that options were forced by
the kernel itself (something like err > 0 returned from ->setup()),
but I think it's matter of an additional fix. In principle user can
check the command line and / or DT/ACPI vs. dmesg, although it will
require an extra work.

> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> Change:
> v1->v2: rename function
> ---
>  drivers/tty/serial/earlycon.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
> index 2ae9190b64bb9..b70877932d47d 100644
> --- a/drivers/tty/serial/earlycon.c
> +++ b/drivers/tty/serial/earlycon.c
> @@ -56,7 +56,6 @@ static void __init earlycon_init(struct earlycon_device *device,
>                                  const char *name)
>  {
>         struct console *earlycon = device->con;
> -       struct uart_port *port = &device->port;
>         const char *s;
>         size_t len;
>
> @@ -70,6 +69,12 @@ static void __init earlycon_init(struct earlycon_device *device,
>         len = s - name;
>         strlcpy(earlycon->name, name, min(len + 1, sizeof(earlycon->name)));
>         earlycon->data = &early_console_dev;
> +}
> +
> +static void __init earlycon_print_info(struct earlycon_device *device)
> +{
> +       struct console *earlycon = device->con;
> +       struct uart_port *port = &device->port;
>
>         if (port->iotype == UPIO_MEM || port->iotype == UPIO_MEM16 ||
>             port->iotype == UPIO_MEM32 || port->iotype == UPIO_MEM32BE)
> @@ -140,6 +145,7 @@ static int __init register_earlycon(char *buf, const struct earlycon_id *match)
>
>         earlycon_init(&early_console_dev, match->name);
>         err = match->setup(&early_console_dev, buf);
> +       earlycon_print_info(&early_console_dev);
>         if (err < 0)
>                 return err;
>         if (!early_console_dev.con->write)
> @@ -302,6 +308,7 @@ int __init of_setup_earlycon(const struct earlycon_id *match,
>         }
>         earlycon_init(&early_console_dev, match->name);
>         err = match->setup(&early_console_dev, options);
> +       earlycon_print_info(&early_console_dev);
>         if (err < 0)
>                 return err;
>         if (!early_console_dev.con->write)
> --
> 2.28.0.618.gf4bc123cb7-goog
>


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15  5:48 [PATCH v2 1/2] tty: serial: print earlycon info after match->setup Hsin-Yi Wang
2020-09-15  5:48 ` [PATCH v2 2/2] tty: serial: 8250_mtk: set regshift for mmio32 Hsin-Yi Wang
2020-09-18 11:03 ` [PATCH v2 1/2] tty: serial: print earlycon info after match->setup Andy Shevchenko

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git