From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] serial: core: fix console port-lock regression
Date: Wed, 16 Sep 2020 15:23:24 +0300 [thread overview]
Message-ID: <20200916122324.GG3956970@smile.fi.intel.com> (raw)
In-Reply-To: <20200914080916.GI7101@atomide.com>
On Mon, Sep 14, 2020 at 11:09:16AM +0300, Tony Lindgren wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [200910 09:27]:
> > +Cc: Tony, let me add Tony to the discussion.
> >
> > On Thu, Sep 10, 2020 at 09:35:27AM +0200, Johan Hovold wrote:
> > > And what about power management
> > > which was the reason for wanting this on OMAP in the first place; tty
> > > core never calls shutdown() for a console port, not even when it's been
> > > detached using the new interface.
> >
> > That is interesting... Tony, do we have OMAP case working because of luck?
>
> 8250_omap won't do anything unless autosuspend_timeout is configured for
> the uart(s). If configured, then the 8250_omap will idle when console is
> detached and the PM runtime usage count held by console is decremented, and
> the configured autosuspend_timeout expires.
>
> The console is still kept open by getty, so I don't see why shutdown() would
> be called for the console port. But maybe I don't follow what you're
> concerned about, let me know if you want me to check something :)
Is it possible to test configuration when you have kernel console enabled but
no getty is run on it (perhaps something with ssh enabled access)?
Then kernel console should call ->shutdown on detaching, right?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-16 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 14:30 [PATCH 0/2] serial: core: fix console port-lock regression Johan Hovold
2020-09-09 14:31 ` [PATCH 1/2] serial: core: fix port-lock initialisation Johan Hovold
[not found] ` <20200909152158.GC1891694@smile.fi.intel.com>
2020-09-10 7:08 ` Johan Hovold
2020-09-09 14:31 ` [PATCH 2/2] serial: core: fix console port-lock regression Johan Hovold
[not found] ` <20200909154815.GD1891694@smile.fi.intel.com>
2020-09-10 7:35 ` Johan Hovold
2020-09-10 9:27 ` Andy Shevchenko
2020-09-10 11:10 ` Johan Hovold
2020-09-14 8:09 ` Tony Lindgren
2020-09-16 12:23 ` Andy Shevchenko [this message]
2020-09-18 7:16 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916122324.GG3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).