Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
Date: Sat, 19 Sep 2020 07:41:16 +0200
Message-ID: <20200919054116.GB432686@kroah.com> (raw)
In-Reply-To: <d39572f9-2f18-384e-ebc2-21a046c5986f@huawei.com>

On Sat, Sep 19, 2020 at 10:26:38AM +0800, Yang Yingliang wrote:
> Hi,
> 
> On 2020/9/18 19:16, Greg KH wrote:
> > On Fri, Sep 18, 2020 at 05:13:05PM +0800, Yang Yingliang wrote:
> > > Fix the link error by selecting SERIAL_CORE_CONSOLE.
> > > 
> > > aarch64-linux-gnu-ld: drivers/tty/serial/imx_earlycon.o: in function `imx_uart_console_early_write':
> > > imx_earlycon.c:(.text+0x84): undefined reference to `uart_console_write'
> > > 
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > > ---
> > >   drivers/tty/serial/Kconfig | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > index 9631ccf43378..1044fc387691 100644
> > > --- a/drivers/tty/serial/Kconfig
> > > +++ b/drivers/tty/serial/Kconfig
> > > @@ -521,6 +521,7 @@ config SERIAL_IMX_EARLYCON
> > >   	depends on ARCH_MXC || COMPILE_TEST
> > >   	depends on OF
> > >   	select SERIAL_EARLYCON
> > > +	select SERIAL_CORE_CONSOLE
> > >   	help
> > >   	  If you have enabled the earlycon on the Freescale IMX
> > >   	  CPU you can make it the earlycon by answering Y to this option.
> > > -- 
> > > 2.25.1
> > > 
> > What caused this build error to start happening?  Any pointers to the
> > specific commit?
> 
> It's start from 699cc4dfd140 ("tty: serial: imx: add imx earlycon driver"),
> the driver
> 
> uses the uart_console_write(), but SERIAL_CORE_CONSOLE is not selected, so
> uart_console_write
> 
> is not defined, then we get the error.

Great, can you add a Fixes: line to the patch and resend it with this
information added to the changelog text?

Always include this type of information if at all possible.

thanks,

greg k-h

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18  9:13 Yang Yingliang
2020-09-18 11:16 ` Greg KH
2020-09-19  2:26   ` Yang Yingliang
2020-09-19  5:41     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200919054116.GB432686@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git