Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
@ 2020-09-18  9:13 Yang Yingliang
  2020-09-18 11:16 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2020-09-18  9:13 UTC (permalink / raw)
  To: linux-serial, linux-kernel; +Cc: gregkh

Fix the link error by selecting SERIAL_CORE_CONSOLE.

aarch64-linux-gnu-ld: drivers/tty/serial/imx_earlycon.o: in function `imx_uart_console_early_write':
imx_earlycon.c:(.text+0x84): undefined reference to `uart_console_write'

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/tty/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 9631ccf43378..1044fc387691 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -521,6 +521,7 @@ config SERIAL_IMX_EARLYCON
 	depends on ARCH_MXC || COMPILE_TEST
 	depends on OF
 	select SERIAL_EARLYCON
+	select SERIAL_CORE_CONSOLE
 	help
 	  If you have enabled the earlycon on the Freescale IMX
 	  CPU you can make it the earlycon by answering Y to this option.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
  2020-09-18  9:13 [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n Yang Yingliang
@ 2020-09-18 11:16 ` Greg KH
  2020-09-19  2:26   ` Yang Yingliang
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-09-18 11:16 UTC (permalink / raw)
  To: Yang Yingliang; +Cc: linux-serial, linux-kernel

On Fri, Sep 18, 2020 at 05:13:05PM +0800, Yang Yingliang wrote:
> Fix the link error by selecting SERIAL_CORE_CONSOLE.
> 
> aarch64-linux-gnu-ld: drivers/tty/serial/imx_earlycon.o: in function `imx_uart_console_early_write':
> imx_earlycon.c:(.text+0x84): undefined reference to `uart_console_write'
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/tty/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 9631ccf43378..1044fc387691 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -521,6 +521,7 @@ config SERIAL_IMX_EARLYCON
>  	depends on ARCH_MXC || COMPILE_TEST
>  	depends on OF
>  	select SERIAL_EARLYCON
> +	select SERIAL_CORE_CONSOLE
>  	help
>  	  If you have enabled the earlycon on the Freescale IMX
>  	  CPU you can make it the earlycon by answering Y to this option.
> -- 
> 2.25.1
> 

What caused this build error to start happening?  Any pointers to the
specific commit?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
  2020-09-18 11:16 ` Greg KH
@ 2020-09-19  2:26   ` Yang Yingliang
  2020-09-19  5:41     ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2020-09-19  2:26 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-serial, linux-kernel

Hi,

On 2020/9/18 19:16, Greg KH wrote:
> On Fri, Sep 18, 2020 at 05:13:05PM +0800, Yang Yingliang wrote:
>> Fix the link error by selecting SERIAL_CORE_CONSOLE.
>>
>> aarch64-linux-gnu-ld: drivers/tty/serial/imx_earlycon.o: in function `imx_uart_console_early_write':
>> imx_earlycon.c:(.text+0x84): undefined reference to `uart_console_write'
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>>   drivers/tty/serial/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>> index 9631ccf43378..1044fc387691 100644
>> --- a/drivers/tty/serial/Kconfig
>> +++ b/drivers/tty/serial/Kconfig
>> @@ -521,6 +521,7 @@ config SERIAL_IMX_EARLYCON
>>   	depends on ARCH_MXC || COMPILE_TEST
>>   	depends on OF
>>   	select SERIAL_EARLYCON
>> +	select SERIAL_CORE_CONSOLE
>>   	help
>>   	  If you have enabled the earlycon on the Freescale IMX
>>   	  CPU you can make it the earlycon by answering Y to this option.
>> -- 
>> 2.25.1
>>
> What caused this build error to start happening?  Any pointers to the
> specific commit?

It's start from 699cc4dfd140 ("tty: serial: imx: add imx earlycon 
driver"), the driver

uses the uart_console_write(), but SERIAL_CORE_CONSOLE is not selected, 
so uart_console_write

is not defined, then we get the error.

>
> thanks,
>
> greg k-h
> .

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
  2020-09-19  2:26   ` Yang Yingliang
@ 2020-09-19  5:41     ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-09-19  5:41 UTC (permalink / raw)
  To: Yang Yingliang; +Cc: linux-serial, linux-kernel

On Sat, Sep 19, 2020 at 10:26:38AM +0800, Yang Yingliang wrote:
> Hi,
> 
> On 2020/9/18 19:16, Greg KH wrote:
> > On Fri, Sep 18, 2020 at 05:13:05PM +0800, Yang Yingliang wrote:
> > > Fix the link error by selecting SERIAL_CORE_CONSOLE.
> > > 
> > > aarch64-linux-gnu-ld: drivers/tty/serial/imx_earlycon.o: in function `imx_uart_console_early_write':
> > > imx_earlycon.c:(.text+0x84): undefined reference to `uart_console_write'
> > > 
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > > ---
> > >   drivers/tty/serial/Kconfig | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > index 9631ccf43378..1044fc387691 100644
> > > --- a/drivers/tty/serial/Kconfig
> > > +++ b/drivers/tty/serial/Kconfig
> > > @@ -521,6 +521,7 @@ config SERIAL_IMX_EARLYCON
> > >   	depends on ARCH_MXC || COMPILE_TEST
> > >   	depends on OF
> > >   	select SERIAL_EARLYCON
> > > +	select SERIAL_CORE_CONSOLE
> > >   	help
> > >   	  If you have enabled the earlycon on the Freescale IMX
> > >   	  CPU you can make it the earlycon by answering Y to this option.
> > > -- 
> > > 2.25.1
> > > 
> > What caused this build error to start happening?  Any pointers to the
> > specific commit?
> 
> It's start from 699cc4dfd140 ("tty: serial: imx: add imx earlycon driver"),
> the driver
> 
> uses the uart_console_write(), but SERIAL_CORE_CONSOLE is not selected, so
> uart_console_write
> 
> is not defined, then we get the error.

Great, can you add a Fixes: line to the patch and resend it with this
information added to the changelog text?

Always include this type of information if at all possible.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18  9:13 [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n Yang Yingliang
2020-09-18 11:16 ` Greg KH
2020-09-19  2:26   ` Yang Yingliang
2020-09-19  5:41     ` Greg KH

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git