Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paras Sharma <parashar@codeaurora.org>
Cc: Jiri Slaby <jslaby@suse.com>,
	linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, akashast@codeaurora.org
Subject: Re: [PATCH V5] serial: qcom_geni_serial: To correct QUP Version detection logic
Date: Mon, 28 Sep 2020 09:01:26 +0200
Message-ID: <20200928070126.GA391632@kroah.com> (raw)
In-Reply-To: <1601276378-4325-1-git-send-email-parashar@codeaurora.org>

On Mon, Sep 28, 2020 at 12:29:38PM +0530, Paras Sharma wrote:
> For QUP IP versions 2.5 and above the oversampling rate is
> halved from 32 to 16.
> Commit ce734600545f ("tty: serial: qcom_geni_serial: Update
> the oversampling rate") is pushed to handle this scenario.But
> the existing logic is failing to classify QUP Version 3.0 into
> the correct group ( 2.5 and above).
> 
> As result Serial Engine clocks are not configured properly for
> baud rate and garbage data is sampled to FIFOs from the line.
> 
> So, fix the logic to detect QUP with versions 2.5 and above.
> 
> Fixes: ce734600545f ("tty: serial: qcom_geni_serial: Update the oversampling rate")
> Signed-off-by: Paras Sharma <parashar@codeaurora.org>
> ---
> Changes in V5:
> Moved QUP_SE_VERSION_2_5 to common header file qcom-geni-se.h
> 
> Changes in V4:
> Created a new #define QUP_SE_VERSION_2_5 for Qup serial engine having version 2.5
> 
> Changes in V3:
> Replaced the condition for detecting Qup version(2.5 or greater) with value 0x20050000
> 
> Changes in V2:
> Changed subject line and logic for checking Qup version
> 
>  drivers/tty/serial/qcom_geni_serial.c | 3 ++-
>  include/linux/qcom-geni-se.h          | 3 +++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index f0b1b47..198ecdd7 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -106,6 +106,7 @@
>  /* We always configure 4 bytes per FIFO word */
>  #define BYTES_PER_FIFO_WORD		4
>  
> +
>  struct qcom_geni_private_data {
>  	/* NOTE: earlycon port will have NULL here */
>  	struct uart_driver *drv;

Unneeded change :(



      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  6:59 Paras Sharma
2020-09-28  7:01 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928070126.GA391632@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akashast@codeaurora.org \
    --cc=jslaby@suse.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=parashar@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git