From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF68C47420 for ; Mon, 5 Oct 2020 09:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C55B32075A for ; Mon, 5 Oct 2020 09:36:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726127AbgJEJg3 (ORCPT ); Mon, 5 Oct 2020 05:36:29 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2954 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725919AbgJEJg1 (ORCPT ); Mon, 5 Oct 2020 05:36:27 -0400 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 094B3ABD20918B3B41D5; Mon, 5 Oct 2020 10:36:23 +0100 (IST) Received: from localhost (10.52.124.175) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 5 Oct 2020 10:36:21 +0100 Date: Mon, 5 Oct 2020 10:34:36 +0100 From: Jonathan Cameron To: Rob Herring CC: , , "Thierry Reding" , Linus Walleij , Stephen Boyd , Shawn Guo , Bjorn Andersson , "Baolin Wang" , Guenter Roeck , Jonathan Cameron , Mauro Carvalho Chehab , Laurent Pinchart , Lee Jones , Ulf Hansson , "David S. Miller" , Bjorn Helgaas , "Vinod Koul" , Liam Girdwood , Mark Brown , Greg Kroah-Hartman , Daniel Lezcano , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties' Message-ID: <20201005093436.00004913@Huawei.com> In-Reply-To: <20201002234143.3570746-1-robh@kernel.org> References: <20201002234143.3570746-1-robh@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.124.175] X-ClientProxiedBy: lhreml730-chm.china.huawei.com (10.201.108.81) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, 2 Oct 2020 18:41:43 -0500 Rob Herring wrote: > Another round of wack-a-mole. The json-schema default is additional > unknown properties are allowed, but for DT all properties should be > defined. > > Cc: Thierry Reding > Cc: Linus Walleij > Cc: Stephen Boyd > Cc: Shawn Guo > Cc: Bjorn Andersson > Cc: Baolin Wang > Cc: Guenter Roeck > Cc: Jonathan Cameron > Cc: Mauro Carvalho Chehab > Cc: Laurent Pinchart > Cc: Lee Jones > Cc: Ulf Hansson > Cc: "David S. Miller" > Cc: Bjorn Helgaas > Cc: Vinod Koul > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: Daniel Lezcano > Cc: linux-clk@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-spi@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Cc: linux-hwmon@vger.kernel.org > Cc: linux-iio@vger.kernel.org > Cc: openipmi-developer@lists.sourceforge.net > Cc: linux-leds@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-mips@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: linux-remoteproc@vger.kernel.org > Cc: linux-serial@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring > --- Hi Rob, Acked-by: Jonathan Cameron # for iio However, one of these made me wonder if the binding was simply wrong... (definitely highlights why we should have additionalProperties: false where ever possible). ... > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > index abd8d25e1136..4c1c083d0e92 100644 > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > @@ -47,11 +47,17 @@ properties: > vddio-supply: > description: Regulator that provides power to the bus > > + spi-max-frequency: true > + spi-cpha: true > + spi-cpol: true It isn't completely unheard of for a device to operate in multiple SPI modes, but it does seem to be fairly unusual. I took a look at the datasheet and at least from the provided timing diagrams, these are both required in SPI mode. http://invensense.tdk.com/wp-content/uploads/2020/09/DS-000292-ICM-42605-v1.5.pdf That doesn't make the binding wrong as such, but we could be tighter in checking this! I'll add this to my list to take a closer look at sometime soonish. Thanks. Jonathan > + > required: > - compatible > - reg > - interrupts > > +additionalProperties: false > + > examples: > - |