linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org
Subject: [PATCH 11/36] tty: serial: jsm: jsm_cls: Remove unused variable 'discard'
Date: Wed,  4 Nov 2020 19:35:24 +0000	[thread overview]
Message-ID: <20201104193549.4026187-12-lee.jones@linaro.org> (raw)
In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/tty/serial/jsm/jsm_cls.c: In function ‘cls_copy_data_from_uart_to_queue’:
 drivers/tty/serial/jsm/jsm_cls.c:400:7: warning: variable ‘discard’ set but not used [-Wunused-but-set-variable]

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/tty/serial/jsm/jsm_cls.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/tty/serial/jsm/jsm_cls.c b/drivers/tty/serial/jsm/jsm_cls.c
index c061a7b7bd233..b507a2cec9269 100644
--- a/drivers/tty/serial/jsm/jsm_cls.c
+++ b/drivers/tty/serial/jsm/jsm_cls.c
@@ -397,10 +397,8 @@ static void cls_copy_data_from_uart_to_queue(struct jsm_channel *ch)
 		 * which in this case is the break signal.
 		 */
 		if (linestatus & error_mask)  {
-			u8 discard;
-
 			linestatus = 0;
-			discard = readb(&ch->ch_cls_uart->txrx);
+			readb(&ch->ch_cls_uart->txrx);
 			continue;
 		}
 
-- 
2.25.1


  parent reply	other threads:[~2020-11-04 19:38 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 19:35 [PATCH 00/36] Rid W=1 issues from TTY Lee Jones
2020-11-04 19:35 ` [PATCH 01/36] tty: serdev: core: Remove unused variable 'dummy' Lee Jones
2020-11-04 19:35 ` [PATCH 02/36] tty: serdev: core: Provide missing description for 'owner' Lee Jones
2020-11-04 19:35 ` Lee Jones [this message]
2020-11-04 19:35 ` [PATCH 13/36] tty: serial: 8250: 8250_port: Staticify functions referenced by pointers Lee Jones
2020-11-06  9:53   ` Greg Kroah-Hartman
2020-11-06 10:05     ` Lee Jones
2020-11-06 10:16       ` Lee Jones
2020-11-06 10:39         ` Greg Kroah-Hartman
2020-11-06 10:48           ` Lee Jones
2020-11-06 10:55             ` Greg Kroah-Hartman
2020-11-06 11:12               ` Lee Jones
2020-11-06 11:19                 ` Jiri Slaby
2020-11-06 14:47                   ` Lee Jones
2020-11-06 10:20       ` Greg Kroah-Hartman
2020-11-06 10:47         ` Lee Jones
2020-11-04 19:35 ` [PATCH 14/36] tty: serial: 8250: serial_cs: Remove unused/unchecked variable 'err' Lee Jones
2020-11-04 19:35 ` [PATCH 17/36] tty: serial: amba-pl011: Mark 'sbsa_uart_acpi_match' as __maybe_unused Lee Jones
2020-11-04 19:35 ` [PATCH 19/36] tty: serial: lpc32xx_hs: Remove unused variable 'tmp' Lee Jones
2020-11-04 20:04   ` Vladimir Zapolskiy
2020-11-04 19:35 ` [PATCH 20/36] tty: serial: msm_serial: Remove set but unused variable 'status' Lee Jones
2020-11-05 16:09   ` Jeffrey Hugo
2020-11-04 19:35 ` [PATCH 21/36] tty: serial: ifx6x60: Fix function documentation headers Lee Jones
2020-11-04 19:35 ` [PATCH 22/36] tty: serial: xilinx_uartps: Supply description for missing member 'cts_override' Lee Jones
2020-11-16 10:55   ` Maarten Brock
2020-11-16 12:38     ` Lee Jones
2020-11-04 19:35 ` [PATCH 24/36] tty: serial: serial-tegra: Struct headers should start with 'struct <name>' Lee Jones
2020-11-04 19:35 ` [PATCH 25/36] tty: serial: sifive: " Lee Jones
2020-11-06  8:11   ` Palmer Dabbelt
2020-11-04 19:35 ` [PATCH 28/36] tty: serial: stm32-usart: Remove set but unused 'cookie' variables Lee Jones
2020-11-04 19:35 ` [PATCH 30/36] tty: serial: serial-tegra: Provide some missing struct member descriptions Lee Jones
2020-11-04 19:35 ` [PATCH 34/36] tty: serial: pmac_zilog: Make disposable variable __always_unused Lee Jones
2020-11-05  7:04   ` Christophe Leroy
2020-11-05  7:39     ` Jiri Slaby
2020-11-05  8:36       ` Lee Jones
2020-11-05  8:55         ` Jiri Slaby
2020-11-05  9:00           ` Lee Jones
2020-11-06  9:54 ` [PATCH 00/36] Rid W=1 issues from TTY Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104193549.4026187-12-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).