From: Al Cooper <alcooperx@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jim Quinlan <jquinlan@broadcom.com>,
Al Cooper <alcooperx@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Rob Herring <robh+dt@kernel.org>
Subject: [PATCH 1/3] serial: 8250: of: Check for CONFIG_SERIAL_8250_BCM7271
Date: Fri, 20 Nov 2020 14:43:03 -0500 [thread overview]
Message-ID: <20201120194305.8847-2-alcooperx@gmail.com> (raw)
In-Reply-To: <20201120194305.8847-1-alcooperx@gmail.com>
From: Jim Quinlan <jquinlan@broadcom.com>
This commit has of_platform_serial_probe() check specifically for the
"brcm,bcm7271-uart" and whether its companion driver is enabled. If it
is the case, and the clock provider is not ready, we want to make sure
that when the 8250_bcm7271.c driver returns EPROBE_DEFER, we are not
getting the UART registered via 8250_of.c.
Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
---
drivers/tty/serial/8250/8250_of.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
index 65e9045dafe6..aa458f3c6644 100644
--- a/drivers/tty/serial/8250/8250_of.c
+++ b/drivers/tty/serial/8250/8250_of.c
@@ -192,6 +192,10 @@ static int of_platform_serial_probe(struct platform_device *ofdev)
u32 tx_threshold;
int ret;
+ if (IS_ENABLED(CONFIG_SERIAL_8250_BCM7271) &&
+ of_device_is_compatible(ofdev->dev.of_node, "brcm,bcm7271-uart"))
+ return -ENODEV;
+
port_type = (unsigned long)of_device_get_match_data(&ofdev->dev);
if (port_type == PORT_UNKNOWN)
return -EINVAL;
--
2.17.1
next prev parent reply other threads:[~2020-11-20 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 19:43 [PATCH 0/3] serial: 8250: Add driver for Broadcom UART Al Cooper
2020-11-20 19:43 ` Al Cooper [this message]
2020-11-23 15:58 ` [PATCH 1/3] serial: 8250: of: Check for CONFIG_SERIAL_8250_BCM7271 Jim Quinlan
2020-11-23 20:14 ` Jim Quinlan
2020-11-26 8:29 ` Greg Kroah-Hartman
2020-11-20 19:43 ` [PATCH 2/3] dt-bindings: Add support for the Broadcom UART driver Al Cooper
2020-11-20 21:04 ` Rob Herring
2020-11-20 19:43 ` [PATCH 3/3] serial: 8250: Add new 8250-core based Broadcom STB driver Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120194305.8847-2-alcooperx@gmail.com \
--to=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jquinlan@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).