From: Eric Tremblay <etremblay@distech-controls.com>
To: gregkh@linuxfoundation.org
Cc: jslaby@suse.com, andriy.shevchenko@linux.intel.com,
matwey.kornilov@gmail.com, giulio.benetti@micronovasrl.com,
lukas@wunner.de, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
christoph.muellner@theobroma-systems.com, heiko@sntech.de,
heiko.stuebner@theobroma-systems.com,
Eric Tremblay <etremblay@distech-controls.com>
Subject: [PATCH v2 0/3] Handle UART without interrupt on TEMT using em485
Date: Thu, 4 Feb 2021 11:11:55 -0500 [thread overview]
Message-ID: <20210204161158.643-1-etremblay@distech-controls.com> (raw)
Thanks everyone for the comments. I apply most of the comments on version 1
but there is still a pending point with the Jiri comment about the safety of:
struct tty_struct *tty = p->port.state->port.tty;
I thought about adding a check with tty_port_initialized() before accessing
the pointer, but I saw some other places where that same pointer is accessed
without further protection, at least from what I see.
Changes from v1 to v2:
- Use UART_CAP_NOTEMT instead of UART_CAP_TEMT
- Use some predefined macro to reduce magicness
- Reset active_timer in temt timer handler
- add uart_get_byte_size
- set UART_CAP_NOTEMT in uart_config for PORT_16550A_FSL64
- Improve commit messages
- Improve grammar and spelling
- Add Giulio and Heiko SoB to reflect previous work
Eric Tremblay (3):
serial: 8250: Handle UART without interrupt on TEMT using em485
serial: 8250: Add UART_CAP_NOTEMT on PORT_16550A_FSL64
serial: 8250: add compatible for fsl,16550-FIFO64
drivers/tty/serial/8250/8250.h | 1 +
drivers/tty/serial/8250/8250_of.c | 2 +
drivers/tty/serial/8250/8250_port.c | 68 ++++++++++++++++++++++++++++-
drivers/tty/serial/serial_core.c | 29 ++++++++----
include/linux/serial_8250.h | 2 +
include/linux/serial_core.h | 2 +
6 files changed, 94 insertions(+), 10 deletions(-)
--
2.17.1
next reply other threads:[~2021-02-04 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 16:11 Eric Tremblay [this message]
2021-02-04 16:11 ` [PATCH v2 1/3] serial: 8250: Handle UART without interrupt on TEMT using em485 Eric Tremblay
2021-02-04 21:36 ` kernel test robot
2021-10-01 12:30 ` Uwe Kleine-König
2021-10-01 13:05 ` Andy Shevchenko
2021-10-01 11:48 ` Andy Shevchenko
2021-10-04 9:45 ` Uwe Kleine-König
2021-02-04 16:11 ` [PATCH v2 2/3] serial: 8250: Add UART_CAP_NOTEMT on PORT_16550A_FSL64 Eric Tremblay
2021-10-01 11:50 ` Andy Shevchenko
2021-02-04 16:11 ` [PATCH v2 3/3] serial: 8250: add compatible for fsl,16550-FIFO64 Eric Tremblay
2021-10-01 11:50 ` Andy Shevchenko
2021-02-05 14:20 ` [PATCH v2 0/3] Handle UART without interrupt on TEMT using em485 Andy Shevchenko
2021-09-29 20:07 ` Uwe Kleine-König
2021-10-01 11:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204161158.643-1-etremblay@distech-controls.com \
--to=etremblay@distech-controls.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=giulio.benetti@micronovasrl.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=matwey.kornilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).