From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Andreas Koensgen <ajk@comnets.uni-bremen.de>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 05/16] tty: remove file from tty_mode_ioctl
Date: Wed, 15 Sep 2021 10:05:37 +0200 [thread overview]
Message-ID: <20210915080537.mcndyf6oot4v6hew@pengutronix.de> (raw)
In-Reply-To: <20210914091134.17426-5-jslaby@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
On 14.09.2021 11:11:23, Jiri Slaby wrote:
> The only user of 'file' parameter in tty_mode_ioctl is a BUG_ON check.
> Provided it never crashed for anyone, it's an overkill to pass the
> parameter to tty_mode_ioctl only for this check.
>
> If we wanted to check 'file' there, we should handle it in more graceful
> way anyway. Not by a BUG == crash.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Andreas Koensgen <ajk@comnets.uni-bremen.de>
> Cc: Paul Mackerras <paulus@samba.org>
> ---
> drivers/net/can/slcan.c | 2 +-
For the slcan.c:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-15 8:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 9:11 [PATCH 01/16] tty: unexport tty_ldisc_release Jiri Slaby
2021-09-14 9:11 ` [PATCH 02/16] tty: remove flags from struct tty_ldisc_ops Jiri Slaby
2021-09-14 9:11 ` [PATCH 03/16] tty: remove extern from functions in tty headers Jiri Slaby
2021-09-14 9:11 ` [PATCH 04/16] tty: make tty_ldisc_ops::hangup return void Jiri Slaby
2021-09-15 8:05 ` Marc Kleine-Budde
2021-09-15 11:48 ` Mark Brown
2021-09-21 3:59 ` Dmitry Torokhov
2021-09-14 9:11 ` [PATCH 05/16] tty: remove file from tty_mode_ioctl Jiri Slaby
2021-09-15 8:05 ` Marc Kleine-Budde [this message]
2021-09-14 9:11 ` [PATCH 06/16] tty: remove file from n_tty_ioctl_helper Jiri Slaby
2021-09-14 9:15 ` Krzysztof Kozlowski
2021-09-14 9:11 ` [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl Jiri Slaby
2021-09-14 9:16 ` Krzysztof Kozlowski
2021-09-15 8:02 ` Marc Kleine-Budde
2021-09-21 4:00 ` Dmitry Torokhov
2021-09-21 10:52 ` Jiri Slaby
2021-09-21 11:36 ` Greg KH
2021-09-21 15:51 ` Jiri Slaby
2021-09-22 15:01 ` Greg KH
2021-09-14 9:14 ` [PATCH 08/16] tty: drivers/tty/serial/, stop using tty_flip_buffer_push Jiri Slaby
2021-09-14 9:14 ` [PATCH 09/16] tty: drivers/tty/, " Jiri Slaby
2021-09-14 16:06 ` David Sterba
2021-09-14 9:14 ` [PATCH 10/16] tty: drivers/usb/serial/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 11/16] tty: drivers/usb/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 12/16] tty: arch/, " Jiri Slaby
2021-09-15 8:10 ` Max Filippov
2021-09-14 9:14 ` [PATCH 13/16] tty: drivers/s390/char/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 14/16] tty: drivers/staging/, " Jiri Slaby
2021-09-14 13:19 ` [greybus-dev] " Alex Elder
2021-09-14 9:14 ` [PATCH 15/16] tty: the rest, " Jiri Slaby
2021-09-14 11:58 ` Samuel Iglesias Gonsálvez
2021-09-14 9:14 ` [PATCH 16/16] tty: drop tty_flip_buffer_push Jiri Slaby
2021-09-16 10:03 ` Johan Hovold
2021-09-22 6:57 ` Jiri Slaby
2021-09-23 8:32 ` Johan Hovold
2021-11-18 7:54 ` Jiri Slaby
2021-11-18 8:10 ` Johan Hovold
2021-09-14 9:17 ` [PATCH 08/16] tty: drivers/tty/serial/, stop using tty_flip_buffer_push Krzysztof Kozlowski
2021-09-14 12:54 ` Uwe Kleine-König
2021-09-14 13:53 ` Richard Genoud
2021-09-15 17:00 ` Tobias Klauser
2021-09-15 17:53 ` Andreas Färber
2021-09-15 23:43 ` Andrew Jeffery
2021-09-16 7:13 ` Nicolas Ferre
2021-09-16 7:32 ` Chunyan Zhang
2021-09-16 7:48 ` Neil Armstrong
2021-09-16 12:54 ` Russell King (Oracle)
2021-09-16 20:30 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915080537.mcndyf6oot4v6hew@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=ajk@comnets.uni-bremen.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paulus@samba.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).