From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Tomasz Moń" <tomasz.mon@camlingroup.com>,
linux-serial@vger.kernel.org, "Jiri Slaby" <jirislaby@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
k.drobinski@camlintechnologies.com
Subject: Re: [PATCH] serial: imx: reduce RX interrupt frequency
Date: Tue, 4 Jan 2022 23:49:00 +0100 [thread overview]
Message-ID: <20220104224900.u3omfbilejx2jawr@pengutronix.de> (raw)
In-Reply-To: <YdQxmQ+OMCrabg2u@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
On Tue, Jan 04, 2022 at 12:38:01PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 04, 2022 at 12:13:06PM +0100, Tomasz Moń wrote:
> > On 04.01.2022 11:54, Greg Kroah-Hartman wrote:
> > > Why can't you do this dynamically based on the baud rate so as to always
> > > work properly for all speeds without increased delays for slower ones?
> >
> > Could you please advise on which baud rates to consider as slow? Does it
> > sound good to have the old trigger level for rates up to and including
> > 115200 and the new one for faster ones?
>
> You tell me, you are the one seeing this issue and are seeing delays on
> slower values with your change. Do some testing to see where the curve
> is.
Maybe it's more sensible to make this even more dynamic: e.g. keep it at
1 as default and increase the water level when a certain irq frequency
is reached?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-04 22:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 10:32 [PATCH] serial: imx: reduce RX interrupt frequency Tomasz Moń
2022-01-04 10:43 ` Ahmad Fatoum
2022-01-04 11:05 ` Tomasz Moń
2022-01-04 10:54 ` Greg Kroah-Hartman
2022-01-04 11:13 ` Tomasz Moń
2022-01-04 11:38 ` Greg Kroah-Hartman
2022-01-04 22:49 ` Uwe Kleine-König [this message]
2022-01-05 7:59 ` Tomasz Moń
2022-01-05 10:37 ` Greg Kroah-Hartman
2022-01-05 10:56 ` Tomasz Moń
2022-01-05 10:57 ` Marc Kleine-Budde
2022-01-06 15:39 ` Sergey Organov
2022-01-05 13:34 ` Sergey Organov
2022-01-06 15:05 ` Uwe Kleine-König
2022-01-10 6:14 ` Tomasz Moń
2022-01-10 8:31 ` Uwe Kleine-König
2022-01-05 13:00 ` Sergey Organov
2022-01-05 13:04 ` Marc Kleine-Budde
2022-01-05 13:37 ` Sergey Organov
2022-01-05 13:40 ` Marc Kleine-Budde
2022-01-05 14:37 ` Sergey Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104224900.u3omfbilejx2jawr@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=k.drobinski@camlintechnologies.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).