From: Erwan LE RAY <erwan.leray@st.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
"mani@kernel.org" <mani@kernel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Fabrice GASNIER <fabrice.gasnier@st.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [Linux-stm32] [PATCH v3 1/2] dt-bindings: serial: Document CTS/RTS gpios in STM32 UART
Date: Mon, 18 May 2020 07:25:47 +0000 [thread overview]
Message-ID: <4ff30338-e704-12bd-80fe-82b8c08e78d9@st.com> (raw)
In-Reply-To: <CAMuHMdVGem_2BGQK4dqZQb3sOd0LZk+RS_z4SvSRcNECEJHdwA@mail.gmail.com>
Hi Geert,
On 5/18/20 9:04 AM, Geert Uytterhoeven wrote:
> Hi Mani,
>
> On Mon, Apr 20, 2020 at 7:02 PM <mani@kernel.org> wrote:
>> From: Manivannan Sadhasivam <mani@kernel.org>
>>
>> Document the use of CTS/RTS gpios for flow control in STM32 UART
>> controller. These properties can be used instead of 'st,hw-flow-ctrl'
>> for making use of any gpio pins for flow control instead of dedicated
>> pins. It should be noted that both CTS/RTS and 'st,hw-flow-ctrl'
>> properties cannot co-exist in a design.
>>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
>> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> @@ -55,6 +61,14 @@ properties:
>> linux,rs485-enabled-at-boot-time: true
>> rs485-rx-during-tx: true
>>
>> +if:
>> + required:
>> + - st,hw-flow-ctrl
> Perhaps "st,hw-flow-ctrl" should be deprecated, in favor of the standard
> "uart-has-rtscts" property?
> Of course the driver needs to gain support for the latter first.
You're fully right, the patch to deprecate "st, hw-flow-ctrl" and
introduce generic "uart-has-rtscts" property in the driver is ready and
will be sent this week on top of Mani patch.
>
>> +then:
>> + properties:
>> + cts-gpios: false
>> + rts-gpios: false
>> +
>> required:
>> - compatible
>> - reg
> Gr{oetje,eeting}s,
>
> Geert
>
next prev parent reply other threads:[~2020-05-18 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 17:02 [PATCH v3 0/2] Add CTS/RTS gpio support to STM32 UART mani
2020-04-20 17:02 ` [PATCH v3 1/2] dt-bindings: serial: Document CTS/RTS gpios in " mani
2020-05-06 19:59 ` Rob Herring
2020-05-18 7:04 ` Geert Uytterhoeven
2020-05-18 7:25 ` Erwan LE RAY [this message]
2020-04-20 17:02 ` [PATCH v3 2/2] tty: serial: Add modem control gpio support for " mani
2020-04-21 12:58 ` Fabrice Gasnier
2020-05-07 14:07 ` [PATCH v3 0/2] Add CTS/RTS gpio support to " Manivannan Sadhasivam
2020-05-07 15:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff30338-e704-12bd-80fe-82b8c08e78d9@st.com \
--to=erwan.leray@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mani@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).