From: Joe Perches <joe@perches.com>
To: Dmitry Safonov <dima@arista.com>, linux-kernel@vger.kernel.org
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Vasiliy Khoruzhick <vasilykh@arista.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH-next 3/3] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
Date: Fri, 10 Jan 2020 08:50:03 -0800 [thread overview]
Message-ID: <5293a7cb1ccb16275ddb36c7f26fb9e83f4fac9b.camel@perches.com> (raw)
In-Reply-To: <20200109215444.95995-4-dima@arista.com>
On Thu, 2020-01-09 at 21:54 +0000, Dmitry Safonov wrote:
> Many embedded boards have a disconnected TTL level serial which can
> generate some garbage that can lead to spurious false sysrq detects.
trivia:
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
[]
> @@ -3081,6 +3081,38 @@ void uart_insert_char(struct uart_port *port, unsigned int status,
[]
> +const char sysrq_toggle_seq[] = CONFIG_MAGIC_SYSRQ_SERIAL_SEQUENCE;
static const?
> +static int uart_try_toggle_sysrq(struct uart_port *port, unsigned int ch)
This function return might read better as bool not int
> +{
> + if (sysrq_toggle_seq[0] == '\0')
> + return 0;
> +
> + BUILD_BUG_ON(ARRAY_SIZE(sysrq_toggle_seq) >= sizeof(port->sysrq_seq)*U8_MAX);
> + if (sysrq_toggle_seq[port->sysrq_seq] != ch) {
> + port->sysrq_seq = 0;
> + return 0;
> + }
> +
> + /* Without the last \0 */
> + if (++port->sysrq_seq < (ARRAY_SIZE(sysrq_toggle_seq) - 1)) {
> + port->sysrq = jiffies + HZ*5;
> + return 1;
> + }
> +
> + schedule_work(&sysrq_enable_work);
> +
> + port->sysrq = 0;
> + return 1;
> +}
[]
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index 255e86a474e9..1f4443db5474 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -243,10 +243,10 @@ struct uart_port {
> unsigned long sysrq; /* sysrq timeout */
> unsigned int sysrq_ch; /* char for sysrq */
> unsigned char has_sysrq;
> + unsigned char sysrq_seq; /* index in sysrq_toggle_seq */
unsigned int?
Or maybe set a maximum length of MAGIC_SYSRQ_SERIAL_SEQUENCE.
>
> unsigned char hub6; /* this should be in the 8250 driver */
> unsigned char suspended;
> - unsigned char unused;
> const char *name; /* port name */
> struct attribute_group *attr_group; /* port specific attributes */
> const struct attribute_group **tty_groups; /* all attributes (serial core use only) */
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 330909c600b1..f6f3e82fee25 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -431,6 +431,14 @@ config MAGIC_SYSRQ_SERIAL
> This option allows you to decide whether you want to enable the
> magic SysRq key.
>
> +config MAGIC_SYSRQ_SERIAL_SEQUENCE
> + string "Char sequence that enables magic SysRq over serial"
> + depends on MAGIC_SYSRQ_SERIAL
> + default ""
> + help
> + Specifies a sequence of characters that can follow BREAK to enable
> + SysRq on a serial console.
> +
> config DEBUG_FS
> bool "Debug Filesystem"
> help
next prev parent reply other threads:[~2020-01-10 17:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 21:54 [PATCH-next 0/3] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE Dmitry Safonov
2020-01-09 21:54 ` [PATCH-next 1/3] serial_core: Move sysrq functions from header file Dmitry Safonov
2020-01-10 16:50 ` Greg Kroah-Hartman
2020-01-09 21:54 ` [PATCH-next 2/3] sysctl/sysrq: Remove __sysrq_enabled copy Dmitry Safonov
2020-01-10 3:19 ` Iurii Zaikin
2020-01-10 21:48 ` Dmitry Safonov
2020-01-10 16:40 ` Greg Kroah-Hartman
2020-01-10 21:45 ` Dmitry Safonov
2020-01-10 22:01 ` Greg Kroah-Hartman
2020-01-09 21:54 ` [PATCH-next 3/3] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE Dmitry Safonov
2020-01-09 23:53 ` Randy Dunlap
2020-01-10 22:02 ` Dmitry Safonov
2020-01-10 16:46 ` Greg Kroah-Hartman
2020-01-10 22:32 ` Dmitry Safonov
2020-01-14 19:10 ` Dmitry Safonov
2020-01-15 12:42 ` Greg Kroah-Hartman
2020-01-10 16:50 ` Joe Perches [this message]
2020-01-10 22:10 ` Dmitry Safonov
2020-01-11 14:08 ` Joe Perches
2020-01-10 19:01 ` kbuild test robot
2020-01-10 19:20 ` kbuild test robot
2020-01-11 10:52 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293a7cb1ccb16275ddb36c7f26fb9e83f4fac9b.camel@perches.com \
--to=joe@perches.com \
--cc=0x7f454c46@gmail.com \
--cc=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vasilykh@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).