From: Greg Ungerer <gerg@linux-m68k.org>
To: Angelo Dureghello <angelo.dureghello@timesys.com>,
gregkh@linuxfoundation.org
Cc: linux-m68k@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: mcf: add sysrq capability
Date: Wed, 7 Oct 2020 22:00:52 +1000 [thread overview]
Message-ID: <5d1e1ebd-93f4-adb7-fb94-57aafd2cca81@linux-m68k.org> (raw)
In-Reply-To: <20201002140545.477481-1-angelo.dureghello@timesys.com>
Hi Angelo,
On 3/10/20 12:05 am, Angelo Dureghello wrote:
> After some unsuccessful attempts to use sysrq over console, figured
> out that port->has_sysrq should likely be enabled, as per other
> architectures, this when CONFIG_SERIAL_MCF_CONSOLE is also enabled.
>
> Tested some magic sysrq commands (h, p, t, b), they works now
> properly. Commands works inside 5 secs after BREAK is sent, as
> expected.
>
> Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
I can take this via the m68knommu git tree if no one else wants to pick
it up?
Regards
Greg
> ---
> drivers/tty/serial/mcf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
> index 7dbfb4cde124..09c88c48fb7b 100644
> --- a/drivers/tty/serial/mcf.c
> +++ b/drivers/tty/serial/mcf.c
> @@ -632,6 +632,7 @@ static int mcf_probe(struct platform_device *pdev)
> port->ops = &mcf_uart_ops;
> port->flags = UPF_BOOT_AUTOCONF;
> port->rs485_config = mcf_config_rs485;
> + port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MCF_CONSOLE);
>
> uart_add_one_port(&mcf_driver, port);
> }
>
prev parent reply other threads:[~2020-10-07 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 14:05 [PATCH] serial: mcf: add sysrq capability Angelo Dureghello
2020-10-07 12:00 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d1e1ebd-93f4-adb7-fb94-57aafd2cca81@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=angelo.dureghello@timesys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).