From: Marc Zyngier <maz@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@baylibre.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-amlogic@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-team@android.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] tty: serial: meson_uart: Init port lock early
Date: Sun, 05 Jul 2020 11:28:56 +0100 [thread overview]
Message-ID: <66dcb907f3b9c5413cebe14e0bec00a4@kernel.org> (raw)
In-Reply-To: <CAHp75VfFNO=oqHX9EeNdVgcQUfu7RBr6SDTWi3XF4gSQNjqzUw@mail.gmail.com>
On 2020-07-05 11:07, Andy Shevchenko wrote:
> On Sun, Jul 5, 2020 at 12:32 PM Marc Zyngier <maz@kernel.org> wrote:
>>
>> The meson UART driver triggers a lockdep splat at boot time, due
>> to the new expectation that the driver has to initialize the
>> per-port spinlock itself.
>>
>> It remains unclear why a double initialization of the port
>> spinlock is a desirable outcome, but in the meantime let's
>> fix the splat.
>>
>
> Thanks!
>
> Can you test patch from [1] if it helps and doesn't break anything in
> your case?
>
> [1]:
> https://lore.kernel.org/linux-serial/20200217114016.49856-1-andriy.shevchenko@linux.intel.com/T/#m9255e2a7474b160e66c7060fca5323ca3df49cfd
On its own, this patch doesn't seem to cure the issue (and it
adds a compile-time warning due to unused flags).
Or did you mean to test it in complement of my patch?
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-07-05 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 9:27 [PATCH] tty: serial: meson_uart: Init port lock early Marc Zyngier
2020-07-05 10:07 ` Andy Shevchenko
2020-07-05 10:28 ` Marc Zyngier [this message]
2020-07-05 11:22 ` Andy Shevchenko
2020-07-05 15:51 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66dcb907f3b9c5413cebe14e0bec00a4@kernel.org \
--to=maz@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).