* [PATCH] serial: imx: Delete duplicated argument to | in imx_uart_probe
@ 2020-09-03 2:19 Ye Bin
2020-09-03 4:44 ` Chris Ruehl
0 siblings, 1 reply; 2+ messages in thread
From: Ye Bin @ 2020-09-03 2:19 UTC (permalink / raw)
To: gregkh, linux-serial; +Cc: Ye Bin
When calculate ucr1 UCR1_TRDYEN is duplicate.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/tty/serial/imx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index ce8c472cf385..4e6ead1f650e 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2389,8 +2389,7 @@ static int imx_uart_probe(struct platform_device *pdev)
/* Disable interrupts before requesting them */
ucr1 = imx_uart_readl(sport, UCR1);
- ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN |
- UCR1_TRDYEN | UCR1_RTSDEN);
+ ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN | UCR1_RTSDEN);
imx_uart_writel(sport, ucr1, UCR1);
if (!imx_uart_is_imx1(sport) && sport->dte_mode) {
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: imx: Delete duplicated argument to | in imx_uart_probe
2020-09-03 2:19 [PATCH] serial: imx: Delete duplicated argument to | in imx_uart_probe Ye Bin
@ 2020-09-03 4:44 ` Chris Ruehl
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ruehl @ 2020-09-03 4:44 UTC (permalink / raw)
To: Ye Bin, gregkh, linux-serial
On 3/9/2020 10:19 am, Ye Bin wrote:
> When calculate ucr1 UCR1_TRDYEN is duplicate.
>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> drivers/tty/serial/imx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index ce8c472cf385..4e6ead1f650e 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -2389,8 +2389,7 @@ static int imx_uart_probe(struct platform_device *pdev)
>
> /* Disable interrupts before requesting them */
> ucr1 = imx_uart_readl(sport, UCR1);
> - ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN |
> - UCR1_TRDYEN | UCR1_RTSDEN);
> + ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN | UCR1_RTSDEN);
> imx_uart_writel(sport, ucr1, UCR1);
>
> if (!imx_uart_is_imx1(sport) && sport->dte_mode) {
>
Fixes: c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
-Chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-03 4:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 2:19 [PATCH] serial: imx: Delete duplicated argument to | in imx_uart_probe Ye Bin
2020-09-03 4:44 ` Chris Ruehl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).