From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Conor Dooley <conor@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Heiko Stuebner <heiko@sntech.de>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org,
linux-riscv@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 01/10] dt-bindings: serial: snps-dw-apb-uart: Switch dma-names order
Date: Wed, 22 Mar 2023 00:17:28 +0200 [thread overview]
Message-ID: <7cd34af7-94e7-b5e2-053c-4cc831e4cfc4@collabora.com> (raw)
In-Reply-To: <5287504e-c0f7-4964-8a61-fd49b7ee9547@spud>
On 3/22/23 00:09, Conor Dooley wrote:
> On Tue, Mar 21, 2023 at 11:56:15PM +0200, Cristian Ciocaltea wrote:
>> Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma &
>> dma-names properties") documented dma-names property to handle Allwinner
>> D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the
>> reverse of what a different board expects:
>>
>> rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected
>>
>> A quick and incomplete check shows the inconsistency is present in many
>> other DTS files:
>
>> The initial proposed solution was to allow a flexible dma-names order in
>> the binding, due to potential ABI breakage concerns after fixing the DTS
>> files. But luckily the Allwinner boards are not really affected, since
>> all of them are using a shared DMA channel for rx and tx:
>
>> Switch dma-names order to tx->rx as the first step in fixing the
>> inconsistency. The remaining DTS fixes will be handled by separate
>> patches.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks for doing all of the switch overs too. I should've probably
> broadened my searching beyond the allwinner platforms when I initially
> added this, so yeah, thanks.
Thanks for the quick review! And no worries, I'm glad I could help,
hopefully I didn't miss anything..
next prev parent reply other threads:[~2023-03-21 22:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 21:56 [PATCH v2 00/10] Enable I2S support for RK3588/RK3588S SoCs Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 01/10] dt-bindings: serial: snps-dw-apb-uart: Switch dma-names order Cristian Ciocaltea
2023-03-21 22:09 ` Conor Dooley
2023-03-21 22:17 ` Cristian Ciocaltea [this message]
2023-03-27 15:30 ` Rob Herring
2023-03-21 21:56 ` [PATCH v2 02/10] ARM: dts: sun6i: a31: Switch dma-names order for snps,dw-apb-uart nodes Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 03/10] ARM: dts: sun8i: a23/a33: " Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 04/10] ARM: dts: sun8i: v3s: " Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 05/10] ARM: dts: sunxi: h3/h5: " Cristian Ciocaltea
2023-04-08 12:13 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 06/10] riscv: dts: allwinner: d1: " Cristian Ciocaltea
2023-03-21 22:10 ` Conor Dooley
2023-04-08 12:36 ` Jernej Škrabec
2023-04-10 12:25 ` Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 07/10] arm64: dts: rockchip: rk3588s: Move assigned-clocks/assigned-clock-rates out of scmi Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 08/10] arm64: dts: rockchip: rk3588s: Add I2S nodes Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 09/10] arm64: dts: rockchip: rk3588: " Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 10/10] arm64: dts: rockchip: rk3588-rock-5b: Add analog audio Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cd34af7-94e7-b5e2-053c-4cc831e4cfc4@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).