From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D671FC33CB3 for ; Tue, 14 Jan 2020 18:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFE1C222C4 for ; Tue, 14 Jan 2020 18:33:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728057AbgANSdN (ORCPT ); Tue, 14 Jan 2020 13:33:13 -0500 Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:56188 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726839AbgANSdN (ORCPT ); Tue, 14 Jan 2020 13:33:13 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id CEE711801E56A; Tue, 14 Jan 2020 18:33:11 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bone95_7302979734f62 X-Filterd-Recvd-Size: 2619 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Tue, 14 Jan 2020 18:33:10 +0000 (UTC) Message-ID: <805e5dbb1f28e8f8b8f2599adb56294d3225c2d0.camel@perches.com> Subject: Re: [PATCHv2-next 3/3] serial_core: Remove unused member in uart_port From: Joe Perches To: Greg Kroah-Hartman , Dmitry Safonov Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Iurii Zaikin , Jiri Slaby , Randy Dunlap , Vasiliy Khoruzhick , linux-serial@vger.kernel.org Date: Tue, 14 Jan 2020 10:32:15 -0800 In-Reply-To: <20200114175647.GA2055173@kroah.com> References: <20200114171912.261787-1-dima@arista.com> <20200114171912.261787-4-dima@arista.com> <8f11e2fa-495d-fe25-f5e4-52c9580240d7@arista.com> <20200114175647.GA2055173@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, 2020-01-14 at 18:56 +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 14, 2020 at 05:47:33PM +0000, Dmitry Safonov wrote: > > On 1/14/20 5:36 PM, Joe Perches wrote: > > > On Tue, 2020-01-14 at 17:19 +0000, Dmitry Safonov wrote: > > > > It should remove the align-padding before @name. > > > [] > > > > diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h > > > [] > > > > @@ -247,7 +247,6 @@ struct uart_port { > > > > > > > > unsigned char hub6; /* this should be in the 8250 driver */ > > > > unsigned char suspended; > > > > - unsigned char unused; > > > > > > I suggest this not be applied as this is just to let > > > readers know that there is an unused 1 byte alignment > > > hole here that could be used for something else. > > > > Heh, 2/3 adds another `unsigned char`, so the neighbours look like: > > > > : unsigned long sysrq; /* sysrq timeout */ > > : unsigned int sysrq_ch; /* char for sysrq */ > > : unsigned char has_sysrq; > > : unsigned char sysrq_seq; /* index in sysrq_toggle_seq */ > > : > > : unsigned char hub6; /* this should be in the 8250 driver */ > > : unsigned char suspended; > > : unsigned char unused; > > : const char *name; /* port name */ > > > > So the hole became 4 bytes on 64-bit. Ah, perhaps the commit message could state that there is no longer an alignment hole instead. cheers, Joe