From: Dmitry Safonov <dima@arista.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-serial@vger.kernel.org
Subject: Re: [tty:tty-testing 23/75] drivers/tty/serial/21285.c:44:41: error: subscripted value is neither array nor pointer nor vector
Date: Thu, 19 Dec 2019 18:27:47 +0000 [thread overview]
Message-ID: <833de605-ecd0-34e2-c2e7-5327ab04ca98@arista.com> (raw)
In-Reply-To: <20191219073416.GA961893@kroah.com>
On 12/19/19 7:34 AM, Greg Kroah-Hartman wrote:
> On Thu, Dec 19, 2019 at 03:24:01PM +0800, kbuild test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
>> head: 82cfd2e62b354840af6a045e084f6e9e7c49584d
>> commit: 1997e9dfdc84c8f73d6fc318355cf9e313aba183 [23/75] serial_core: Un-ifdef sysrq SUPPORT_SYSRQ
>> config: arm-randconfig-a001-20191219 (attached as .config)
>> compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
>> reproduce:
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git checkout 1997e9dfdc84c8f73d6fc318355cf9e313aba183
>> # save the attached .config to linux build tree
>> GCC_VERSION=7.5.0 make.cross ARCH=arm
>>
>> If you fix the issue, kindly add following tag
>> Reported-by: kbuild test robot <lkp@intel.com>
>>
>> All error/warnings (new ones prefixed by >>):
>>
>> In file included from include/linux/kernel.h:11:0,
>> from include/linux/list.h:9,
>> from include/linux/module.h:12,
>> from drivers/tty/serial/21285.c:7:
>> drivers/tty/serial/21285.c: In function 'serial21285_stop_tx':
>>>> drivers/tty/serial/21285.c:44:41: error: subscripted value is neither array nor pointer nor vector
>> #define tx_enabled(port) ((port)->unused[0])
>> ^
>
> Ugh, this driver did the same hack the samsung_tty driver did! That's
> where samsung got the idea.
>
> I'll go fix this up as well...
Sorry that you had to clean that up - I should have checked that, rather
than blindly believe that if something is called "unused" it's actually
unused.
Thanks again,
Dmitry
prev parent reply other threads:[~2019-12-19 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 7:24 [tty:tty-testing 23/75] drivers/tty/serial/21285.c:44:41: error: subscripted value is neither array nor pointer nor vector kbuild test robot
2019-12-19 7:34 ` Greg Kroah-Hartman
2019-12-19 18:27 ` Dmitry Safonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833de605-ecd0-34e2-c2e7-5327ab04ca98@arista.com \
--to=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).