From: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-serial@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, nobuhiro1.iwamatsu@toshiba.co.jp,
shrirang.bagul@canonical.com, stable@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] serdev: Don't claim unsupported serial devices
Date: Thu, 19 Dec 2019 09:37:23 +0900 [thread overview]
Message-ID: <87eex1noak.fsf@kokedama.swc.toshiba.co.jp> (raw)
In-Reply-To: <096046b6-324a-8496-8599-ed7e5ffc6e3c@redhat.com> (Hans de Goede's message of "Wed, 18 Dec 2019 11:05:40 +0100")
Hans de Goede <hdegoede@redhat.com> writes:
> Hi,
>
> On 18-12-2019 07:56, Punit Agrawal wrote:
>> Serdev sub-system claims all serial devices that are not already
>> enumerated. As a result, no device node is created for serial port on
>> certain boards such as the Apollo Lake based UP2. This has the
>> unintended consequence of not being able to raise the login prompt via
>> serial connection.
>>
>> Introduce a blacklist to reject devices that should not be treated as
>> a serdev device. Add the Intel HS UART peripheral ids to the blacklist
>> to bring back serial port on SoCs carrying them.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Johan Hovold <johan@kernel.org>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>
> Thank you for addressing this long standing issue.
I am surprised there hasn't been more people complaining! Maybe even on
x86 mainline isn't that widely used on development boards.
> The basic approach here looks good to me, once the minor
> comments from other reviewers are addressed you can add my:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
Thanks!
[...]
next prev parent reply other threads:[~2019-12-19 0:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 6:56 [PATCH] serdev: Don't claim unsupported serial devices Punit Agrawal
2019-12-18 8:10 ` Greg Kroah-Hartman
2019-12-18 8:22 ` Punit Agrawal
2019-12-18 8:56 ` Johan Hovold
2019-12-18 9:09 ` Punit Agrawal
2019-12-19 8:39 ` Rafael J. Wysocki
2019-12-19 8:51 ` Johan Hovold
2019-12-19 8:58 ` Punit Agrawal
2019-12-18 10:05 ` Hans de Goede
2019-12-19 0:37 ` Punit Agrawal [this message]
2019-12-19 8:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eex1noak.fsf@kokedama.swc.toshiba.co.jp \
--to=punit1.agrawal@toshiba.co.jp \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=johan@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh@kernel.org \
--cc=shrirang.bagul@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).