From: Matthew Howell <mrhowel@g.clemson.edu>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, jeff.baldwin@sealevel.com,
ryan.wenglarz@sealevel.com, matthew.howell@sealevel.com
Subject: [PATCH v3] serial: exar: Fix GPIO configuration for Sealevel cards based on XR17V35X
Date: Tue, 21 Jul 2020 16:08:17 -0400 [thread overview]
Message-ID: <9318fef6-f2d4-dc77-2a25-6033d63aab9b@g.clemson.edu> (raw)
From: Matthew Howell <matthew.howell@sealevel.com>
Sealevel XR17V35X based devices are inoperable on kernel versions
4.11 and above due to a change in the GPIO preconfiguration introduced in commit
7dea8165f1d. This patch fixes this by preconfiguring the GPIO on Sealevel
cards to the value (0x00) used prior to commit 7dea8165f1d
With GPIOs preconfigured as per commit 7dea8165f1d all ports on
Sealevel XR17V35X based devices become stuck in high impedance
mode, regardless of dip-switch or software configuration. This
causes the device to become effectively unusable. This patch (in
various forms) has been distributed to our customers and no issues
related to it have been reported.
Fixes: 7dea8165f1d ("serial: exar: Preconfigure xr17v35x MPIOs as output")
Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
Patch resubmitted as per comments received on
https://www.spinics.net/lists/linux-serial/msg39371.html
Moved problem description and justification above the signed-off-by
line.
checkpatch.pl reports no styling issues with the diff below.
Let me know if I need to make any other changes.
--- linux/drivers/tty/serial/8250/8250_exar.c.orig 2020-07-09 11:05:03.920060577 -0400
+++ linux/drivers/tty/serial/8250/8250_exar.c 2020-07-13 11:54:44.386718167 -0400
@@ -326,7 +326,20 @@ static void setup_gpio(struct pci_dev *p
* devices will export them as GPIOs, so we pre-configure them safely
* as inputs.
*/
- u8 dir = pcidev->vendor == PCI_VENDOR_ID_EXAR ? 0xff : 0x00;
+
+ u8 dir = 0x00;
+
+ if ((pcidev->vendor == PCI_VENDOR_ID_EXAR) &&
+ (pcidev->subsystem_vendor != PCI_VENDOR_ID_SEALEVEL))
+ {
+ // Configure GPIO as inputs for Commtech adapters
+ dir = 0xff;
+ }
+ else
+ {
+ // Configure GPIO as outputs for SeaLevel adapters
+ dir = 0x00;
+ }
writeb(0x00, p + UART_EXAR_MPIOINT_7_0);
writeb(0x00, p + UART_EXAR_MPIOLVL_7_0);
next reply other threads:[~2020-07-21 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 20:08 Matthew Howell [this message]
2020-07-22 7:37 ` [PATCH v3] serial: exar: Fix GPIO configuration for Sealevel cards based on XR17V35X Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9318fef6-f2d4-dc77-2a25-6033d63aab9b@g.clemson.edu \
--to=mrhowel@g.clemson.edu \
--cc=gregkh@linuxfoundation.org \
--cc=jeff.baldwin@sealevel.com \
--cc=linux-serial@vger.kernel.org \
--cc=matthew.howell@sealevel.com \
--cc=ryan.wenglarz@sealevel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).