From: Peng Fan <peng.fan@nxp.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jslaby@suse.com" <jslaby@suse.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Alice Guo <alice.guo@nxp.com>
Subject: RE: [PATCH 2/3] tty: serial: lpuart: support UPIO_MEM32 for lpuart32
Date: Wed, 18 Dec 2019 12:26:09 +0000 [thread overview]
Message-ID: <AM0PR04MB4481D6C5CD27F410359F53A788530@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1576637626-19317-4-git-send-email-peng.fan@nxp.com>
Hi Greg,
> Subject: [PATCH 2/3] tty: serial: lpuart: support UPIO_MEM32 for lpuart32
This patch was sent out wrongly. Not affect the other three patches which
belongs the whole patch set described in cover-letter.
Should I sent out v2? Or you are fine if the other 3 patches are ok?
Thanks,
Peng.
>
> From: Peng Fan <peng.fan@nxp.com>
>
> "earlycon" no need to specify the value string since it uses stdout-path
> parameters. However when earlycon and normal console are not using the
> same uart port, we need specify value string to earlycon, this is what we need
> to do when support dual linux using jailhouse hypervisor. The 2nd linux will
> use the uart of the 1st linux as earlycon.
>
> earlycon=lpuart32,mmio32,0x5a060010,115200 not work for i.MX8QXP.
> It is because lpuart32_early_console_setup not support little endian.
>
> Since the original code is to support UPIO_MEM32BE, so if not UPIO_MEM32,
> we still take it as UPIO_MEM32BE
>
> Acked-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/tty/serial/fsl_lpuart.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> 54c7735406f8..6ad0af073e62 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -2376,7 +2376,9 @@ static int __init
> lpuart32_early_console_setup(struct earlycon_device *device,
> if (!device->port.membase)
> return -ENODEV;
>
> - device->port.iotype = UPIO_MEM32BE;
> + if (device->port.iotype != UPIO_MEM32)
> + device->port.iotype = UPIO_MEM32BE;
> +
> device->con->write = lpuart32_early_write;
> return 0;
> }
> --
> 2.16.4
next prev parent reply other threads:[~2019-12-18 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 2:56 [PATCH 0/3] tty: serial: lpuart: cleanup and improve for earlycon Peng Fan
2019-12-18 2:56 ` [PATCH 1/3] tty: serial: fsl_lpuart: drop EARLYCON_DECLARE Peng Fan
2019-12-18 2:56 ` [PATCH 2/3] tty: serial: fsl_lpuart: support UPIO_MEM32 for lpuart32 Peng Fan
2019-12-18 2:56 ` [PATCH 2/3] tty: serial: lpuart: " Peng Fan
2019-12-18 12:26 ` Peng Fan [this message]
2019-12-19 16:43 ` gregkh
2019-12-18 2:56 ` [PATCH 3/3] tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4481D6C5CD27F410359F53A788530@AM0PR04MB4481.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=alice.guo@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).