Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
From: Andy Duan <fugang.duan@nxp.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Greg KH" <gregkh@linuxfoundation.org>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"lukas@wunner.de" <lukas@wunner.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"jslaby@suse.com" <jslaby@suse.com>
Subject: RE: [EXT] Re: [PATCH tty/serial 1/1] tty: serial: imx: enable imx serial console port as module
Date: Mon, 29 Jun 2020 01:46:37 +0000
Message-ID: <AM6PR0402MB360755114CB6C506014CE308FF6E0@AM6PR0402MB3607.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200628160001.nmogndgajqbalzfo@pengutronix.de>

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Sent: Monday, June 29, 2020 12:00 AM
> On Sat, Jun 27, 2020 at 04:23:15PM +0200, Greg KH wrote:
> > On Fri, Jun 05, 2020 at 04:43:21PM +0800, Fugang Duan wrote:
> > > GKI kernel requires drivers built as modules including console
> > > driver, so add the support that imx serial console driver can be
> > > built as module.
> > >
> > > The changes of the patch:
> > > - imx console driver can be built as module.
> > > - move out earlycon code to separated driver like imx_earlycon.c,
> > >   and imx earlycon driver only support build-in.
> > >
> > > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > > ---
> > >  drivers/tty/serial/Kconfig        | 17 +++++++----
> > >  drivers/tty/serial/Makefile       |  1 +
> > >  drivers/tty/serial/imx.c          | 37 ++---------------------
> > >  drivers/tty/serial/imx_earlycon.c | 50
> > > +++++++++++++++++++++++++++++++
> > >  4 files changed, 65 insertions(+), 40 deletions(-)
> > >
> > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > index adf9e80e7dc9..890cbf214561 100644
> > > --- a/drivers/tty/serial/Kconfig
> > > +++ b/drivers/tty/serial/Kconfig
> > > @@ -502,20 +502,27 @@ config SERIAL_IMX
> > >  	  can enable its onboard serial port by enabling this option.
> > >
> > >  config SERIAL_IMX_CONSOLE
> > > -	bool "Console on IMX serial port"
> > > -	depends on SERIAL_IMX=y
> > > +	tristate "Console on IMX serial port"
> > > +	depends on SERIAL_IMX
> > >  	select SERIAL_CORE_CONSOLE
> > > -	select SERIAL_EARLYCON if OF
> > >  	help
> > >  	  If you have enabled the serial port on the Freescale IMX
> > > -	  CPU you can make it the console by answering Y to this option.
> > > +	  CPU you can make it the console by answering Y/M to this option.
> > >
> > > -	  Even if you say Y here, the currently visible virtual console
> > > +	  Even if you say Y/M here, the currently visible virtual console
> > >  	  (/dev/tty0) will still be used as the system console by default, but
> > >  	  you can alter that using a kernel command line option such as
> > >  	  "console=ttymxc0". (Try "man bootparam" or see the
> documentation of
> > >  	  your bootloader about how to pass options to the kernel at boot
> > > time.)
> > >
> > > +config SERIAL_IMX_EARLYCON
> > > +	bool "Earlycon on IMX serial port"
> > > +	depends OF
> > > +	select SERIAL_EARLYCON if OF
> 
> Given that SERIAL_IMX_EARLYCON depends on OF, the select can be
> unconditional.

Got it, select SERIAL_EARLYCON is unconditional, will update it in v2.
Thanks.

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  8:43 Fugang Duan
2020-06-27 14:23 ` Greg KH
2020-06-28  6:26   ` [EXT] " Andy Duan
2020-06-28 16:00   ` Uwe Kleine-König
2020-06-29  1:46     ` Andy Duan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR0402MB360755114CB6C506014CE308FF6E0@AM6PR0402MB3607.eurprd04.prod.outlook.com \
    --to=fugang.duan@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git