Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux MMC List <linux-mmc@vger.kernel.org>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
	LAK <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/8] arm64: dts: renesas: Initial r8a774e1 SoC device tree
Date: Wed, 8 Jul 2020 19:07:24 +0100
Message-ID: <CA+V-a8ssT==SsVRgbM1kwP4U3-f6=1h4es547isTvANpydwi4g@mail.gmail.com> (raw)
In-Reply-To: <daf83dafc069b12b6a10205e5f93793a@kernel.org>

Hi Marc,

Thank you for the review.

On Wed, Jul 8, 2020 at 6:53 PM Marc Zyngier <maz@kernel.org> wrote:
>
> On 2020-07-08 18:48, Lad Prabhakar wrote:
> > From: Marian-Cristian Rotariu
> > <marian-cristian.rotariu.rb@bp.renesas.com>
> >
> > Basic support for the RZ/G2H SoC.
> >
> > Signed-off-by: Marian-Cristian Rotariu
> > <marian-cristian.rotariu.rb@bp.renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 652 ++++++++++++++++++++++
> >  1 file changed, 652 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> > new file mode 100644
> > index 000000000000..6637e157ffcd
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
>
> [...]
> > +             gic: interrupt-controller@f1010000 {
> > +                     compatible = "arm,gic-400";
> > +                     #interrupt-cells = <3>;
> > +                     #address-cells = <0>;
> > +                     interrupt-controller;
> > +                     reg = <0x0 0xf1010000 0 0x1000>,
> > +                           <0x0 0xf1020000 0 0x20000>,
> > +                           <0x0 0xf1040000 0 0x20000>,
> > +                           <0x0 0xf1060000 0 0x20000>;
> > +                     interrupts = <GIC_PPI 9
> > +                                     (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
>
> You seem to have a bit more than only 2 CPUs in this system.
>
Argh should be 8.

Cheers,
--Prabhakar

> > +                     clocks = <&cpg CPG_MOD 408>;
> > +                     clock-names = "clk";
> > +                     power-domains = <&sysc R8A774E1_PD_ALWAYS_ON>;
> > +                     resets = <&cpg 408>;
> > +             };
>
>          M.
> --
> Jazz is not dead. It just smells funny...

  reply index

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 17:48 [PATCH 0/8] Add basic DT support for R8A774E1 SoC enabling HiHope RZ/G2H board Lad Prabhakar
2020-07-08 17:48 ` [PATCH 1/8] dt-bindings: serial: renesas,scif: Document r8a774e1 bindings Lad Prabhakar
2020-07-13 11:23   ` Geert Uytterhoeven
2020-07-20 22:20   ` [PATCH 1/8] dt-bindings: serial: renesas, scif: " Rob Herring
2020-09-19 10:35   ` [PATCH 1/8] dt-bindings: serial: renesas,scif: " Lad, Prabhakar
2020-07-08 17:48 ` [PATCH 2/8] dt-bindings: serial: renesas,hscif: " Lad Prabhakar
2020-07-13 11:24   ` Geert Uytterhoeven
2020-07-20 22:20   ` [PATCH 2/8] dt-bindings: serial: renesas, hscif: " Rob Herring
2020-09-19 10:38   ` [PATCH 2/8] dt-bindings: serial: renesas,hscif: " Lad, Prabhakar
2020-07-08 17:48 ` [PATCH 3/8] dt-bindings: irqchip: renesas-irqc: " Lad Prabhakar
2020-07-13 11:25   ` Geert Uytterhoeven
2020-07-20 22:21   ` Rob Herring
2020-07-08 17:48 ` [PATCH 4/8] dt-bindings: mmc: renesas,sdhi: Add r8a774e1 support Lad Prabhakar
2020-07-13 11:26   ` Geert Uytterhoeven
2020-07-20 22:21   ` Rob Herring
2020-08-05  6:32   ` Ulf Hansson
2020-08-05  8:04     ` Lad, Prabhakar
2020-07-08 17:48 ` [PATCH 5/8] arm64: defconfig: Enable R8A774E1 SoC Lad Prabhakar
2020-07-13 11:28   ` Geert Uytterhoeven
2020-07-08 17:48 ` [PATCH 6/8] arm64: dts: renesas: Initial r8a774e1 SoC device tree Lad Prabhakar
2020-07-08 17:53   ` Marc Zyngier
2020-07-08 18:07     ` Lad, Prabhakar [this message]
2020-07-13 12:24   ` Geert Uytterhoeven
2020-07-16 14:50   ` Geert Uytterhoeven
2020-07-16 16:50     ` Prabhakar Mahadev Lad
2020-07-08 17:48 ` [PATCH 7/8] arm64: dts: renesas: Add HiHope RZ/G2H main board support Lad Prabhakar
2020-07-13 12:25   ` Geert Uytterhoeven
2020-07-08 17:48 ` [PATCH 8/8] arm64: dts: renesas: Add HiHope RZ/G2H sub " Lad Prabhakar
2020-07-13 12:25   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+V-a8ssT==SsVRgbM1kwP4U3-f6=1h4es547isTvANpydwi4g@mail.gmail.com' \
    --to=prabhakar.csengg@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=maz@kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git