From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Orson Zhai <orsonzhai@gmail.com>
Cc: Chunyan Zhang <chunyan.zhang@unisoc.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
DTML <devicetree@vger.kernel.org>,
linux-serial@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Baolin Wang <baolin.wang7@gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: serial: Add a new compatible string for SC9863A
Date: Tue, 29 Oct 2019 10:47:48 +0800 [thread overview]
Message-ID: <CAAfSe-uz396tvOSa6g-BJpwzARDi2uaPrCsP01f3A-Jww_c7BA@mail.gmail.com> (raw)
In-Reply-To: <CA+H2tpHkYwQLEO7ftLebErsEXBQnRS37gFOoKoG+_jnt5+0r-A@mail.gmail.com>
On Sat, 26 Oct 2019 at 10:11, Orson Zhai <orsonzhai@gmail.com> wrote:
>
> Hi Chunyan,
>
> On Fri, Oct 25, 2019 at 6:30 PM Chunyan Zhang <chunyan.zhang@unisoc.com> wrote:
> >
> >
> > SC9863A use the same serial device which SC9836 uses.
> >
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > ---
> > Documentation/devicetree/bindings/serial/sprd-uart.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> > index 9607dc616205..0a9f8a7809e1 100644
> > --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
> > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> > @@ -4,6 +4,7 @@ Required properties:
> > - compatible: must be one of:
> > * "sprd,sc9836-uart"
> > * "sprd,sc9860-uart", "sprd,sc9836-uart"
> > + * "sprd,sc9863-uart", "sprd,sc9836-uart"
>
> Duplicated 9836 with above line?
We can just use "sprd,sc9836-uart" for SC9860 and SC9863 SoCs though,
added a new compatible string in case we'll have some difference for
serial on SC9863A in the furture.
Thanks,
Chunyan
>
> -Orson
>
> >
> > - reg: offset and length of the register set for the device
> > - interrupts: exactly one interrupt specifier
> > --
> > 2.20.1
> >
> >
next prev parent reply other threads:[~2019-10-29 2:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 10:29 [PATCH 0/3] Add Unisoc's SC9863A support Chunyan Zhang
2019-10-25 10:29 ` [PATCH 1/3] dt-bindings: serial: Add a new compatible string for SC9863A Chunyan Zhang
2019-10-26 2:11 ` Orson Zhai
2019-10-29 2:47 ` Chunyan Zhang [this message]
2019-10-29 21:44 ` Rob Herring
2019-11-08 10:36 ` Chunyan Zhang
2019-10-25 10:29 ` [PATCH 2/3] dt-bindings: arm: Add bindings for Unisoc's SC9863A Chunyan Zhang
2019-10-29 21:46 ` Rob Herring
2019-11-08 10:36 ` Chunyan Zhang
2019-10-25 10:29 ` [PATCH 3/3] arm64: dts: Add Unisoc's SC9863A SoC support Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAfSe-uz396tvOSa6g-BJpwzARDi2uaPrCsP01f3A-Jww_c7BA@mail.gmail.com \
--to=zhang.lyra@gmail.com \
--cc=baolin.wang7@gmail.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).