Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles
@ 2020-08-23 16:15 Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property Krzysztof Kozlowski
                   ` (21 more replies)
  0 siblings, 22 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8 SoCs introduce their own compatibles so add them
to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
    compatible:0: 'fsl,imx8mm-gpio' is not one of ['fsl,imx1-gpio', 'fsl,imx21-gpio', 'fsl,imx31-gpio', 'fsl,imx35-gpio', 'fsl,imx7d-gpio']
    From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
    compatible: ['fsl,imx8mm-gpio', 'fsl,imx35-gpio'] is too long

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
    compatible: Additional items are not allowed ('fsl,imx35-gpio' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../bindings/gpio/fsl-imx-gpio.yaml           | 21 +++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
index 0b223abe8cfb..454db20c2d1a 100644
--- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
@@ -11,12 +11,21 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx1-gpio
-      - fsl,imx21-gpio
-      - fsl,imx31-gpio
-      - fsl,imx35-gpio
-      - fsl,imx7d-gpio
+    oneOf:
+      - enum:
+          - fsl,imx1-gpio
+          - fsl,imx21-gpio
+          - fsl,imx31-gpio
+          - fsl,imx35-gpio
+          - fsl,imx7d-gpio
+      - items:
+          - enum:
+              - fsl,imx8mm-gpio
+              - fsl,imx8mn-gpio
+              - fsl,imx8mp-gpio
+              - fsl,imx8mq-gpio
+              - fsl,imx8qxp-gpio
+          - const: fsl,imx35-gpio
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-24  5:24   ` Sascha Hauer
  2020-08-23 16:15 ` [PATCH 03/22] dt-bindings: gpio: fsl-imx-gpio: Add parsing of hogs Krzysztof Kozlowski
                   ` (20 subsequent siblings)
  21 siblings, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

The GPIO controller node can have gpio-ranges property.  This fixes
dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
    From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/gpio/fsl-imx-gpio.yaml    | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
index 454db20c2d1a..1fac69573bb9 100644
--- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
@@ -51,6 +51,9 @@ properties:
 
   gpio-controller: true
 
+  gpio-ranges:
+    maxItems: 1
+
 required:
   - compatible
   - reg
@@ -62,6 +65,18 @@ required:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx8mp-gpio
+    then:
+      properties:
+        gpio-ranges:
+          minItems: 1
+          maxItems: 2
+
 examples:
   - |
     gpio0: gpio@73f84000 {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 03/22] dt-bindings: gpio: fsl-imx-gpio: Add parsing of hogs
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 04/22] dt-bindings: gpio: fsl-imx-gpio: Add power-domains Krzysztof Kozlowski
                   ` (19 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

Allow parsing GPIO controller children nodes with GPIO hogs to fix
warning:

  arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpio@30240000: 'wl-reg-on' does not match any of the regexes: 'pinctrl-[0-9]+'
    From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/gpio/fsl-imx-gpio.yaml  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
index 1fac69573bb9..337b99343dce 100644
--- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
@@ -54,6 +54,23 @@ properties:
   gpio-ranges:
     maxItems: 1
 
+patternProperties:
+  "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
+    type: object
+    properties:
+      gpio-hog: true
+      gpios: true
+      input: true
+      output-high: true
+      output-low: true
+      line-name: true
+
+    required:
+      - gpio-hog
+      - gpios
+
+    additionalProperties: false
+
 required:
   - compatible
   - reg
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 04/22] dt-bindings: gpio: fsl-imx-gpio: Add power-domains
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 03/22] dt-bindings: gpio: fsl-imx-gpio: Add parsing of hogs Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 05/22] dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles Krzysztof Kozlowski
                   ` (18 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

Parse also optional power-domains property to fix dtbs_check warnings
like:

  arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: gpio@5d080000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
    From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
index 337b99343dce..a7d17a98df6b 100644
--- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
@@ -54,6 +54,9 @@ properties:
   gpio-ranges:
     maxItems: 1
 
+  power-domains:
+    maxItems: 1
+
 patternProperties:
   "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
     type: object
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 05/22] dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 04/22] dt-bindings: gpio: fsl-imx-gpio: Add power-domains Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 06/22] dt-bindings: pwm: imx-pwm: " Krzysztof Kozlowski
                   ` (17 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
    compatible:0: 'fsl,imx8mm-ddr-pmu' is not one of ['fsl,imx8-ddr-pmu', 'fsl,imx8m-ddr-pmu', 'fsl,imx8mp-ddr-pmu']
    From schema: Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
    compatible: ['fsl,imx8mm-ddr-pmu', 'fsl,imx8m-ddr-pmu'] is too long

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
    compatible: Additional items are not allowed ('fsl,imx8m-ddr-pmu' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/perf/fsl-imx-ddr.yaml     | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
index 9ed8f44adabe..3900b1093de0 100644
--- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
+++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
@@ -11,10 +11,17 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx8-ddr-pmu
-      - fsl,imx8m-ddr-pmu
-      - fsl,imx8mp-ddr-pmu
+    oneOf:
+      - enum:
+          - fsl,imx8-ddr-pmu
+          - fsl,imx8m-ddr-pmu
+          - fsl,imx8mp-ddr-pmu
+      - items:
+          - enum:
+              - fsl,imx8mm-ddr-pmu
+              - fsl,imx8mn-ddr-pmu
+              - fsl,imx8mq-ddr-pmu
+          - const: fsl,imx8m-ddr-pmu
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 06/22] dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (3 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 05/22] dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 07/22] dt-bindings: serial: fsl-imx-uart: " Krzysztof Kozlowski
                   ` (16 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
    compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm']
    From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
    compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
    compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
index 01df06777cba..473863eb67e5 100644
--- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
@@ -19,9 +19,17 @@ properties:
       - 3
 
   compatible:
-    enum:
-      - fsl,imx1-pwm
-      - fsl,imx27-pwm
+    oneOf:
+      - enum:
+          - fsl,imx1-pwm
+          - fsl,imx27-pwm
+      - items:
+          - enum:
+              - fsl,imx8mm-pwm
+              - fsl,imx8mn-pwm
+              - fsl,imx8mp-pwm
+              - fsl,imx8mq-pwm
+          - const: fsl,imx27-pwm
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 07/22] dt-bindings: serial: fsl-imx-uart: imx-pwm: Add i.MX 8M compatibles
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (4 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 06/22] dt-bindings: pwm: imx-pwm: " Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-24  5:46   ` Sascha Hauer
  2020-08-23 16:15 ` [PATCH 08/22] dt-bindings: watchdog: fsl-imx-wdt: " Krzysztof Kozlowski
                   ` (15 subsequent siblings)
  21 siblings, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
    compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm']
    From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
    compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
    compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
index cba3f83ccd5f..3d896173b3b0 100644
--- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
@@ -36,6 +36,10 @@ properties:
             - fsl,imx6sx-uart
             - fsl,imx6ul-uart
             - fsl,imx7d-uart
+            - fsl,imx8mm-uart
+            - fsl,imx8mn-uart
+            - fsl,imx8mp-uart
+            - fsl,imx8mq-uart
           - const: fsl,imx6q-uart
 
   reg:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 08/22] dt-bindings: watchdog: fsl-imx-wdt: Add i.MX 8M compatibles
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (5 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 07/22] dt-bindings: serial: fsl-imx-uart: " Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 09/22] dt-bindings: mtd: gpmi-nand: " Krzysztof Kozlowski
                   ` (14 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
    compatible:0: 'fsl,imx8mm-wdt' is not one of ['fsl,imx21-wdt']
    From schema: Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml

  arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
    compatible: ['fsl,imx8mm-wdt', 'fsl,imx21-wdt'] is too long

  arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
    compatible: Additional items are not allowed ('fsl,imx21-wdt' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml     | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index d96b93b11fad..991b4e33486e 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -14,8 +14,15 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx21-wdt
+    oneOf:
+      - const: fsl,imx21-wdt
+      - items:
+          - enum:
+              - fsl,imx8mm-wdt
+              - fsl,imx8mn-wdt
+              - fsl,imx8mp-wdt
+              - fsl,imx8mq-wdt
+          - const: fsl,imx21-wdt
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 09/22] dt-bindings: mtd: gpmi-nand: Add i.MX 8M compatibles
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (6 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 08/22] dt-bindings: watchdog: fsl-imx-wdt: " Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 10/22] dt-bindings: reset: fsl,imx7-src: " Krzysztof Kozlowski
                   ` (13 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
    compatible:0: 'fsl,imx8mm-gpmi-nand' is not one of ['fsl,imx23-gpmi-nand', 'fsl,imx28-gpmi-nand', 'fsl,imx6q-gpmi-nand', 'fsl,imx6sx-gpmi-nand', 'fsl,imx7d-gpmi-nand']
    From schema: Documentation/devicetree/bindings/mtd/gpmi-nand.yaml

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
    compatible: ['fsl,imx8mm-gpmi-nand', 'fsl,imx7d-gpmi-nand'] is too long

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
    compatible: Additional items are not allowed ('fsl,imx7d-gpmi-nand' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/mtd/gpmi-nand.yaml     | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
index 3201372b7f85..28ff8c581837 100644
--- a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
+++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
@@ -20,12 +20,18 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - fsl,imx23-gpmi-nand
-      - fsl,imx28-gpmi-nand
-      - fsl,imx6q-gpmi-nand
-      - fsl,imx6sx-gpmi-nand
-      - fsl,imx7d-gpmi-nand
+    oneOf:
+      - enum:
+          - fsl,imx23-gpmi-nand
+          - fsl,imx28-gpmi-nand
+          - fsl,imx6q-gpmi-nand
+          - fsl,imx6sx-gpmi-nand
+          - fsl,imx7d-gpmi-nand
+      - items:
+          - enum:
+              - fsl,imx8mm-gpmi-nand
+              - fsl,imx8mn-gpmi-nand
+          - const: fsl,imx7d-gpmi-nand
 
   reg:
     items:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 10/22] dt-bindings: reset: fsl,imx7-src: Add i.MX 8M compatibles
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (7 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 09/22] dt-bindings: mtd: gpmi-nand: " Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 11/22] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible Krzysztof Kozlowski
                   ` (12 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
    compatible:0: 'fsl,imx8mm-src' is not one of ['fsl,imx7d-src', 'fsl,imx8mq-src', 'fsl,imx8mp-src']
    From schema: Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
    compatible:1: 'syscon' was expected

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
    compatible: ['fsl,imx8mm-src', 'fsl,imx8mq-src', 'syscon'] is too long

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../bindings/reset/fsl,imx7-src.yaml          | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml
index 569cd3bd3a70..00430e2eabc8 100644
--- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml
+++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml
@@ -22,12 +22,19 @@ description: |
 
 properties:
   compatible:
-    items:
-      - enum:
-          - fsl,imx7d-src
-          - fsl,imx8mq-src
-          - fsl,imx8mp-src
-      - const: syscon
+    oneOf:
+      - items:
+          - enum:
+              - fsl,imx7d-src
+              - fsl,imx8mq-src
+              - fsl,imx8mp-src
+          - const: syscon
+      - items:
+          - enum:
+              - fsl,imx8mm-src
+              - fsl,imx8mn-src
+          - const: fsl,imx8mq-src
+          - const: syscon
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 11/22] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (8 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 10/22] dt-bindings: reset: fsl,imx7-src: " Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 12/22] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8M compatible matching Krzysztof Kozlowski
                   ` (11 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
    compatible:0: 'fsl,imx8mn-tmu' is not one of ['fsl,imx8mm-tmu', 'fsl,imx8mp-tmu']
    From schema: Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
    compatible: ['fsl,imx8mn-tmu', 'fsl,imx8mm-tmu'] is too long

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
    compatible: Additional items are not allowed ('fsl,imx8mm-tmu' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/thermal/imx8mm-thermal.yaml    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml b/Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml
index 38852877b8e3..89c54e08ee61 100644
--- a/Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml
@@ -18,9 +18,13 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - fsl,imx8mm-tmu
-      - fsl,imx8mp-tmu
+    oneOf:
+      - enum:
+          - fsl,imx8mm-tmu
+          - fsl,imx8mp-tmu
+      - items:
+          - const: fsl,imx8mn-tmu
+          - const: fsl,imx8mm-tmu
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 12/22] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8M compatible matching
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (9 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 11/22] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 13/22] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles Krzysztof Kozlowski
                   ` (10 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

The i.MX 8M DTSes use two compatibles so update the binding to fix
dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
    compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long
    From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
    compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)

  arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: mmc@30b40000:
    compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../bindings/mmc/fsl-imx-esdhc.yaml           | 38 ++++++++++---------
 1 file changed, 21 insertions(+), 17 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index 10b45966f1b8..f26e0755b38d 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -21,23 +21,27 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - fsl,imx25-esdhc
-      - fsl,imx35-esdhc
-      - fsl,imx51-esdhc
-      - fsl,imx53-esdhc
-      - fsl,imx6q-usdhc
-      - fsl,imx6sl-usdhc
-      - fsl,imx6sx-usdhc
-      - fsl,imx6ull-usdhc
-      - fsl,imx7d-usdhc
-      - fsl,imx7ulp-usdhc
-      - fsl,imx8mq-usdhc
-      - fsl,imx8mm-usdhc
-      - fsl,imx8mn-usdhc
-      - fsl,imx8mp-usdhc
-      - fsl,imx8qm-usdhc
-      - fsl,imx8qxp-usdhc
+    oneOf:
+      - enum:
+          - fsl,imx25-esdhc
+          - fsl,imx35-esdhc
+          - fsl,imx51-esdhc
+          - fsl,imx53-esdhc
+          - fsl,imx6q-usdhc
+          - fsl,imx6sl-usdhc
+          - fsl,imx6sx-usdhc
+          - fsl,imx6ull-usdhc
+          - fsl,imx7d-usdhc
+          - fsl,imx7ulp-usdhc
+          - fsl,imx8mq-usdhc
+          - fsl,imx8mm-usdhc
+          - fsl,imx8qxp-usdhc
+      - items:
+          - enum:
+              - fsl,imx8mn-usdhc
+              - fsl,imx8mp-usdhc
+              - fsl,imx8mq-usdhc
+          - const: fsl,imx7d-usdhc
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 13/22] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (10 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 12/22] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8M compatible matching Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 14/22] dt-bindings: arm: fsl: Fix Toradex Colibri i.MX 8 binding Krzysztof Kozlowski
                   ` (9 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs use two compatibles so update the binding to
fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000: compatible:1: 'syscon' was expected
    From schema: Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000:
    compatible: ['fsl,imx8mn-ocotp', 'fsl,imx8mm-ocotp', 'syscon'] is too long

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000:
    compatible: Additional items are not allowed ('syscon' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/nvmem/imx-ocotp.yaml  | 39 ++++++++++++-------
 1 file changed, 24 insertions(+), 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
index 1c9d7f05f173..b5b250185afd 100644
--- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
+++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
@@ -19,21 +19,30 @@ allOf:
 
 properties:
   compatible:
-    items:
-      - enum:
-          - fsl,imx6q-ocotp
-          - fsl,imx6sl-ocotp
-          - fsl,imx6sx-ocotp
-          - fsl,imx6ul-ocotp
-          - fsl,imx6ull-ocotp
-          - fsl,imx7d-ocotp
-          - fsl,imx6sll-ocotp
-          - fsl,imx7ulp-ocotp
-          - fsl,imx8mq-ocotp
-          - fsl,imx8mm-ocotp
-          - fsl,imx8mn-ocotp
-          - fsl,imx8mp-ocotp
-      - const: syscon
+    oneOf:
+      - items:
+          - enum:
+              - fsl,imx6q-ocotp
+              - fsl,imx6sl-ocotp
+              - fsl,imx6sx-ocotp
+              - fsl,imx6ul-ocotp
+              - fsl,imx6ull-ocotp
+              - fsl,imx7d-ocotp
+              - fsl,imx6sll-ocotp
+              - fsl,imx7ulp-ocotp
+              - fsl,imx8mq-ocotp
+              - fsl,imx8mm-ocotp
+              - fsl,imx8mn-ocotp
+              - fsl,imx8mp-ocotp
+          - const: syscon
+      - items:
+          # The devices are not really compatible with fsl,imx8mm-ocotp, however
+          # the code for getting SoC revision depends on fsl,imx8mm-ocotp compatible.
+          - enum:
+              - fsl,imx8mn-ocotp
+              - fsl,imx8mp-ocotp
+          - const: fsl,imx8mm-ocotp
+          - const: syscon
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 14/22] dt-bindings: arm: fsl: Fix Toradex Colibri i.MX 8 binding
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (11 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 13/22] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 15/22] dt-bindings: arm: fsl: Add ZII Ultra boards binding Krzysztof Kozlowski
                   ` (8 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

The Toradex Colibri i.MX 8 Evaluation board has two Toradex compatibles
so it needs separate entry.  This fixes dtbs_check warning:

  arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: /:
    compatible: ['toradex,colibri-imx8x-eval-v3', 'toradex,colibri-imx8x', 'fsl,imx8qxp'] is not valid under any of the given schemas (Possible causes of the failure):
    arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: /: compatible: ['toradex,colibri-imx8x-eval-v3', 'toradex,colibri-imx8x', 'fsl,imx8qxp'] is too long

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 591fa336d6fa..93a21b10d115 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -385,7 +385,13 @@ properties:
               - einfochips,imx8qxp-ai_ml  # i.MX8QXP AI_ML Board
               - fsl,imx8qxp-mek           # i.MX8QXP MEK Board
               - toradex,colibri-imx8x         # Colibri iMX8X Module
+          - const: fsl,imx8qxp
+
+      - description: Toradex Colibri i.MX8 Evaluation Board
+        items:
+          - enum:
               - toradex,colibri-imx8x-eval-v3 # Colibri iMX8X Module on Colibri Evaluation Board V3
+          - const: toradex,colibri-imx8x
           - const: fsl,imx8qxp
 
       - description:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 15/22] dt-bindings: arm: fsl: Add ZII Ultra boards binding
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (12 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 14/22] dt-bindings: arm: fsl: Fix Toradex Colibri i.MX 8 binding Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 16/22] dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible matching Krzysztof Kozlowski
                   ` (7 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

Document the binding for Zodiac Inflight Innovations Ultra Boards.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 93a21b10d115..f2e670e9ae54 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -379,6 +379,14 @@ properties:
               - technexion,pico-pi-imx8m  # TechNexion PICO-PI-8M evk
           - const: fsl,imx8mq
 
+      - description: Zodiac Inflight Innovations Ultra Boards
+        items:
+          - enum:
+              - zii,imx8mq-ultra-rmb3
+              - zii,imx8mq-ultra-zest
+          - const: zii,imx8mq-ultra
+          - const: fsl,imx8mq
+
       - description: i.MX8QXP based Boards
         items:
           - enum:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 16/22] dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible matching
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (13 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 15/22] dt-bindings: arm: fsl: Add ZII Ultra boards binding Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 17/22] arm64: dts: imx8mq-evk: Add hog suffix to wl-reg-on Krzysztof Kozlowski
                   ` (6 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

The i.MX 8M DTSes use two compatibles so update the binding to fix
dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mq-thor96.dt.yaml: interrupt-controller@32e2d000:
    compatible: ['fsl,imx8m-irqsteer', 'fsl,imx-irqsteer'] is too long
    From schema: Domentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml

  arch/arm64/boot/dts/freescale/imx8mq-thor96.dt.yaml: interrupt-controller@32e2d000:
    compatible: Additional items are not allowed ('fsl,imx-irqsteer' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../bindings/interrupt-controller/fsl,irqsteer.yaml       | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
index 360a575ef8b0..3b11a1a15398 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
@@ -11,9 +11,11 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx8m-irqsteer
-      - fsl,imx-irqsteer
+    oneOf:
+      - const: fsl,imx-irqsteer
+      - items:
+          - const: fsl,imx8m-irqsteer
+          - const: fsl,imx-irqsteer
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 17/22] arm64: dts: imx8mq-evk: Add hog suffix to wl-reg-on
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (14 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 16/22] dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible matching Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 18/22] arm64: dts: imx8mq-zii-ultra: Add hog suffixes to GPIO hogs Krzysztof Kozlowski
                   ` (5 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

According to device tree specification, device node names should be
somewhat generic and reflecting the function of the device so add the
"hog" suffix to wl-reg-on GPIO hog.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
index 8aa9cd8e495a..a088831d2e24 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
@@ -157,7 +157,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wifi_reset>;
 
-	wl-reg-on {
+	wl-reg-on-hog {
 		gpio-hog;
 		gpios = <29 GPIO_ACTIVE_HIGH>;
 		output-high;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 18/22] arm64: dts: imx8mq-zii-ultra: Add hog suffixes to GPIO hogs
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (15 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 17/22] arm64: dts: imx8mq-evk: Add hog suffix to wl-reg-on Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 19/22] arm64: dts: imx8mm: Remove i.MX7 compatible from USDHC Krzysztof Kozlowski
                   ` (4 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

According to device tree specification, device node names should be
somewhat generic and reflecting the function of the device so add the
"hog" suffixes to all GPIO hog nodes.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 0d1088dcaa02..fa7a041ffcfd 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -229,28 +229,28 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_gpio3_hog>;
 
-	usb-emulation {
+	usb-emulation-hog {
 		gpio-hog;
 		gpios = <10 GPIO_ACTIVE_HIGH>;
 		output-low;
 		line-name = "usb-emulation";
 	};
 
-	usb-mode1 {
+	usb-mode1-hog {
 		gpio-hog;
 		gpios = <11 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "usb-mode1";
 	};
 
-	usb-pwr {
+	usb-pwr-hog {
 		gpio-hog;
 		gpios = <12 GPIO_ACTIVE_LOW>;
 		output-high;
 		line-name = "usb-pwr-ctrl-en-n";
 	};
 
-	usb-mode2 {
+	usb-mode2-hog {
 		gpio-hog;
 		gpios = <13 GPIO_ACTIVE_HIGH>;
 		output-high;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 19/22] arm64: dts: imx8mm: Remove i.MX7 compatible from USDHC
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (16 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 18/22] arm64: dts: imx8mq-zii-ultra: Add hog suffixes to GPIO hogs Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 20/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from UART Krzysztof Kozlowski
                   ` (3 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

The USDHC on i.MX 8M Mini has its own compatible described in bindings
and used in the driver (with its own quirks).  Remove additional
fsl,imx7d-usdhc compatible to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: mmc@30b40000: compatible: ['fsl,imx8mm-usdhc', 'fsl,imx7d-usdhc'] is too long
    From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml

  arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: mmc@30b40000: compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 76f040e4be5e..38bf41184489 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -784,7 +784,7 @@
 			};
 
 			usdhc1: mmc@30b40000 {
-				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
+				compatible = "fsl,imx8mm-usdhc";
 				reg = <0x30b40000 0x10000>;
 				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
@@ -798,7 +798,7 @@
 			};
 
 			usdhc2: mmc@30b50000 {
-				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
+				compatible = "fsl,imx8mm-usdhc";
 				reg = <0x30b50000 0x10000>;
 				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
@@ -812,7 +812,7 @@
 			};
 
 			usdhc3: mmc@30b60000 {
-				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
+				compatible = "fsl,imx8mm-usdhc";
 				reg = <0x30b60000 0x10000>;
 				interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 20/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from UART
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (17 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 19/22] arm64: dts: imx8mm: Remove i.MX7 compatible from USDHC Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-23 16:15 ` [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

The UART on i.MX 8QXP has its own compatible described in bindings
and used in the driver (with its own quirks).  Remove additional
fsl,imx7ulp-lpuart compatible to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@5a060000:
    compatible: ['fsl,imx8qxp-lpuart', 'fsl,imx7ulp-lpuart'] is too long
    From schema: Documentation/devicetree/bindings/serial/fsl-lpuart.yaml

  arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@5a060000:
    compatible: Additional items are not allowed ('fsl,imx7ulp-lpuart' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index e46faac1fe71..61bccb69f09e 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -257,7 +257,7 @@
 		};
 
 		adma_lpuart0: serial@5a060000 {
-			compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+			compatible = "fsl,imx8qxp-lpuart";
 			reg = <0x5a060000 0x1000>;
 			interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_IPG_CLK>,
@@ -268,7 +268,7 @@
 		};
 
 		adma_lpuart1: serial@5a070000 {
-			compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+			compatible = "fsl,imx8qxp-lpuart";
 			reg = <0x5a070000 0x1000>;
 			interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_IPG_CLK>,
@@ -279,7 +279,7 @@
 		};
 
 		adma_lpuart2: serial@5a080000 {
-			compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+			compatible = "fsl,imx8qxp-lpuart";
 			reg = <0x5a080000 0x1000>;
 			interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_IPG_CLK>,
@@ -290,7 +290,7 @@
 		};
 
 		adma_lpuart3: serial@5a090000 {
-			compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+			compatible = "fsl,imx8qxp-lpuart";
 			reg = <0x5a090000 0x1000>;
 			interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_IPG_CLK>,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (18 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 20/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from UART Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-24  9:00   ` Aisheng Dong
  2020-08-23 16:15 ` [PATCH 22/22] arm64: dts: imx8mp: Remove i.MX7 compatible from DDR PMU Krzysztof Kozlowski
  2020-08-28  9:42 ` [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Linus Walleij
  21 siblings, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

The USDHC on i.MX 8QXP has its own compatible described in bindings
and used in the driver (with its own quirks).  Remove additional
fsl,imx7d-usdhc compatible to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000:
    compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
    From schema: /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml

  arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000:
    compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 61bccb69f09e..26c4fcdfe290 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -362,7 +362,7 @@
 		};
 
 		usdhc1: mmc@5b010000 {
-			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+			compatible = "fsl,imx8qxp-usdhc";
 			interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
 			reg = <0x5b010000 0x10000>;
 			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC0_IPG_CLK>,
@@ -374,7 +374,7 @@
 		};
 
 		usdhc2: mmc@5b020000 {
-			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+			compatible = "fsl,imx8qxp-usdhc";
 			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
 			reg = <0x5b020000 0x10000>;
 			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC1_IPG_CLK>,
@@ -388,7 +388,7 @@
 		};
 
 		usdhc3: mmc@5b030000 {
-			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+			compatible = "fsl,imx8qxp-usdhc";
 			interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
 			reg = <0x5b030000 0x10000>;
 			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC2_IPG_CLK>,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* [PATCH 22/22] arm64: dts: imx8mp: Remove i.MX7 compatible from DDR PMU
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (19 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC Krzysztof Kozlowski
@ 2020-08-23 16:15 ` Krzysztof Kozlowski
  2020-08-28  9:42 ` [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Linus Walleij
  21 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-23 16:15 UTC (permalink / raw)
  To: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang, Krzysztof Kozlowski

The DDR PMU on i.MX 8MP has its own compatible described in bindings and
used in the driver (with its own quirks).  Remove additional
fsl,imx8m-ddr-pmu compatible to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dt.yaml: ddr-pmu@3d800000:
    compatible: ['fsl,imx8mq-ddr-pmu', 'fsl,imx8m-ddr-pmu'] is not valid under any of the given schemas (Possible causes of the failure):
    arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dt.yaml: ddr-pmu@3d800000: compatible: ['fsl,imx8mq-ddr-pmu', 'fsl,imx8m-ddr-pmu'] is too long
    From schema: Docmentation/devicetree/bindings/perf/fsl-imx-ddr.yaml

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 9de2aa1c573c..e34eff19fcae 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -746,7 +746,7 @@
 		};
 
 		ddr-pmu@3d800000 {
-			compatible = "fsl,imx8mp-ddr-pmu", "fsl,imx8m-ddr-pmu";
+			compatible = "fsl,imx8mp-ddr-pmu";
 			reg = <0x3d800000 0x400000>;
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
 		};
-- 
2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property
  2020-08-23 16:15 ` [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property Krzysztof Kozlowski
@ 2020-08-24  5:24   ` Sascha Hauer
  2020-08-24  6:38     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 35+ messages in thread
From: Sascha Hauer @ 2020-08-24  5:24 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-kernel, linux-gpio, linux-arm-kernel,
	linux-mmc, linux-mtd, linux-pwm, linux-serial, linux-pm,
	linux-watchdog, Thierry Reding, Anson Huang

On Sun, Aug 23, 2020 at 06:15:30PM +0200, Krzysztof Kozlowski wrote:
> The GPIO controller node can have gpio-ranges property.  This fixes
> dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
>     From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/gpio/fsl-imx-gpio.yaml    | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> index 454db20c2d1a..1fac69573bb9 100644
> --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> @@ -51,6 +51,9 @@ properties:
>  
>    gpio-controller: true
>  
> +  gpio-ranges:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> @@ -62,6 +65,18 @@ required:
>  
>  additionalProperties: false
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8mp-gpio
> +    then:
> +      properties:
> +        gpio-ranges:
> +          minItems: 1
> +          maxItems: 2

Why do you limit this to fsl,imx8mp-gpio? The i.MX5,6,7 dtsi files use
gpio-ranges as well and other i.MX dtsi files could also use it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 07/22] dt-bindings: serial: fsl-imx-uart: imx-pwm: Add i.MX 8M compatibles
  2020-08-23 16:15 ` [PATCH 07/22] dt-bindings: serial: fsl-imx-uart: " Krzysztof Kozlowski
@ 2020-08-24  5:46   ` Sascha Hauer
  2020-08-24  6:39     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 35+ messages in thread
From: Sascha Hauer @ 2020-08-24  5:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-kernel, linux-gpio, linux-arm-kernel,
	linux-mmc, linux-mtd, linux-pwm, linux-serial, linux-pm,
	linux-watchdog, Thierry Reding, Anson Huang


The subject contains a "imx-pwm", presumably from the last patch.

Sascha

On Sun, Aug 23, 2020 at 06:15:35PM +0200, Krzysztof Kozlowski wrote:
> DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
> to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
>     compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm']
>     From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> 
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
>     compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long
> 
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
>     compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> index cba3f83ccd5f..3d896173b3b0 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> @@ -36,6 +36,10 @@ properties:
>              - fsl,imx6sx-uart
>              - fsl,imx6ul-uart
>              - fsl,imx7d-uart
> +            - fsl,imx8mm-uart
> +            - fsl,imx8mn-uart
> +            - fsl,imx8mp-uart
> +            - fsl,imx8mq-uart
>            - const: fsl,imx6q-uart
>  
>    reg:
> -- 
> 2.17.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property
  2020-08-24  5:24   ` Sascha Hauer
@ 2020-08-24  6:38     ` Krzysztof Kozlowski
  2020-08-24  6:58       ` Sascha Hauer
  0 siblings, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-24  6:38 UTC (permalink / raw)
  To: Sascha Hauer
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-kernel, linux-gpio, linux-arm-kernel,
	linux-mmc, linux-mtd, linux-pwm, linux-serial, linux-pm,
	linux-watchdog, Thierry Reding, Anson Huang

On Mon, Aug 24, 2020 at 07:24:46AM +0200, Sascha Hauer wrote:
> On Sun, Aug 23, 2020 at 06:15:30PM +0200, Krzysztof Kozlowski wrote:
> > The GPIO controller node can have gpio-ranges property.  This fixes
> > dtbs_check warnings like:
> > 
> >   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
> >     From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  .../devicetree/bindings/gpio/fsl-imx-gpio.yaml    | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > index 454db20c2d1a..1fac69573bb9 100644
> > --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > @@ -51,6 +51,9 @@ properties:
> >  
> >    gpio-controller: true
> >  
> > +  gpio-ranges:
> > +    maxItems: 1
> > +
> >  required:
> >    - compatible
> >    - reg
> > @@ -62,6 +65,18 @@ required:
> >  
> >  additionalProperties: false
> >  
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: fsl,imx8mp-gpio
> > +    then:
> > +      properties:
> > +        gpio-ranges:
> > +          minItems: 1
> > +          maxItems: 2
> 
> Why do you limit this to fsl,imx8mp-gpio? The i.MX5,6,7 dtsi files use
> gpio-ranges as well and other i.MX dtsi files could also use it.

All other cases use maximum one element in gpio-ranges, so they are
covered so I assumed they are continuous. But if it not the case, I can
make all them maximum 2.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 07/22] dt-bindings: serial: fsl-imx-uart: imx-pwm: Add i.MX 8M compatibles
  2020-08-24  5:46   ` Sascha Hauer
@ 2020-08-24  6:39     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-24  6:39 UTC (permalink / raw)
  To: Sascha Hauer
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-kernel, linux-gpio, linux-arm-kernel,
	linux-mmc, linux-mtd, linux-pwm, linux-serial, linux-pm,
	linux-watchdog, Thierry Reding, Anson Huang

On Mon, Aug 24, 2020 at 07:46:01AM +0200, Sascha Hauer wrote:
> 
> The subject contains a "imx-pwm", presumably from the last patch.

Ah, copy-paste. Thanks for pointing this out.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property
  2020-08-24  6:38     ` Krzysztof Kozlowski
@ 2020-08-24  6:58       ` Sascha Hauer
  2020-08-24  7:07         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 35+ messages in thread
From: Sascha Hauer @ 2020-08-24  6:58 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-kernel, linux-gpio, linux-arm-kernel,
	linux-mmc, linux-mtd, linux-pwm, linux-serial, linux-pm,
	linux-watchdog, Thierry Reding, Anson Huang

On Mon, Aug 24, 2020 at 08:38:06AM +0200, Krzysztof Kozlowski wrote:
> On Mon, Aug 24, 2020 at 07:24:46AM +0200, Sascha Hauer wrote:
> > On Sun, Aug 23, 2020 at 06:15:30PM +0200, Krzysztof Kozlowski wrote:
> > > The GPIO controller node can have gpio-ranges property.  This fixes
> > > dtbs_check warnings like:
> > > 
> > >   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >     From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > ---
> > >  .../devicetree/bindings/gpio/fsl-imx-gpio.yaml    | 15 +++++++++++++++
> > >  1 file changed, 15 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > > index 454db20c2d1a..1fac69573bb9 100644
> > > --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > > +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > > @@ -51,6 +51,9 @@ properties:
> > >  
> > >    gpio-controller: true
> > >  
> > > +  gpio-ranges:
> > > +    maxItems: 1
> > > +
> > >  required:
> > >    - compatible
> > >    - reg
> > > @@ -62,6 +65,18 @@ required:
> > >  
> > >  additionalProperties: false
> > >  
> > > +allOf:
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          contains:
> > > +            const: fsl,imx8mp-gpio
> > > +    then:
> > > +      properties:
> > > +        gpio-ranges:
> > > +          minItems: 1
> > > +          maxItems: 2
> > 
> > Why do you limit this to fsl,imx8mp-gpio? The i.MX5,6,7 dtsi files use
> > gpio-ranges as well and other i.MX dtsi files could also use it.
> 
> All other cases use maximum one element in gpio-ranges, so they are
> covered so I assumed they are continuous. But if it not the case, I can
> make all them maximum 2.

I misread this, I thought you allow gpio-ranges only for imx8mp, but
it's only the maxItems you set differently for that SoC. Anyway,
arch/arm/boot/dts/imx6dl.dtsi has this:

&gpio1 {
        gpio-ranges = <&iomuxc  0 131 2>, <&iomuxc  2 137 8>, <&iomuxc 10 189 2>,
                      <&iomuxc 12 194 1>, <&iomuxc 13 193 1>, <&iomuxc 14 192 1>,
                      <&iomuxc 15 191 1>, <&iomuxc 16 185 2>, <&iomuxc 18 184 1>,
                      <&iomuxc 19 187 1>, <&iomuxc 20 183 1>, <&iomuxc 21 188 1>,
                      <&iomuxc 22 123 3>, <&iomuxc 25 121 1>, <&iomuxc 26 127 1>,
                      <&iomuxc 27 126 1>, <&iomuxc 28 128 1>, <&iomuxc 29 130 1>,
                      <&iomuxc 30 129 1>, <&iomuxc 31 122 1>;
};

I don't think it makes sense to specify maxItems.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property
  2020-08-24  6:58       ` Sascha Hauer
@ 2020-08-24  7:07         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-24  7:07 UTC (permalink / raw)
  To: Sascha Hauer
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-kernel, linux-gpio, linux-arm-kernel,
	linux-mmc, linux-mtd, linux-pwm, linux-serial, linux-pm,
	linux-watchdog, Thierry Reding, Anson Huang

On Mon, Aug 24, 2020 at 08:58:01AM +0200, Sascha Hauer wrote:
> On Mon, Aug 24, 2020 at 08:38:06AM +0200, Krzysztof Kozlowski wrote:
> > On Mon, Aug 24, 2020 at 07:24:46AM +0200, Sascha Hauer wrote:
> > > On Sun, Aug 23, 2020 at 06:15:30PM +0200, Krzysztof Kozlowski wrote:
> > > > The GPIO controller node can have gpio-ranges property.  This fixes
> > > > dtbs_check warnings like:
> > > > 
> > > >   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
> > > >     From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > > > 
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > >  .../devicetree/bindings/gpio/fsl-imx-gpio.yaml    | 15 +++++++++++++++
> > > >  1 file changed, 15 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > > > index 454db20c2d1a..1fac69573bb9 100644
> > > > --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > > > +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> > > > @@ -51,6 +51,9 @@ properties:
> > > >  
> > > >    gpio-controller: true
> > > >  
> > > > +  gpio-ranges:
> > > > +    maxItems: 1
> > > > +
> > > >  required:
> > > >    - compatible
> > > >    - reg
> > > > @@ -62,6 +65,18 @@ required:
> > > >  
> > > >  additionalProperties: false
> > > >  
> > > > +allOf:
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            const: fsl,imx8mp-gpio
> > > > +    then:
> > > > +      properties:
> > > > +        gpio-ranges:
> > > > +          minItems: 1
> > > > +          maxItems: 2
> > > 
> > > Why do you limit this to fsl,imx8mp-gpio? The i.MX5,6,7 dtsi files use
> > > gpio-ranges as well and other i.MX dtsi files could also use it.
> > 
> > All other cases use maximum one element in gpio-ranges, so they are
> > covered so I assumed they are continuous. But if it not the case, I can
> > make all them maximum 2.
> 
> I misread this, I thought you allow gpio-ranges only for imx8mp, but
> it's only the maxItems you set differently for that SoC. Anyway,
> arch/arm/boot/dts/imx6dl.dtsi has this:
> 
> &gpio1 {
>         gpio-ranges = <&iomuxc  0 131 2>, <&iomuxc  2 137 8>, <&iomuxc 10 189 2>,
>                       <&iomuxc 12 194 1>, <&iomuxc 13 193 1>, <&iomuxc 14 192 1>,
>                       <&iomuxc 15 191 1>, <&iomuxc 16 185 2>, <&iomuxc 18 184 1>,
>                       <&iomuxc 19 187 1>, <&iomuxc 20 183 1>, <&iomuxc 21 188 1>,
>                       <&iomuxc 22 123 3>, <&iomuxc 25 121 1>, <&iomuxc 26 127 1>,
>                       <&iomuxc 27 126 1>, <&iomuxc 28 128 1>, <&iomuxc 29 130 1>,
>                       <&iomuxc 30 129 1>, <&iomuxc 31 122 1>;
> };
> 
> I don't think it makes sense to specify maxItems.

Indeed, I will skip the max limit.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 35+ messages in thread

* RE: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC
  2020-08-23 16:15 ` [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC Krzysztof Kozlowski
@ 2020-08-24  9:00   ` Aisheng Dong
  2020-08-24  9:11     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 35+ messages in thread
From: Aisheng Dong @ 2020-08-24  9:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Linus Walleij,
	Bartosz Golaszewski, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx, devicetree,
	linux-kernel, linux-gpio, linux-arm-kernel, linux-mmc, linux-mtd,
	linux-pwm, linux-serial, linux-pm, linux-watchdog
  Cc: Thierry Reding, Anson Huang

> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, August 24, 2020 12:16 AM
> 
> The USDHC on i.MX 8QXP has its own compatible described in bindings and
> used in the driver (with its own quirks).  Remove additional fsl,imx7d-usdhc
> compatible to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000:
>     compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
>     From schema:
> /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> 
>   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000:
>     compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was
> unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

For Patch 19-22, I think we should fix dt binding doc.

Regards
Aisheng

> ---
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 61bccb69f09e..26c4fcdfe290 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -362,7 +362,7 @@
>  		};
> 
>  		usdhc1: mmc@5b010000 {
> -			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> +			compatible = "fsl,imx8qxp-usdhc";
>  			interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
>  			reg = <0x5b010000 0x10000>;
>  			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC0_IPG_CLK>, @@
> -374,7 +374,7 @@
>  		};
> 
>  		usdhc2: mmc@5b020000 {
> -			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> +			compatible = "fsl,imx8qxp-usdhc";
>  			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
>  			reg = <0x5b020000 0x10000>;
>  			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC1_IPG_CLK>, @@
> -388,7 +388,7 @@
>  		};
> 
>  		usdhc3: mmc@5b030000 {
> -			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> +			compatible = "fsl,imx8qxp-usdhc";
>  			interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
>  			reg = <0x5b030000 0x10000>;
>  			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC2_IPG_CLK>,
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC
  2020-08-24  9:00   ` Aisheng Dong
@ 2020-08-24  9:11     ` Krzysztof Kozlowski
  2020-08-24  9:45       ` Dong Aisheng
  0 siblings, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-24  9:11 UTC (permalink / raw)
  To: Aisheng Dong
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	dl-linux-imx, devicetree, linux-kernel, linux-gpio,
	linux-arm-kernel, linux-mmc, linux-mtd, linux-pwm, linux-serial,
	linux-pm, linux-watchdog, Thierry Reding, Anson Huang

On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Monday, August 24, 2020 12:16 AM
> > 
> > The USDHC on i.MX 8QXP has its own compatible described in bindings and
> > used in the driver (with its own quirks).  Remove additional fsl,imx7d-usdhc
> > compatible to fix dtbs_check warnings like:
> > 
> >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000:
> >     compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
> >     From schema:
> > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > 
> >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000:
> >     compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was
> > unexpected)
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> For Patch 19-22, I think we should fix dt binding doc.

Are you sure that these USDHC controllers are compatible with i.MX 7D?
Could they really run with fsl,imx7d-usdhc compatible?

The implementation (Linux kernel driver) is different, I guess on
purpose...

Best regards,
Krzysztof

> 
> Regards
> Aisheng
> 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 61bccb69f09e..26c4fcdfe290 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -362,7 +362,7 @@
> >  		};
> > 
> >  		usdhc1: mmc@5b010000 {
> > -			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > +			compatible = "fsl,imx8qxp-usdhc";
> >  			interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
> >  			reg = <0x5b010000 0x10000>;
> >  			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC0_IPG_CLK>, @@
> > -374,7 +374,7 @@
> >  		};
> > 
> >  		usdhc2: mmc@5b020000 {
> > -			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > +			compatible = "fsl,imx8qxp-usdhc";
> >  			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
> >  			reg = <0x5b020000 0x10000>;
> >  			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC1_IPG_CLK>, @@
> > -388,7 +388,7 @@
> >  		};
> > 
> >  		usdhc3: mmc@5b030000 {
> > -			compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > +			compatible = "fsl,imx8qxp-usdhc";
> >  			interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
> >  			reg = <0x5b030000 0x10000>;
> >  			clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC2_IPG_CLK>,
> > --
> > 2.17.1
> 

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC
  2020-08-24  9:11     ` Krzysztof Kozlowski
@ 2020-08-24  9:45       ` Dong Aisheng
  2020-08-24 10:31         ` Bough Chen
  0 siblings, 1 reply; 35+ messages in thread
From: Dong Aisheng @ 2020-08-24  9:45 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Aisheng Dong, devicetree, linux-serial, Anson Huang, linux-gpio,
	Fabio Estevam, Linus Walleij, linux-pm, linux-mmc, linux-kernel,
	linux-pwm, Bartosz Golaszewski, Rob Herring, linux-mtd,
	dl-linux-imx, Pengutronix Kernel Team, Thierry Reding, Shawn Guo,
	Sascha Hauer, linux-arm-kernel, linux-watchdog, Haibo Chen

On Mon, Aug 24, 2020 at 5:15 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote:
> > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > Sent: Monday, August 24, 2020 12:16 AM
> > >
> > > The USDHC on i.MX 8QXP has its own compatible described in bindings and
> > > used in the driver (with its own quirks).  Remove additional fsl,imx7d-usdhc
> > > compatible to fix dtbs_check warnings like:
> > >
> > >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000:
> > >     compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
> > >     From schema:
> > > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > >
> > >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000:
> > >     compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was
> > > unexpected)
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > For Patch 19-22, I think we should fix dt binding doc.
>
> Are you sure that these USDHC controllers are compatible with i.MX 7D?
> Could they really run with fsl,imx7d-usdhc compatible?

AFAIK uSDHC on QXP is derived from the former platforms with adding a few
more new features. e.g. HS400ES/CMDQ.
Let me loop in uSDHC driver owner Haibo Chen to double confirm.

Regards
Aisheng

> The implementation (Linux kernel driver) is different, I guess on
> purpose...
>
> Best regards,
> Krzysztof
>
> >
> > Regards
> > Aisheng
> >
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > index 61bccb69f09e..26c4fcdfe290 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > @@ -362,7 +362,7 @@
> > >             };
> > >
> > >             usdhc1: mmc@5b010000 {
> > > -                   compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > > +                   compatible = "fsl,imx8qxp-usdhc";
> > >                     interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
> > >                     reg = <0x5b010000 0x10000>;
> > >                     clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC0_IPG_CLK>, @@
> > > -374,7 +374,7 @@
> > >             };
> > >
> > >             usdhc2: mmc@5b020000 {
> > > -                   compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > > +                   compatible = "fsl,imx8qxp-usdhc";
> > >                     interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
> > >                     reg = <0x5b020000 0x10000>;
> > >                     clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC1_IPG_CLK>, @@
> > > -388,7 +388,7 @@
> > >             };
> > >
> > >             usdhc3: mmc@5b030000 {
> > > -                   compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
> > > +                   compatible = "fsl,imx8qxp-usdhc";
> > >                     interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
> > >                     reg = <0x5b030000 0x10000>;
> > >                     clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC2_IPG_CLK>,
> > > --
> > > 2.17.1
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC
  2020-08-24 10:32           ` Krzysztof Kozlowski
@ 2020-08-24 10:30             ` Dong Aisheng
  0 siblings, 0 replies; 35+ messages in thread
From: Dong Aisheng @ 2020-08-24 10:30 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bough Chen, Aisheng Dong, devicetree, linux-serial, Anson Huang,
	linux-gpio, Fabio Estevam, Linus Walleij, linux-pm, linux-mmc,
	linux-kernel, linux-pwm, Bartosz Golaszewski, Rob Herring,
	linux-mtd, dl-linux-imx, Pengutronix Kernel Team, Thierry Reding,
	Shawn Guo, Sascha Hauer, linux-arm-kernel, linux-watchdog

On Mon, Aug 24, 2020 at 6:32 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Aug 24, 2020 at 10:31:31AM +0000, Bough Chen wrote:
> > > -----Original Message-----
> > > From: Dong Aisheng [mailto:dongas86@gmail.com]
> > > Sent: 2020年8月24日 17:45
> > > To: Krzysztof Kozlowski <krzk@kernel.org>
> > > Cc: Aisheng Dong <aisheng.dong@nxp.com>; devicetree@vger.kernel.org;
> > > linux-serial@vger.kernel.org; Anson Huang <anson.huang@nxp.com>;
> > > linux-gpio@vger.kernel.org; Fabio Estevam <festevam@gmail.com>; Linus
> > > Walleij <linus.walleij@linaro.org>; linux-pm@vger.kernel.org;
> > > linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > linux-pwm@vger.kernel.org; Bartosz Golaszewski
> > > <bgolaszewski@baylibre.com>; Rob Herring <robh+dt@kernel.org>;
> > > linux-mtd@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>; Pengutronix
> > > Kernel Team <kernel@pengutronix.de>; Thierry Reding
> > > <thierry.reding@gmail.com>; Shawn Guo <shawnguo@kernel.org>; Sascha
> > > Hauer <s.hauer@pengutronix.de>; linux-arm-kernel@lists.infradead.org;
> > > linux-watchdog@vger.kernel.org; Bough Chen <haibo.chen@nxp.com>
> > > Subject: Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible
> > > from USDHC
> > >
> > > On Mon, Aug 24, 2020 at 5:15 PM Krzysztof Kozlowski <krzk@kernel.org>
> > > wrote:
> > > >
> > > > On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote:
> > > > > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > > > > Sent: Monday, August 24, 2020 12:16 AM
> > > > > >
> > > > > > The USDHC on i.MX 8QXP has its own compatible described in
> > > > > > bindings and used in the driver (with its own quirks).  Remove
> > > > > > additional fsl,imx7d-usdhc compatible to fix dtbs_check warnings like:
> > > > > >
> > > > > >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml:
> > > mmc@5b010000:
> > > > > >     compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
> > > > > >     From schema:
> > > > > > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > > > > >
> > > > > >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml:
> > > mmc@5b010000:
> > > > > >     compatible: Additional items are not allowed
> > > > > > ('fsl,imx7d-usdhc' was
> > > > > > unexpected)
> > > > > >
> > > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > >
> > > > > For Patch 19-22, I think we should fix dt binding doc.
> > > >
> > > > Are you sure that these USDHC controllers are compatible with i.MX 7D?
> > > > Could they really run with fsl,imx7d-usdhc compatible?
> > >
> > > AFAIK uSDHC on QXP is derived from the former platforms with adding a few
> > > more new features. e.g. HS400ES/CMDQ.
> > > Let me loop in uSDHC driver owner Haibo Chen to double confirm.
> >
> > Yes, usdhc of imx8qxp can work by using the compatible "fsl, imx7d-usdhc", but will not support HS400ES/Command Queue any more. Also imx8qxp support Auto CMD23, but imx7d not.
> > And imx8qxp need to re-config the clock rate after system PM, imx7d do not need to do this.
>
> Then we can leave the compatible in DTS and I will correct the device
> tree schema.

Haibo,

As Krzysztof is helping fix uSDHC binding doc in Patch 12/22,
please double check with IC for the whole uSDHC derive relationships on i.MX
and feedback to Krzysztof if anything is wrong.

Regards
Aisheng

>
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 35+ messages in thread

* RE: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC
  2020-08-24  9:45       ` Dong Aisheng
@ 2020-08-24 10:31         ` Bough Chen
  2020-08-24 10:32           ` Krzysztof Kozlowski
  0 siblings, 1 reply; 35+ messages in thread
From: Bough Chen @ 2020-08-24 10:31 UTC (permalink / raw)
  To: Dong Aisheng, Krzysztof Kozlowski
  Cc: Aisheng Dong, devicetree, linux-serial, Anson Huang, linux-gpio,
	Fabio Estevam, Linus Walleij, linux-pm, linux-mmc, linux-kernel,
	linux-pwm, Bartosz Golaszewski, Rob Herring, linux-mtd,
	dl-linux-imx, Pengutronix Kernel Team, Thierry Reding, Shawn Guo,
	Sascha Hauer, linux-arm-kernel, linux-watchdog

> -----Original Message-----
> From: Dong Aisheng [mailto:dongas86@gmail.com]
> Sent: 2020年8月24日 17:45
> To: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Aisheng Dong <aisheng.dong@nxp.com>; devicetree@vger.kernel.org;
> linux-serial@vger.kernel.org; Anson Huang <anson.huang@nxp.com>;
> linux-gpio@vger.kernel.org; Fabio Estevam <festevam@gmail.com>; Linus
> Walleij <linus.walleij@linaro.org>; linux-pm@vger.kernel.org;
> linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-pwm@vger.kernel.org; Bartosz Golaszewski
> <bgolaszewski@baylibre.com>; Rob Herring <robh+dt@kernel.org>;
> linux-mtd@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>; Pengutronix
> Kernel Team <kernel@pengutronix.de>; Thierry Reding
> <thierry.reding@gmail.com>; Shawn Guo <shawnguo@kernel.org>; Sascha
> Hauer <s.hauer@pengutronix.de>; linux-arm-kernel@lists.infradead.org;
> linux-watchdog@vger.kernel.org; Bough Chen <haibo.chen@nxp.com>
> Subject: Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible
> from USDHC
> 
> On Mon, Aug 24, 2020 at 5:15 PM Krzysztof Kozlowski <krzk@kernel.org>
> wrote:
> >
> > On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote:
> > > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > > Sent: Monday, August 24, 2020 12:16 AM
> > > >
> > > > The USDHC on i.MX 8QXP has its own compatible described in
> > > > bindings and used in the driver (with its own quirks).  Remove
> > > > additional fsl,imx7d-usdhc compatible to fix dtbs_check warnings like:
> > > >
> > > >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml:
> mmc@5b010000:
> > > >     compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
> > > >     From schema:
> > > > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > > >
> > > >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml:
> mmc@5b010000:
> > > >     compatible: Additional items are not allowed
> > > > ('fsl,imx7d-usdhc' was
> > > > unexpected)
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > >
> > > For Patch 19-22, I think we should fix dt binding doc.
> >
> > Are you sure that these USDHC controllers are compatible with i.MX 7D?
> > Could they really run with fsl,imx7d-usdhc compatible?
> 
> AFAIK uSDHC on QXP is derived from the former platforms with adding a few
> more new features. e.g. HS400ES/CMDQ.
> Let me loop in uSDHC driver owner Haibo Chen to double confirm.

Yes, usdhc of imx8qxp can work by using the compatible "fsl, imx7d-usdhc", but will not support HS400ES/Command Queue any more. Also imx8qxp support Auto CMD23, but imx7d not.
And imx8qxp need to re-config the clock rate after system PM, imx7d do not need to do this.


> 
> Regards
> Aisheng
> 
> > The implementation (Linux kernel driver) is different, I guess on
> > purpose...
> >
> > Best regards,
> > Krzysztof
> >
> > >
> > > Regards
> > > Aisheng
> > >
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > > index 61bccb69f09e..26c4fcdfe290 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > > @@ -362,7 +362,7 @@
> > > >             };
> > > >
> > > >             usdhc1: mmc@5b010000 {
> > > > -                   compatible = "fsl,imx8qxp-usdhc",
> "fsl,imx7d-usdhc";
> > > > +                   compatible = "fsl,imx8qxp-usdhc";
> > > >                     interrupts = <GIC_SPI 232
> IRQ_TYPE_LEVEL_HIGH>;
> > > >                     reg = <0x5b010000 0x10000>;
> > > >                     clocks = <&conn_lpcg
> > > > IMX_CONN_LPCG_SDHC0_IPG_CLK>, @@
> > > > -374,7 +374,7 @@
> > > >             };
> > > >
> > > >             usdhc2: mmc@5b020000 {
> > > > -                   compatible = "fsl,imx8qxp-usdhc",
> "fsl,imx7d-usdhc";
> > > > +                   compatible = "fsl,imx8qxp-usdhc";
> > > >                     interrupts = <GIC_SPI 233
> IRQ_TYPE_LEVEL_HIGH>;
> > > >                     reg = <0x5b020000 0x10000>;
> > > >                     clocks = <&conn_lpcg
> > > > IMX_CONN_LPCG_SDHC1_IPG_CLK>, @@
> > > > -388,7 +388,7 @@
> > > >             };
> > > >
> > > >             usdhc3: mmc@5b030000 {
> > > > -                   compatible = "fsl,imx8qxp-usdhc",
> "fsl,imx7d-usdhc";
> > > > +                   compatible = "fsl,imx8qxp-usdhc";
> > > >                     interrupts = <GIC_SPI 234
> IRQ_TYPE_LEVEL_HIGH>;
> > > >                     reg = <0x5b030000 0x10000>;
> > > >                     clocks = <&conn_lpcg
> > > > IMX_CONN_LPCG_SDHC2_IPG_CLK>,
> > > > --
> > > > 2.17.1
> > >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists
> > .infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&amp;data=02%7
> C0
> >
> 1%7Chaibo.chen%40nxp.com%7C25d35969a5904d2cd49e08d848148b49%7C6
> 86ea1d3
> >
> bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637338600398740888&amp;sdata
> =OVryLd
> > 4q7LvEoSl6dqQhbR4VWgi6TqBYE%2BS9bI1M6ZY%3D&amp;reserved=0

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC
  2020-08-24 10:31         ` Bough Chen
@ 2020-08-24 10:32           ` Krzysztof Kozlowski
  2020-08-24 10:30             ` Dong Aisheng
  0 siblings, 1 reply; 35+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-24 10:32 UTC (permalink / raw)
  To: Bough Chen
  Cc: Dong Aisheng, Aisheng Dong, devicetree, linux-serial,
	Anson Huang, linux-gpio, Fabio Estevam, Linus Walleij, linux-pm,
	linux-mmc, linux-kernel, linux-pwm, Bartosz Golaszewski,
	Rob Herring, linux-mtd, dl-linux-imx, Pengutronix Kernel Team,
	Thierry Reding, Shawn Guo, Sascha Hauer, linux-arm-kernel,
	linux-watchdog

On Mon, Aug 24, 2020 at 10:31:31AM +0000, Bough Chen wrote:
> > -----Original Message-----
> > From: Dong Aisheng [mailto:dongas86@gmail.com]
> > Sent: 2020年8月24日 17:45
> > To: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Aisheng Dong <aisheng.dong@nxp.com>; devicetree@vger.kernel.org;
> > linux-serial@vger.kernel.org; Anson Huang <anson.huang@nxp.com>;
> > linux-gpio@vger.kernel.org; Fabio Estevam <festevam@gmail.com>; Linus
> > Walleij <linus.walleij@linaro.org>; linux-pm@vger.kernel.org;
> > linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-pwm@vger.kernel.org; Bartosz Golaszewski
> > <bgolaszewski@baylibre.com>; Rob Herring <robh+dt@kernel.org>;
> > linux-mtd@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>; Pengutronix
> > Kernel Team <kernel@pengutronix.de>; Thierry Reding
> > <thierry.reding@gmail.com>; Shawn Guo <shawnguo@kernel.org>; Sascha
> > Hauer <s.hauer@pengutronix.de>; linux-arm-kernel@lists.infradead.org;
> > linux-watchdog@vger.kernel.org; Bough Chen <haibo.chen@nxp.com>
> > Subject: Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible
> > from USDHC
> > 
> > On Mon, Aug 24, 2020 at 5:15 PM Krzysztof Kozlowski <krzk@kernel.org>
> > wrote:
> > >
> > > On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote:
> > > > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > > > Sent: Monday, August 24, 2020 12:16 AM
> > > > >
> > > > > The USDHC on i.MX 8QXP has its own compatible described in
> > > > > bindings and used in the driver (with its own quirks).  Remove
> > > > > additional fsl,imx7d-usdhc compatible to fix dtbs_check warnings like:
> > > > >
> > > > >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml:
> > mmc@5b010000:
> > > > >     compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
> > > > >     From schema:
> > > > > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > > > >
> > > > >   arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml:
> > mmc@5b010000:
> > > > >     compatible: Additional items are not allowed
> > > > > ('fsl,imx7d-usdhc' was
> > > > > unexpected)
> > > > >
> > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > >
> > > > For Patch 19-22, I think we should fix dt binding doc.
> > >
> > > Are you sure that these USDHC controllers are compatible with i.MX 7D?
> > > Could they really run with fsl,imx7d-usdhc compatible?
> > 
> > AFAIK uSDHC on QXP is derived from the former platforms with adding a few
> > more new features. e.g. HS400ES/CMDQ.
> > Let me loop in uSDHC driver owner Haibo Chen to double confirm.
> 
> Yes, usdhc of imx8qxp can work by using the compatible "fsl, imx7d-usdhc", but will not support HS400ES/Command Queue any more. Also imx8qxp support Auto CMD23, but imx7d not.
> And imx8qxp need to re-config the clock rate after system PM, imx7d do not need to do this.

Then we can leave the compatible in DTS and I will correct the device
tree schema.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 35+ messages in thread

* Re: [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles
  2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
                   ` (20 preceding siblings ...)
  2020-08-23 16:15 ` [PATCH 22/22] arm64: dts: imx8mp: Remove i.MX7 compatible from DDR PMU Krzysztof Kozlowski
@ 2020-08-28  9:42 ` Linus Walleij
  21 siblings, 0 replies; 35+ messages in thread
From: Linus Walleij @ 2020-08-28  9:42 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Bartosz Golaszewski, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-kernel, open list:GPIO SUBSYSTEM, Linux ARM, linux-mmc,
	linux-mtd, linux-pwm, open list:SERIAL DRIVERS, Linux PM list,
	LINUXWATCHDOG, Thierry Reding, Anson Huang

On Sun, Aug 23, 2020 at 6:16 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:

> DTSes with new i.MX 8 SoCs introduce their own compatibles so add them
> to fix dtbs_check warnings like:
>
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
>     compatible:0: 'fsl,imx8mm-gpio' is not one of ['fsl,imx1-gpio', 'fsl,imx21-gpio', 'fsl,imx31-gpio', 'fsl,imx35-gpio', 'fsl,imx7d-gpio']
>     From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
>
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
>     compatible: ['fsl,imx8mm-gpio', 'fsl,imx35-gpio'] is too long
>
>   arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
>     compatible: Additional items are not allowed ('fsl,imx35-gpio' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

I'm just waiting for some review from the i.MX people on these FSL things,
then I can apply it.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 35+ messages in thread

end of thread, back to index

Thread overview: 35+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-23 16:15 [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 02/22] dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property Krzysztof Kozlowski
2020-08-24  5:24   ` Sascha Hauer
2020-08-24  6:38     ` Krzysztof Kozlowski
2020-08-24  6:58       ` Sascha Hauer
2020-08-24  7:07         ` Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 03/22] dt-bindings: gpio: fsl-imx-gpio: Add parsing of hogs Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 04/22] dt-bindings: gpio: fsl-imx-gpio: Add power-domains Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 05/22] dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 06/22] dt-bindings: pwm: imx-pwm: " Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 07/22] dt-bindings: serial: fsl-imx-uart: " Krzysztof Kozlowski
2020-08-24  5:46   ` Sascha Hauer
2020-08-24  6:39     ` Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 08/22] dt-bindings: watchdog: fsl-imx-wdt: " Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 09/22] dt-bindings: mtd: gpmi-nand: " Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 10/22] dt-bindings: reset: fsl,imx7-src: " Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 11/22] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 12/22] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8M compatible matching Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 13/22] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 14/22] dt-bindings: arm: fsl: Fix Toradex Colibri i.MX 8 binding Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 15/22] dt-bindings: arm: fsl: Add ZII Ultra boards binding Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 16/22] dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible matching Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 17/22] arm64: dts: imx8mq-evk: Add hog suffix to wl-reg-on Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 18/22] arm64: dts: imx8mq-zii-ultra: Add hog suffixes to GPIO hogs Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 19/22] arm64: dts: imx8mm: Remove i.MX7 compatible from USDHC Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 20/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from UART Krzysztof Kozlowski
2020-08-23 16:15 ` [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC Krzysztof Kozlowski
2020-08-24  9:00   ` Aisheng Dong
2020-08-24  9:11     ` Krzysztof Kozlowski
2020-08-24  9:45       ` Dong Aisheng
2020-08-24 10:31         ` Bough Chen
2020-08-24 10:32           ` Krzysztof Kozlowski
2020-08-24 10:30             ` Dong Aisheng
2020-08-23 16:15 ` [PATCH 22/22] arm64: dts: imx8mp: Remove i.MX7 compatible from DDR PMU Krzysztof Kozlowski
2020-08-28  9:42 ` [PATCH 01/22] dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles Linus Walleij

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git