From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9411C43333 for ; Thu, 7 Jan 2021 09:11:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A26F2333D for ; Thu, 7 Jan 2021 09:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727273AbhAGJLp (ORCPT ); Thu, 7 Jan 2021 04:11:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727156AbhAGJLp (ORCPT ); Thu, 7 Jan 2021 04:11:45 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9C8BC0612A1 for ; Thu, 7 Jan 2021 01:10:20 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id a12so12948623lfl.6 for ; Thu, 07 Jan 2021 01:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T+iZKNW1gmpT+HQqIiqmRRpQMcaG8pgogUVWa/pKYOM=; b=cyz7QwbTfHcC+qnorIFVkv7DnbL/oyA5L+VJJAN8XWkNMg42oKdig8X5tU4xa7X7pN 01zspKzmEcVvu5fY2nzlSr3geA/q2812tr8Wz0sUieGMHhvg1aGrsz+m0J4b8Wmr2jr4 Bxuqd5E5gXQb8ARkFssKYAOK0W62M412pmNUBd9NwRQD04zf23syAxjzcLmFBod8VeLt Wkczn2W4OJkxg0o6mQ3tRUOpKTABRCCUpHtxAiPQFjxJEJCf/WQ1QzYZHEZTgGgMtnu2 jNC0bNdR63+2S3cfHE4fDoxHLsYIWb3l6Ja+q5Vt8aM4kBs1TbyhYMIEDY91gB4GZfH3 2CvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T+iZKNW1gmpT+HQqIiqmRRpQMcaG8pgogUVWa/pKYOM=; b=g52WNQ/pf3dPMIOIW3SH/Di+pZc16XiWFAafyGaPK0eSMieu3uOop3MrVm11nIiSek Box6vrShlCvWxE9Gjqz1D0UAHsMqTTbKQfv/RKQ6WJ9j83W2/VxFIIZz14n48FQ6GkrW SxXFn0w/Yy5dFb5dUQ65RahFSbPNv1OY+YDsaOy44qMtLgUXmqDcwb11qXnGcaP49/Ux eOR3uCImL6Mm+2Txn0F7/U6yRYkvCT3ctqIh2QEJC8627A+90l+JmdZ9pypQHPxt+ysx A8AQoXzmTFmTtlxPHI+9ck+Z5eJhtZ6S3mCgCe80Yi2gdTYA/T6wv3zKZb9R/dODV0nM gQ1A== X-Gm-Message-State: AOAM532E2B9t7TP7PHmbSOiB6VVtJ98/Yt7K1ygnqN4en1fPav0P28d1 DgsyW3NKzOHX0R1KOdRbiEBT+SZJQi29eiAsJrXhxg== X-Google-Smtp-Source: ABdhPJz6FNuZKYGADUxlk9Tv8Rh/lJVu/2CmZBJO3UIrMaB/edLmB9ZlsVBcuBoQ7GbjgHsRrGXCE/gOnIldpK4OwK0= X-Received: by 2002:a19:495d:: with SMTP id l29mr3392190lfj.465.1610010618615; Thu, 07 Jan 2021 01:10:18 -0800 (PST) MIME-Version: 1.0 References: <20210104230253.2805217-1-robh@kernel.org> In-Reply-To: <20210104230253.2805217-1-robh@kernel.org> From: Linus Walleij Date: Thu, 7 Jan 2021 10:10:07 +0100 Message-ID: Subject: Re: [PATCH] dt-bindings: Add missing array size constraints To: Rob Herring Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Jens Axboe , Stephen Boyd , Thierry Reding , MyungJoo Ham , Chanwoo Choi , Bartosz Golaszewski , Jonathan Cameron , Dmitry Torokhov , Thomas Gleixner , Marc Zyngier , Mauro Carvalho Chehab , Chen-Yu Tsai , Ulf Hansson , "David S. Miller" , Jakub Kicinski , Sebastian Reichel , Ohad Ben-Cohen , Bjorn Andersson , Greg Kroah-Hartman , Linux ARM , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , linux-clk , "open list:DRM PANEL DRIVERS" , "open list:GPIO SUBSYSTEM" , linux-iio , Linux Input , Linux Media Mailing List , linux-mmc , netdev , Linux PM list , linux-remoteproc@vger.kernel.org, linux-riscv , "open list:SERIAL DRIVERS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , linux-spi , linux-usb Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, Jan 5, 2021 at 12:03 AM Rob Herring wrote: > DT properties which can have multiple entries need to specify what the > entries are and define how many entries there can be. In the case of > only a single entry, just 'maxItems: 1' is sufficient. > > Add the missing entry constraints. These were found with a modified > meta-schema. Unfortunately, there are a few cases where the size > constraints are not defined such as common bindings, so the meta-schema > can't be part of the normal checks. > > Cc: Jens Axboe > Cc: Stephen Boyd > Cc: Thierry Reding > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: Jonathan Cameron > Cc: Dmitry Torokhov > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Mauro Carvalho Chehab > Cc: Chen-Yu Tsai > Cc: Ulf Hansson > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Sebastian Reichel > Cc: Ohad Ben-Cohen > Cc: Bjorn Andersson > Cc: Greg Kroah-Hartman > Signed-off-by: Rob Herring This is good. The stricter the better. Reviewed-by: Linus Walleij Yours, Linus Walleij