From: Evan Green <evgreen@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
daniel.thompson@linaro.org,
Akash Asthana <akashast@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
kgdb-bugreport@lists.sourceforge.net,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
sumit.garg@linaro.org, Vivek Gautam <vivek.gautam@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jiri Slaby <jslaby@suse.com>, LKML <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: qcom_geni_serial: Always use 4 bytes per TX FIFO word
Date: Fri, 10 Jul 2020 10:38:50 -0700 [thread overview]
Message-ID: <CAE=gft504BAm2sr0S32kSO2xoQWhjrXLXa9+uqgkcPO6wjNhrg@mail.gmail.com> (raw)
In-Reply-To: <20200626125844.2.Iabd56347670b9e4e916422773aba5b27943d19ee@changeid>
On Fri, Jun 26, 2020 at 1:01 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> The geni serial driver had a rule that we'd only use 1 byte per FIFO
> word for the TX FIFO if we were being used for the serial console.
> This is ugly and a bit of a pain. It's not too hard to fix, so fix
> it.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/tty/serial/qcom_geni_serial.c | 57 +++++++++++++++++----------
> 1 file changed, 37 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 4610e391e886..583d903321b5 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -103,12 +103,18 @@
> #define DEFAULT_IO_MACRO_IO2_IO3_MASK GENMASK(15, 4)
> #define IO_MACRO_IO2_IO3_SWAP 0x4640
>
> +/* We always configure 4 bytes per FIFO word */
> +#define BYTES_PER_FIFO_WORD 4
> +
> struct qcom_geni_private_data {
> /* NOTE: earlycon port will have NULL here */
> struct uart_driver *drv;
>
> u32 poll_cached_bytes;
> unsigned int poll_cached_bytes_cnt;
> +
> + u32 write_cached_bytes;
> + unsigned int write_cached_bytes_cnt;
> };
>
> struct qcom_geni_serial_port {
> @@ -121,8 +127,6 @@ struct qcom_geni_serial_port {
> bool setup;
> int (*handle_rx)(struct uart_port *uport, u32 bytes, bool drop);
> unsigned int baud;
> - unsigned int tx_bytes_pw;
> - unsigned int rx_bytes_pw;
> void *rx_fifo;
> u32 loopback;
> bool brk;
> @@ -390,13 +394,25 @@ static void qcom_geni_serial_poll_put_char(struct uart_port *uport,
> #ifdef CONFIG_SERIAL_QCOM_GENI_CONSOLE
> static void qcom_geni_serial_wr_char(struct uart_port *uport, int ch)
> {
> - writel(ch, uport->membase + SE_GENI_TX_FIFOn);
> + struct qcom_geni_private_data *private_data = uport->private_data;
> +
> + private_data->write_cached_bytes =
> + (private_data->write_cached_bytes >> 8) | (ch << 24);
> + private_data->write_cached_bytes_cnt++;
> +
> + if (private_data->write_cached_bytes_cnt == BYTES_PER_FIFO_WORD) {
> + writel(private_data->write_cached_bytes,
> + uport->membase + SE_GENI_TX_FIFOn);
> + private_data->write_cached_bytes_cnt = 0;
> + }
> }
>
> static void
> __qcom_geni_serial_console_write(struct uart_port *uport, const char *s,
> unsigned int count)
> {
> + struct qcom_geni_private_data *private_data = uport->private_data;
> +
> int i;
> u32 bytes_to_send = count;
>
> @@ -431,6 +447,15 @@ __qcom_geni_serial_console_write(struct uart_port *uport, const char *s,
> SE_GENI_M_IRQ_CLEAR);
> i += chars_to_write;
> }
> +
> + if (private_data->write_cached_bytes_cnt) {
> + private_data->write_cached_bytes >>= BITS_PER_BYTE *
> + (BYTES_PER_FIFO_WORD - private_data->write_cached_bytes_cnt);
> + writel(private_data->write_cached_bytes,
> + uport->membase + SE_GENI_TX_FIFOn);
> + private_data->write_cached_bytes_cnt = 0;
> + }
How does this not end up sending stray zeros? In other words, how does
the hardware know which bytes of this word are valid?
next prev parent reply other threads:[~2020-07-10 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 20:00 [PATCH 0/2] serial: qcom_geni_serial: Use the FIFOs properly for console Douglas Anderson
2020-06-26 20:00 ` [PATCH 1/2] serial: qcom_geni_serial: Make kgdb work even if UART isn't console Douglas Anderson
2020-07-10 17:38 ` Evan Green
2020-07-10 18:19 ` Doug Anderson
2020-07-10 19:02 ` Evan Green
2020-07-10 19:24 ` Doug Anderson
2020-07-10 23:15 ` Evan Green
2020-06-26 20:00 ` [PATCH 2/2] serial: qcom_geni_serial: Always use 4 bytes per TX FIFO word Douglas Anderson
2020-07-10 17:38 ` Evan Green [this message]
2020-07-10 18:27 ` Doug Anderson
2020-07-10 19:05 ` Evan Green
2020-06-27 13:59 ` [PATCH 0/2] serial: qcom_geni_serial: Use the FIFOs properly for console Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft504BAm2sr0S32kSO2xoQWhjrXLXa9+uqgkcPO6wjNhrg@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sumit.garg@linaro.org \
--cc=swboyd@chromium.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).