Re: [PATCH V6] GCOV: Add config to check the preqequisites situation

From: Cixi Geng <gengcixi@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	jslaby@suse.com, Peter Oberparleiter <oberpar@linux.ibm.com>,
	linux-serial@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Cixi Geng1 <cixi.geng1@unisoc.com>,
	Orson Zhai <orsonzhai@gmail.com>,
	zhang.lyra@gmail.com
Subject: Re: [PATCH V6] GCOV: Add config to check the preqequisites situation
Date: Thu, 16 Jul 2020 20:38:25 +0800	[thread overview]
Message-ID: <CAF12kFseC4MMbEUk6CgW=Hpz_Hg-+fjwbLZKFdPu0K_EGtcPDw@mail.gmail.com> (raw)
In-Reply-To: <2fae67c7637f4e978cb54c3b96090788@BJMBX01.spreadtrum.com>

Hi All:
Does this patch need more modification?

> 发件人: gengcixi@gmail.com <gengcixi@gmail.com>
> 发送时间: 2020年6月18日 18:08
> 收件人: gregkh@linuxfoundation.org; jslaby@suse.com; oberpar@linux.ibm.com; linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org
> 抄送: orsonzhai@gmail.com; zhang.lyra@gmail.com; 耿慈熙 (Cixi Geng/10039)
> 主题: [PATCH V6] GCOV: Add config to check the preqequisites situation
>
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> Introduce new configuration option GCOV_PROFILE_PREREQS that can be
> used to check whether the prerequisites for enabling gcov profiling
> for specific files and directories are met.
>
> Only add SERIAL_GCOV for an example.
>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
>  drivers/tty/serial/Kconfig  |  7 +++++++
>  drivers/tty/serial/Makefile |  1 +
>  kernel/gcov/Kconfig         | 10 ++++++++++
>  3 files changed, 18 insertions(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index adf9e80e7dc9..6df002370f18 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1566,3 +1566,10 @@ endmenu
>
>  config SERIAL_MCTRL_GPIO
>         tristate
> +
> +config SERIAL_GCOV
> +       bool "Enable profile gcov for serial directory"
> +       depends on GCOV_PROFILE_PREREQS
> +       help
> +         The SERIAL_GCOV will add Gcov profiling flags when kernel compiles.
> +         Say 'Y' here if you want the gcov data for the serial directory,
> diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> index d056ee6cca33..17272733db95 100644
> --- a/drivers/tty/serial/Makefile
> +++ b/drivers/tty/serial/Makefile
> @@ -3,6 +3,7 @@
>  # Makefile for the kernel serial device drivers.
>  #
>
> +GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
>  obj-$(CONFIG_SERIAL_CORE) += serial_core.o
>
>  obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o
> diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> index 3941a9c48f83..f415c4aaf0ab 100644
> --- a/kernel/gcov/Kconfig
> +++ b/kernel/gcov/Kconfig
> @@ -51,6 +51,16 @@ config GCOV_PROFILE_ALL
>         larger and run slower. Also be sure to exclude files from profiling
>         which are not linked to the kernel image to prevent linker errors.
>
> +config GCOV_PROFILE_PREREQS
> +       bool "Profile Kernel for prereqs"
> +       default y if GCOV_KERNEL && !COMPILE_TEST
> +       help
> +         This options activates profiling for the specified kernel modules.
> +
> +         When some modules need Gcov data, enable this config, then configure
> +         with gcov on the corresponding modules,The directories or files of
> +         these modules will be added profiling flags after kernel compile.
> +
>  choice
>         prompt "Specify GCOV format"
>         depends on GCOV_KERNEL
> --
> 2.17.1