From: Cixi Geng <gengcixi@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>,
jslaby@suse.com, Peter Oberparleiter <oberpar@linux.ibm.com>,
linux-serial@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
zhang.lyra@gmail.com, Cixi Geng <cixi.geng1@unisoc.com>
Subject: Re: [PATCH V7] GCOV: Add config to check the preqequisites situation
Date: Thu, 20 Aug 2020 20:40:53 +0800 [thread overview]
Message-ID: <CAF12kFuss4AQZSBX+A2G_fWjka3C4kpf4iDWU9QJY=AWigoxqg@mail.gmail.com> (raw)
In-Reply-To: <20200727085132.29754-1-gengcixi@gmail.com>
Hi All:
Does this patch need more modification?
<gengcixi@gmail.com> 于2020年7月27日周一 下午4:51写道:
>
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> Introduce new configuration option GCOV_PROFILE_PREREQS that can be
> used to check whether the prerequisites for enabling gcov profiling
> for specific files and directories are met.
>
> Only add SERIAL_GCOV for an example.
>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
> drivers/tty/serial/Kconfig | 7 +++++++
> drivers/tty/serial/Makefile | 1 +
> kernel/gcov/Kconfig | 12 ++++++++++++
> 3 files changed, 20 insertions(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 780908d43557..55b128b6b31d 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1576,3 +1576,10 @@ endmenu
>
> config SERIAL_MCTRL_GPIO
> tristate
> +
> +config SERIAL_GCOV
> + bool "Enable profile gcov for serial directory"
> + depends on GCOV_PROFILE_PREREQS
> + help
> + The SERIAL_GCOV will add Gcov profiling flags when kernel compiles.
> + Say 'Y' here if you want the gcov data for the serial directory,
> diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> index d056ee6cca33..17272733db95 100644
> --- a/drivers/tty/serial/Makefile
> +++ b/drivers/tty/serial/Makefile
> @@ -3,6 +3,7 @@
> # Makefile for the kernel serial device drivers.
> #
>
> +GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
> obj-$(CONFIG_SERIAL_CORE) += serial_core.o
>
> obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o
> diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> index 3110c77230c7..bb2e1fb85743 100644
> --- a/kernel/gcov/Kconfig
> +++ b/kernel/gcov/Kconfig
> @@ -51,4 +51,16 @@ config GCOV_PROFILE_ALL
> larger and run slower. Also be sure to exclude files from profiling
> which are not linked to the kernel image to prevent linker errors.
>
> +config GCOV_PROFILE_PREREQS
> + bool "Profile Kernel for prereqs"
> + depends on GCOV_KERNEL
> + depends on !COMPILE_TEST
> + def_bool y if GCOV_KERNEL && !COMPILE_TEST
> + help
> + This options activates profiling for the specified kernel modules.
> +
> + When some modules need Gcov data, enable this config, then configure
> + with gcov on the corresponding modules,The directories or files of
> + these modules will be added profiling flags after kernel compile.
> +
> endmenu
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-08-20 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 8:51 [PATCH V7] GCOV: Add config to check the preqequisites situation gengcixi
2020-08-20 12:40 ` Cixi Geng [this message]
2020-09-16 12:55 ` Cixi Geng
2020-10-22 10:03 ` Peter Oberparleiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF12kFuss4AQZSBX+A2G_fWjka3C4kpf4iDWU9QJY=AWigoxqg@mail.gmail.com' \
--to=gengcixi@gmail.com \
--cc=cixi.geng1@unisoc.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).