From: Chanwoo Choi <cwchoi00@gmail.com>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, dl-linux-imx <linux-imx@nxp.com>,
Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
yuq825@gmail.com, David Airlie <airlied@linux.ie>,
daniel@ffwll.ch, robdclark@gmail.com, sean@poorly.run,
Rob Herring <robh@kernel.org>,
tomeu.vizoso@collabora.com, steven.price@arm.com,
alyssa.rosenzweig@collabora.com, stanimir.varbanov@linaro.org,
agross@kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>,
mchehab@kernel.org, Lukasz Luba <lukasz.luba@arm.com>,
adrian.hunter@intel.com, Ulf Hansson <ulf.hansson@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>, Mark Brown <broonie@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
jirislaby@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
jcrouse@codeaurora.org, hoegsberg@google.com, eric@anholt.net,
tzimmermann@suse.de, marijn.suijten@somainline.org,
gustavoars@kernel.org, emil.velikov@collabora.com,
jonathan@marek.ca, akhilpo@codeaurora.org,
smasetty@codeaurora.org, airlied@redhat.com,
masneyb@onstation.org, kalyan_t@codeaurora.org,
tanmay@codeaurora.org, ddavenport@chromium.org,
jsanka@codeaurora.org, rnayak@codeaurora.org,
tongtiangen@huawei.com, miaoqinglang@huawei.com,
khsieh@codeaurora.org, abhinavk@codeaurora.org,
chandanu@codeaurora.org, Guenter Roeck <groeck@chromium.org>,
varar@codeaurora.org, Matthias Kaehlcke <mka@chromium.org>,
harigovi@codeaurora.org, rikard.falkeborn@gmail.com,
natechancellor@gmail.com,
Georgi Djakov <georgi.djakov@linaro.org>,
akashast@codeaurora.org, parashar@codeaurora.org,
Doug Anderson <dianders@chromium.org>,
Linux PM list <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-tegra@vger.kernel.org,
dri-devel <dri-devel@lists.freedesktop.org>,
lima@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, linux-media@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 26/31] PM / devfreq: tegra30: convert to use devm_pm_opp_* API
Date: Tue, 5 Jan 2021 12:47:16 +0900 [thread overview]
Message-ID: <CAGTfZH0sLh=8XhBVOzUr9qO2w_=jp-OuWoh5vgNpnmXq6EzYHA@mail.gmail.com> (raw)
In-Reply-To: <20210103035445.23696-1-tiny.windzz@gmail.com>
Hi,
On Sun, Jan 3, 2021 at 12:57 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> Use devm_pm_opp_* API to simplify code, and remove opp_table
> from tegra_devfreq.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/devfreq/tegra30-devfreq.c | 21 +++++++--------------
> 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 117cad7968ab..4984cb91e9ea 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -178,7 +178,6 @@ struct tegra_devfreq_soc_data {
>
> struct tegra_devfreq {
> struct devfreq *devfreq;
> - struct opp_table *opp_table;
>
> struct reset_control *reset;
> struct clk *clock;
> @@ -794,6 +793,7 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> struct tegra_devfreq_device *dev;
> struct tegra_devfreq *tegra;
> struct devfreq *devfreq;
> + struct opp_tabl *opp_table;
opp_tabl -> opp_table. It will make the build error. Please do build
test at least.
> unsigned int i;
> long rate;
> int err;
> @@ -841,25 +841,25 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> return err;
> }
>
> - tegra->opp_table = dev_pm_opp_set_supported_hw(&pdev->dev,
> - &hw_version, 1);
> - err = PTR_ERR_OR_ZERO(tegra->opp_table);
> + opp_table = devm_pm_opp_set_supported_hw(&pdev->dev,
> + &hw_version, 1);
> + err = PTR_ERR_OR_ZERO(opp_table);
> if (err) {
> dev_err(&pdev->dev, "Failed to set supported HW: %d\n", err);
> return err;
> }
>
> - err = dev_pm_opp_of_add_table(&pdev->dev);
> + err = devm_pm_opp_of_add_table(&pdev->dev);
> if (err) {
> dev_err(&pdev->dev, "Failed to add OPP table: %d\n", err);
> - goto put_hw;
> + return err;
> }
>
> err = clk_prepare_enable(tegra->clock);
> if (err) {
> dev_err(&pdev->dev,
> "Failed to prepare and enable ACTMON clock\n");
> - goto remove_table;
> + return err;
> }
>
> err = reset_control_reset(tegra->reset);
> @@ -917,10 +917,6 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> reset_control_reset(tegra->reset);
> disable_clk:
> clk_disable_unprepare(tegra->clock);
> -remove_table:
> - dev_pm_opp_of_remove_table(&pdev->dev);
> -put_hw:
> - dev_pm_opp_put_supported_hw(tegra->opp_table);
You might remove the 'devm_pm_opp_remove_all_dynamic(&pdev->dev)
under ' remove_opp' goto statement.kkkk
(snip)
--
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2021-01-05 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 3:54 [PATCH 26/31] PM / devfreq: tegra30: convert to use devm_pm_opp_* API Yangtao Li
2021-01-04 7:30 ` Viresh Kumar
2021-01-05 3:47 ` Chanwoo Choi [this message]
2021-01-06 18:17 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGTfZH0sLh=8XhBVOzUr9qO2w_=jp-OuWoh5vgNpnmXq6EzYHA@mail.gmail.com' \
--to=cwchoi00@gmail.com \
--cc=abhinavk@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=akashast@codeaurora.org \
--cc=akhilpo@codeaurora.org \
--cc=alyssa.rosenzweig@collabora.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=chandanu@codeaurora.org \
--cc=cw00.choi@samsung.com \
--cc=daniel@ffwll.ch \
--cc=ddavenport@chromium.org \
--cc=dianders@chromium.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=eric@anholt.net \
--cc=festevam@gmail.com \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=harigovi@codeaurora.org \
--cc=hoegsberg@google.com \
--cc=jcrouse@codeaurora.org \
--cc=jirislaby@kernel.org \
--cc=jonathan@marek.ca \
--cc=jonathanh@nvidia.com \
--cc=jsanka@codeaurora.org \
--cc=kalyan_t@codeaurora.org \
--cc=kernel@pengutronix.de \
--cc=khsieh@codeaurora.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lima@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=marijn.suijten@somainline.org \
--cc=masneyb@onstation.org \
--cc=mchehab@kernel.org \
--cc=miaoqinglang@huawei.com \
--cc=mka@chromium.org \
--cc=myungjoo.ham@samsung.com \
--cc=natechancellor@gmail.com \
--cc=nm@ti.com \
--cc=parashar@codeaurora.org \
--cc=rikard.falkeborn@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=smasetty@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
--cc=steven.price@arm.com \
--cc=tanmay@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=tiny.windzz@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tongtiangen@huawei.com \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=varar@codeaurora.org \
--cc=vireshk@kernel.org \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).