From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Paul Burton <paulburton@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250_ioc3: Fix ioremap call
Date: Tue, 4 Feb 2020 16:39:45 +0200 [thread overview]
Message-ID: <CAHp75Ve2_cH7M4nLQ-KynPWRt6NvCGk3LGafOEAjigfNyprcZw@mail.gmail.com> (raw)
In-Reply-To: <20200204113912.14048-1-tbogendoerfer@suse.de>
On Tue, Feb 4, 2020 at 1:40 PM Thomas Bogendoerfer
<tbogendoerfer@suse.de> wrote:
>
> Commit 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
> removed devm_ioremap_nocache, but 8250_ioc3 wasn't upstream at that
> time. So fix 8250_ioc3 by using devm_ioremap.
>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
Basically it happened due to ioremap_nocache() removal, but it really
doesn't matter because in this case no functional change is expected.
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
> drivers/tty/serial/8250/8250_ioc3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_ioc3.c b/drivers/tty/serial/8250/8250_ioc3.c
> index 4c405f1b9c67..d5a39e105a76 100644
> --- a/drivers/tty/serial/8250/8250_ioc3.c
> +++ b/drivers/tty/serial/8250/8250_ioc3.c
> @@ -47,7 +47,7 @@ static int serial8250_ioc3_probe(struct platform_device *pdev)
> if (!data)
> return -ENOMEM;
>
> - membase = devm_ioremap_nocache(&pdev->dev, r->start, resource_size(r));
> + membase = devm_ioremap(&pdev->dev, r->start, resource_size(r));
> if (!membase)
> return -ENOMEM;
>
> --
> 2.24.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-04 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 11:39 [PATCH] serial: 8250_ioc3: Fix ioremap call Thomas Bogendoerfer
2020-02-04 14:39 ` Andy Shevchenko [this message]
2020-02-10 19:33 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Ve2_cH7M4nLQ-KynPWRt6NvCGk3LGafOEAjigfNyprcZw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).