From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2043C2D0A7 for ; Tue, 8 Sep 2020 16:51:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A2D72075A for ; Tue, 8 Sep 2020 16:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599583900; bh=pW1S8wYQ7shAS4VTkFPTvct/ClWzUHOw3xWhbsYQUNo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=HrxNebQiLLR8qeYRH0rrSbsha0+Rq2L6kE6lqw/4UUc0jsMtwoiyK4tMFtattN/TB GaT9rLCP6+ySjnok2Rn7ySFqYL6sz60HZElPPIXaZ2gVFZ0TOD4e961ISxx9/XiujG Jf7DZ3Fi0l/LCEq/YqtHQCg3CF3d08Kd5+lh9lMA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731928AbgIHQvj (ORCPT ); Tue, 8 Sep 2020 12:51:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:41926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731909AbgIHQvJ (ORCPT ); Tue, 8 Sep 2020 12:51:09 -0400 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B576E2137B; Tue, 8 Sep 2020 16:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599583868; bh=pW1S8wYQ7shAS4VTkFPTvct/ClWzUHOw3xWhbsYQUNo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FgS6w9TKkNIumIokoiwznLHegSZ8da9H6/tyCUONyA8D6mS4MC5L9U2z22U5vpbaJ F9LBw9H3U/ZQfNzWt6ceq2QpbMCME12qMJBPAnufXbEXaMdXUN5OQTdjSiBIy0r3bk 7U2jnKRg1UiTm9IReOgbeVZRQG6XO2kMrq5x8Ajs= Received: by mail-oo1-f51.google.com with SMTP id 4so4091291ooh.11; Tue, 08 Sep 2020 09:51:08 -0700 (PDT) X-Gm-Message-State: AOAM5336w4FaUrgkkaZQMHIC9XcoaoO79MmlghHpn2rTwscnyo8U5huj MQjZH4r+nvWe9apsBepBEXfpRVfNTTha4s0nQQ== X-Google-Smtp-Source: ABdhPJyVFdSAOgZ7160kEJoAezjYnztio3h9Ino2moi2r5NNuCCiGtHqBpSUtvivi5rsYhCBevOSckk/m/8RpCmF5Go= X-Received: by 2002:a4a:d306:: with SMTP id g6mr19090952oos.25.1599583867914; Tue, 08 Sep 2020 09:51:07 -0700 (PDT) MIME-Version: 1.0 References: <20200904152404.20636-1-krzk@kernel.org> <20200904152404.20636-13-krzk@kernel.org> <20200907060958.GA4525@kozik-lap> In-Reply-To: <20200907060958.GA4525@kozik-lap> From: Rob Herring Date: Tue, 8 Sep 2020 10:50:56 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 12/14] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs To: Krzysztof Kozlowski Cc: linux-clk , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , MTD Maling List , Linux PWM List , "open list:SERIAL DRIVERS" , "open list:THERMAL" , LINUX-WATCHDOG , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Guenter Roeck Content-Type: text/plain; charset="UTF-8" Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Mon, Sep 7, 2020 at 12:10 AM Krzysztof Kozlowski wrote: > > On Fri, Sep 04, 2020 at 04:36:39PM -0600, Rob Herring wrote: > > On Fri, Sep 4, 2020 at 9:25 AM Krzysztof Kozlowski wrote: > > > > > > Driver requires different amount of clocks for different SoCs. Describe > > > these requirements properly to fix dtbs_check warnings like: > > > > > > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > --- > > > > > > Changes since v1: > > > 1. Do not require order of clocks (use pattern). > > > > To the extent that you can, you should fix the order in dts files > > first. If we just adjust the schemas to match the dts files, then > > what's the point? > > The DTSes do not have mixed order of clocks between each other, as fair > as I remember. It was fix after Sasha Hauer comment that order is not > necessarily good. > > We have the clock-names property, why enforcing the order? Because DT/OpenFirmware has always had a defined order for property values. '*-names' is just extra information. Rob