From: Rob Herring <robh+dt@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Vladimir Vid" <vladimir.vid@sartura.hr>,
"Marek Behún" <kabel@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND PATCH v5 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock
Date: Mon, 27 Sep 2021 15:17:59 -0500 [thread overview]
Message-ID: <CAL_JsqKS1rjEeM558d2n6Uk1+tCazASoGJ-kDS144PsH8-Akwg@mail.gmail.com> (raw)
In-Reply-To: <20210922105433.11744-4-pali@kernel.org>
On Wed, Sep 22, 2021 at 5:56 AM Pali Rohár <pali@kernel.org> wrote:
>
> This change adds DT bindings documentation for device nodes with compatible
> string "marvell,armada-3700-uart-clock".
Please resend to the DT list so that checks run and this gets reviewed
in a timely manner.
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> .../bindings/clock/armada3700-uart-clock.yaml | 57 +++++++++++++++++++
> 1 file changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml b/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
> new file mode 100644
> index 000000000000..5bdb23e0ba3e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual license. checkpatch will tell you which ones.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/marvell,armada-3700-uart-clock#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +title: Marvell Armada 3720 UART clocks
> +
> +properties:
> + compatible:
> + const: marvell,armada-3700-uart-clock
> +
> + reg:
> + items:
> + - description: UART Clock Control Register
> + - description: UART 2 Baud Rate Divisor Register
> +
> + clocks:
> + description: |
> + List of parent clocks suitable for UART from following set:
> + "TBG-A-P", "TBG-B-P", "TBG-A-S", "TBG-B-S", "xtal"
> + UART clock can use one from this set and when more are provided
> + then kernel would choose and configure the most suitable one.
> + It is suggest to specify at least one TBG clock to achieve
> + baudrates above 230400 and also to specify clock which bootloader
> + used for UART (most probably xtal) for smooth boot log on UART.
> +
> + clock-names:
> + items:
> + - const: TBG-A-P
> + - const: TBG-B-P
> + - const: TBG-A-S
> + - const: TBG-B-S
> + - const: xtal
> + minItems: 1
> + maxItems: 5
Don't need maxItems equal to length of 'items'.
> +
> + '#clock-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + uartclk: uartclk@12000 {
clock-controller@12010
> + compatible = "marvell,armada-3700-uart-clock";
> + reg = <0x12010 0x4>, <0x12210 0x4>;
However, looks like this is part of some other block. The whole block
needs a binding (or at least the parent and whatever sub-functions you
know about).
> + clocks = <&tbg 0>, <&tbg 1>, <&tbg 2>, <&tbg 3>, <&xtalclk>;
> + clock-names = "TBG-A-P", "TBG-B-P", "TBG-A-S", "TBG-B-S", "xtal";
> + #clock-cells = <1>;
> + };
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-09-27 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 10:54 [RESEND PATCH v5 0/6] serial: mvebu-uart: Support for higher baudrates Pali Rohár
2021-09-22 10:54 ` [RESEND PATCH v5 1/6] math64: New DIV_U64_ROUND_CLOSEST helper Pali Rohár
2021-09-22 10:54 ` [RESEND PATCH v5 2/6] serial: mvebu-uart: implement UART clock driver for configuring UART base clock Pali Rohár
2021-09-22 10:54 ` [RESEND PATCH v5 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2021-09-27 20:17 ` Rob Herring [this message]
2021-09-27 20:34 ` Pali Rohár
2021-09-28 17:57 ` Rob Herring
2021-09-27 20:45 ` Pali Rohár
2021-09-28 17:55 ` Rob Herring
2021-09-22 10:54 ` [RESEND PATCH v5 4/6] dt-bindings: mvebu-uart: update information about UART clock Pali Rohár
2021-09-22 10:54 ` [RESEND PATCH v5 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it Pali Rohár
2021-09-22 15:16 ` Gregory CLEMENT
2021-09-22 16:07 ` Pali Rohár
2021-09-22 10:54 ` [RESEND PATCH v5 6/6] serial: mvebu-uart: implement support for baudrates higher than 230400 Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKS1rjEeM558d2n6Uk1+tCazASoGJ-kDS144PsH8-Akwg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=andrew@lunn.ch \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pali@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vladimir.vid@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).