From: Max Filippov <jcmvbkbc@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>, Chris Zankel <chris@zankel.net>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH 3/8] tty: don't store semi-state into tty drivers
Date: Fri, 23 Jul 2021 03:23:48 -0700 [thread overview]
Message-ID: <CAMo8Bf+8QNqmGHeL5pOdEjWpMRUGG+D9YbDeWMn8Dvygd5HgUw@mail.gmail.com> (raw)
In-Reply-To: <20210723074317.32690-4-jslaby@suse.cz>
On Fri, Jul 23, 2021 at 12:43 AM Jiri Slaby <jslaby@suse.cz> wrote:
>
> When a tty driver pointer is used as a return value of struct
> console's device() hook, don't store a semi-state into global variable
> which holds the tty driver. It could mean console::device() would return
> a bogus value. This is important esp. after the next patch where we
> switch from alloc_tty_driver to tty_alloc_driver. tty_alloc_driver
> returns ERR_PTR in case of error and that might have unexpected results
> as the code doesn't expect this.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> Cc: Felipe Balbi <balbi@kernel.org>
> ---
> arch/m68k/emu/nfcon.c | 27 +++++++++++---------
> arch/parisc/kernel/pdc_cons.c | 28 +++++++++++----------
> arch/xtensa/platforms/iss/console.c | 33 +++++++++++++-----------
> drivers/tty/amiserial.c | 35 ++++++++++++++------------
> drivers/tty/ehv_bytechan.c | 28 ++++++++++++---------
> drivers/tty/hvc/hvsi.c | 35 ++++++++++++++------------
> drivers/usb/gadget/function/u_serial.c | 32 ++++++++++++-----------
> 7 files changed, 119 insertions(+), 99 deletions(-)
Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
next prev parent reply other threads:[~2021-07-23 10:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 7:43 [PATCH 0/8] Get rid of old tty_driver functions Jiri Slaby
2021-07-23 7:43 ` [PATCH 1/8] xtensa: ISS: don't panic in rs_init Jiri Slaby
2021-07-23 10:18 ` Max Filippov
2021-07-23 7:43 ` [PATCH 2/8] hvsi: don't panic on tty_register_driver failure Jiri Slaby
2021-07-23 7:43 ` [PATCH 3/8] tty: don't store semi-state into tty drivers Jiri Slaby
2021-07-23 10:23 ` Max Filippov [this message]
2021-07-23 16:37 ` Helge Deller
2021-07-23 7:43 ` [PATCH 4/8] tty: stop using alloc_tty_driver Jiri Slaby
2021-07-23 7:49 ` Samuel Iglesias Gonsálvez
2021-07-23 7:57 ` Christian Borntraeger
2021-07-23 10:16 ` David Sterba
2021-07-23 10:30 ` Max Filippov
2021-07-23 7:43 ` [PATCH 5/8] tty: drop alloc_tty_driver Jiri Slaby
2021-07-23 7:43 ` [PATCH 6/8] tty: make tty_set_operations an inline Jiri Slaby
2021-07-23 7:43 ` [PATCH 7/8] tty: drop put_tty_driver Jiri Slaby
2021-07-23 7:49 ` Samuel Iglesias Gonsálvez
2021-07-23 7:55 ` Christian Borntraeger
2021-07-23 10:16 ` David Sterba
2021-07-23 10:32 ` Max Filippov
2021-07-23 12:50 ` Alex Elder
2021-07-23 7:43 ` [PATCH 8/8] tty: pdc_cons, free tty_driver upon failure Jiri Slaby
2021-07-27 10:18 ` [PATCH 0/8] Get rid of old tty_driver functions Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8Bf+8QNqmGHeL5pOdEjWpMRUGG+D9YbDeWMn8Dvygd5HgUw@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=balbi@kernel.org \
--cc=chris@zankel.net \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).