From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_LOCAL_NOVOWEL,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E93C4338F for ; Fri, 23 Jul 2021 10:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA87E60E91 for ; Fri, 23 Jul 2021 10:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230238AbhGWJuE (ORCPT ); Fri, 23 Jul 2021 05:50:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbhGWJtr (ORCPT ); Fri, 23 Jul 2021 05:49:47 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F68DC061575; Fri, 23 Jul 2021 03:30:20 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id b7so1163893edu.3; Fri, 23 Jul 2021 03:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eCTcORAv1g4ZQcCl45BbfbmRXduUC1LuQuWshBTXAcU=; b=QpURZJKeVutsL2qJCbTXmluDt838EfpKWZvDZVTk/VltnTaXidaJZ/FAEi8B33O8TY I2wTTYGIcQ80aCU49Xqu982fgV/ActDLwyeSGS7G1NXGmeKUtCtJxr9LMDp34R0rHjyy HUfI4i8yeuJ3mEfcB2x1ecWDHfKySTGkI3S/PbjUYAd1CwW/CCk8YDAvUB6ZNG/qqmxs RTT63hyrxitUbdwHXfmRCPWzlEzpspfDIB0SR7cJjWAsKoTir8XbMT1odgjMepzl/clm 6Gp+PrHmnSRQKt35syaxFWK40NSXj1Mf/GNL9Y7AT51zq+Boi6rNKCEuyBHxzr+0ZGKy RG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCTcORAv1g4ZQcCl45BbfbmRXduUC1LuQuWshBTXAcU=; b=G0Uu/VNWaIv7YK4lEl8fNkLXQ11enX/0jjWzpPeOvsnQ+DZM5efClyYCLk3cqo46dj CTfMR6VNph5kZaE7uD/jr0SF3aQ/84Anemo+C78mjjOaaDWiE/LMMFKrNItpxCzuoZXb OTUktvOn2RRpRa9NxZwLavAR8k3T38pDSCSvcjWGFDrm2hBLI4XF43FabfrDi66whbiX lvTwfkOoBQW+5gbk8RsqPGGDOzf62KIHVZCXXrPt0zwCs+gnayUBNQoITE+g7ZA41053 qZREsbo3XMEtWvNz+JF6qmWr/4+E/wV1re/QmHN0erhs4bp2JvSeficd+H8nmfGomiYn Gt7g== X-Gm-Message-State: AOAM533NHaarKmzh6oxALNdMktRQfqi7vRxf3OfhIBTQxrQ6LCg37KjM NWarQxaWHZ+sYJo5ceHIA2pq7HGlmyq7wg15zfY= X-Google-Smtp-Source: ABdhPJyTUYZnNcIhqtcdl/GULEIgUzuWe2DKhVxIgGx3Z7dURnN5tnskvOXZC3jcCDbpRDPN6T9OTl5wkfRk1c2+aTs= X-Received: by 2002:a05:6402:18c4:: with SMTP id x4mr4770170edy.350.1627036219141; Fri, 23 Jul 2021 03:30:19 -0700 (PDT) MIME-Version: 1.0 References: <20210723074317.32690-1-jslaby@suse.cz> <20210723074317.32690-5-jslaby@suse.cz> In-Reply-To: <20210723074317.32690-5-jslaby@suse.cz> From: Max Filippov Date: Fri, 23 Jul 2021 03:30:07 -0700 Message-ID: Subject: Re: [PATCH 4/8] tty: stop using alloc_tty_driver To: Jiri Slaby Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, LKML , Richard Henderson , Ivan Kokshaysky , Matt Turner , Geert Uytterhoeven , "James E.J. Bottomley" , Helge Deller , Jeff Dike , Richard Weinberger , Anton Ivanov , Chris Zankel , Samuel Iglesias Gonsalvez , Jens Taprogge , Karsten Keil , Ulf Hansson , "David S. Miller" , Jakub Kicinski , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Laurentiu Tudor , Jiri Kosina , David Sterba , Shawn Guo , Sascha Hauer , Oliver Neukum , Felipe Balbi , Johan Hovold , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Jul 23, 2021 at 12:43 AM Jiri Slaby wrote: > > alloc_tty_driver was deprecated by tty_alloc_driver in commit > 7f0bc6a68ed9 (TTY: pass flags to alloc_tty_driver) in 2012. > > I never got into eliminating alloc_tty_driver until now. So we still > have two functions for allocating drivers which might be confusing. So > get rid of alloc_tty_driver uses to eliminate it for good in the next > patch. > > Note we need to switch return value checking as tty_alloc_driver uses > ERR_PTR. And flags are now a parameter of tty_alloc_driver. > > Signed-off-by: Jiri Slaby > arch/xtensa/platforms/iss/console.c | 7 +++---- Acked-by: Max Filippov -- Thanks. -- Max