From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH] serial: sh-sci: Initialize spinlock for uart console
Date: Thu, 2 Jul 2020 11:23:42 +0200 [thread overview]
Message-ID: <CAMuHMdVdCH-r-xMnDgUYzJfDCzUJCYt8CkSDp9E=tgfP01FrKw@mail.gmail.com> (raw)
In-Reply-To: <CA+V-a8v+2fhqwRNCaGYbmh8E1FDyc2Xss3PHk12dpTt_pgmCFg@mail.gmail.com>
Hi Prabhakar,
On Wed, Jul 1, 2020 at 7:28 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Wed, Jul 1, 2020 at 6:17 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Jul 1, 2020 at 5:42 PM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > serial core expects the spinlock to be initialized by the controller
> > > driver for serial console, this patch makes sure the spinlock is
> > > initialized, fixing the below issue:
> > >
> > > [ 0.865928] BUG: spinlock bad magic on CPU#0, swapper/0/1
> > > [ 0.865945] lock: sci_ports+0x0/0x4c80, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
> > > [ 0.865955] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc1+ #112
> > > [ 0.865961] Hardware name: HopeRun HiHope RZ/G2H with sub board (DT)
> > > [ 0.865968] Call trace:
> > > [ 0.865979] dump_backtrace+0x0/0x1d8
> > > [ 0.865985] show_stack+0x14/0x20
> > > [ 0.865996] dump_stack+0xe8/0x130
> > > [ 0.866006] spin_dump+0x6c/0x88
> > > [ 0.866012] do_raw_spin_lock+0xb0/0xf8
> > > [ 0.866023] _raw_spin_lock_irqsave+0x80/0xa0
> > > [ 0.866032] uart_add_one_port+0x3a4/0x4e0
> > > [ 0.866039] sci_probe+0x504/0x7c8
> > > [ 0.866048] platform_drv_probe+0x50/0xa0
> > > [ 0.866059] really_probe+0xdc/0x330
> > > [ 0.866066] driver_probe_device+0x58/0xb8
> > > [ 0.866072] device_driver_attach+0x6c/0x90
> > > [ 0.866078] __driver_attach+0x88/0xd0
> > > [ 0.866085] bus_for_each_dev+0x74/0xc8
> > > [ 0.866091] driver_attach+0x20/0x28
> > > [ 0.866098] bus_add_driver+0x14c/0x1f8
> > > [ 0.866104] driver_register+0x60/0x110
> > > [ 0.866109] __platform_driver_register+0x40/0x48
> > > [ 0.866119] sci_init+0x2c/0x34
> > > [ 0.866127] do_one_initcall+0x88/0x428
> > > [ 0.866137] kernel_init_freeable+0x2c0/0x328
> > > [ 0.866143] kernel_init+0x10/0x108
> > > [ 0.866150] ret_from_fork+0x10/0x18
> >
> > Interesting...
> >
> > How can I reproduce that? I do have CONFIG_DEBUG_SPINLOCK=y.
> > I'm wondering why haven't we seen this before...
> >
> I have attached .config for your reference.
Thank you!
I gave it a try with v5.8-rc1 on Salvator-XS with R-Car H3 ES2.0.
However, I couldn't reproduce the issue.
Does it happen on that specific board only? Is this serdev-related?
Note that I had to disable CONFIG_EXTRA_FIRMWARE, as I don't have the
firmware blobs it referenced. Do I need them to trigger the issue?
As the .config has a few non-upstream options, do you have any patches
applied that might impact the issue?
Thanks again!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-07-02 9:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 15:41 [PATCH] serial: sh-sci: Initialize spinlock for uart console Lad Prabhakar
2020-07-01 16:40 ` Greg Kroah-Hartman
2020-07-01 17:17 ` Geert Uytterhoeven
[not found] ` <CA+V-a8v+2fhqwRNCaGYbmh8E1FDyc2Xss3PHk12dpTt_pgmCFg@mail.gmail.com>
2020-07-02 9:23 ` Geert Uytterhoeven [this message]
2020-07-02 10:49 ` Lad, Prabhakar
[not found] ` <CA+V-a8vq4rJAoA583O_28NK2cCEFAzDszDQTPRQHWiXCtDxd-w@mail.gmail.com>
2020-07-02 12:52 ` Geert Uytterhoeven
2020-07-02 14:05 ` Lad, Prabhakar
2020-07-02 14:39 ` Geert Uytterhoeven
2020-07-02 18:32 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVdCH-r-xMnDgUYzJfDCzUJCYt8CkSDp9E=tgfP01FrKw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).