From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FD0C433EA for ; Mon, 13 Jul 2020 12:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E324720738 for ; Mon, 13 Jul 2020 12:24:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729715AbgGMMY5 (ORCPT ); Mon, 13 Jul 2020 08:24:57 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:40792 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbgGMMY4 (ORCPT ); Mon, 13 Jul 2020 08:24:56 -0400 Received: by mail-ot1-f66.google.com with SMTP id c25so9343712otf.7; Mon, 13 Jul 2020 05:24:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NKzDJKlpDpfQR0XqsgcICeQR3a964ULdFkGju83hPh4=; b=PZ8YhE6GE31idexlhmfb3Jirg1fmIzWelFz3bJoSnqo+EVZ4vFFRokFm0JrlHU+Wjt 8qYOpYcBQUmBcVX0OUjBRQkoBWsjFeCRcJbcXh8eDr7pEzceDVZB5EIZvviFDvUnaZ8x uljKNjdd66Zog078sR8ZVwZsMp9ZKUAApgab5j0b11Zc2PNDmQStQJzTp3cxWTcd/e9O Lbm/sK+7BLfprg7I1F6n1rLcPnhCqP7HeRblQ4MNtq9JdVXNSQZD/RWpRa9BvsTHvFGv D5v7NmezD//lb4mE/NwB/84RY9jCWGE0vK7uOYm9nLO/N5m6KKkON4NwebacF8WQ8ozX Qtog== X-Gm-Message-State: AOAM530+jeSYYKO7B1XtwgyItnWIIqrhIk0rckd9yaUI4yVg/Hu/M8ka dH4zr6CDpZg/PtRo7TCQyrFQXkQoI+Qjn3B3lIw= X-Google-Smtp-Source: ABdhPJxFpWOlCjGDSPwtxen5jRbE20ZbTRROeQPrTNlSL/t1mKoQeo8W3SZGj1ef99nPDdRUJYfaYSbuaSZRFBz1XuE= X-Received: by 2002:a05:6830:1451:: with SMTP id w17mr57240483otp.250.1594643094760; Mon, 13 Jul 2020 05:24:54 -0700 (PDT) MIME-Version: 1.0 References: <1594230511-24790-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1594230511-24790-7-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <1594230511-24790-7-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Mon, 13 Jul 2020 14:24:43 +0200 Message-ID: Subject: Re: [PATCH 6/8] arm64: dts: renesas: Initial r8a774e1 SoC device tree To: Lad Prabhakar Cc: Magnus Damm , Rob Herring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Ulf Hansson , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux MMC List , "open list:SERIAL DRIVERS" , Linux ARM , Linux Kernel Mailing List , Prabhakar Content-Type: text/plain; charset="UTF-8" Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi Prabhakar, On Wed, Jul 8, 2020 at 7:49 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Basic support for the RZ/G2H SoC. > > Signed-off-by: Marian-Cristian Rotariu > Signed-off-by: Lad Prabhakar Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi > + avb: ethernet@e6800000 { > + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; According to Rev. 1.00 of the Hardware User's Manual, RZ/G2H does not have the Stream Buffer for EtherAVB-IF, so the second register block should be dropped. > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + > + /* placeholder */ > + }; > + gic: interrupt-controller@f1010000 { > + compatible = "arm,gic-400"; > + #interrupt-cells = <3>; > + #address-cells = <0>; > + interrupt-controller; > + reg = <0x0 0xf1010000 0 0x1000>, > + <0x0 0xf1020000 0 0x20000>, > + <0x0 0xf1040000 0 0x20000>, > + <0x0 0xf1060000 0 0x20000>; > + interrupts = + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; Like Marc already pointed out, GIC_CPU_MASK_SIMPLE(8). With the above fixed: Reviewed-by: Geert Uytterhoeven Will queue in renesas-devel for v5.9, after fixing the above. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds