From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A2B8C35240 for ; Thu, 30 Jan 2020 12:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AE0920CC7 for ; Thu, 30 Jan 2020 12:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726980AbgA3MdC (ORCPT ); Thu, 30 Jan 2020 07:33:02 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:35510 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726873AbgA3MdC (ORCPT ); Thu, 30 Jan 2020 07:33:02 -0500 Received: by mail-ot1-f66.google.com with SMTP id r16so2967386otd.2; Thu, 30 Jan 2020 04:33:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SF4A8MXH4i+NehAjiTIe/wipSti1DDnySBzIoKhtngY=; b=eSq6OFsX4FUlr2UyT62wcGR/P57xE6a1RWZKmFOUveUDcc2MF6HDoUuqNOKoI/hX/Q 5mG9gOuUPYXSq10Qquk70XLbbshE489kwzMlFyZ/fEMlG1cIKE/CzjcSdydLnhPi93pY oUiTEq0UNwlUVxyKVDVRblmdhGAbQT9xy25izoBxIHzbm7hJYMOJqM4Ost6sGI3KcV1G gqRgmUqoqjbDSgGI83nRBNWfLmi5uX1BpcJiQ2PgVmRuTAvi1Z/KTVwzYLhEphYxUJOT cLxQusUClWa9kQ1e5q+NZnJLeiH2oO8cubqo3dFJKVzHmCwvo5wPP6cUAVeldR5XuTgr Rfrg== X-Gm-Message-State: APjAAAVpvdwBCH8pCGTItPOSbZJJAPxLOQZpQw64tf297s9Ibff0pkIj TIpPhBLdXTu5Th82Y6AOkaWnFsLRXCSkwzbjVkc= X-Google-Smtp-Source: APXvYqymSbwIVGK+M1CJKuu8V4/Pmg47Q6gWht5FbqvzeN05ArmzMI8NjyeixcBdRSkS9xgrJChKC5UFlRm4eXp+0T0= X-Received: by 2002:a9d:7984:: with SMTP id h4mr3438190otm.297.1580387581450; Thu, 30 Jan 2020 04:33:01 -0800 (PST) MIME-Version: 1.0 References: <20200129161955.30562-1-erosca@de.adit-jv.com> In-Reply-To: <20200129161955.30562-1-erosca@de.adit-jv.com> From: Geert Uytterhoeven Date: Thu, 30 Jan 2020 13:32:50 +0100 Message-ID: Subject: Re: [PATCH] serial: sh-sci: Support custom speed setting To: Eugeniu Rosca Cc: "open list:SERIAL DRIVERS" , Linux-Renesas , Wolfram Sang , Yoshihiro Shimoda , Ulrich Hecht , "George G . Davis" , Andrew Gabbasov , Jiada Wang , Yuichi Kusakabe , Yasushi Asano , Linux Kernel Mailing List , Greg Kroah-Hartman , Jiri Slaby , Fukui Yohhei , Torii Kenichi , Magnus Damm Content-Type: text/plain; charset="UTF-8" Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi Eugeniu, On Wed, Jan 29, 2020 at 5:20 PM Eugeniu Rosca wrote: > From: Torii Kenichi > > This patch is necessary to use BT module and XM module with DENSO TEN > development board. > > This patch supports ASYNC_SPD_CUST flag by ioctl(TIOCSSERIAL), enables > custom speed setting with setserial(1). > > The custom speed is calculated from uartclk and custom_divisor. > If custom_divisor is zero, custom speed setting is invalid. > > Signed-off-by: Torii Kenichi > [erosca: rebase against v5.5] > Signed-off-by: Eugeniu Rosca Thanks for your patch! While this seems to work fine[*], I have a few comments/questions: 1. This feature seems to be deprecated: sh-sci e6e68000.serial: setserial sets custom speed on ttySC1. This is deprecated. 2. As the wanted speed is specified as a divider, the resulting speed may be off, cfr. the example for 57600 below. Note that the SCIF device has multiple clock inputs, and can do 57600 perfectly if the right crystal has been fitted. 3. What to do with "[PATCH/RFC] serial: sh-sci: Update uartclk based on selected clock" (https://patchwork.kernel.org/patch/11103703/)? Combined with this, things become pretty complicated and unpredictable, as uartclk now always reflect the frequency of the last used base clock, which was the optimal one for the previously used speed.... I think it would be easier if we just had an API to specify a raw speed. Perhaps that already exists? BTW, what's the speed you need for your BT/XM modules? [*] stty speed 38400 < /dev/ttySC1 followed by setserial /dev/ttySC1 spd_cust divisor 1128 gives 57624 bps on Koelsch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds