From: Sam Protsenko <semen.protsenko@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Jiri Slaby <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Ryu Euiyoul <ryu.real@samsung.com>,
Tom Gall <tom.gall@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 06/12] tty: serial: samsung: Add Exynos850 SoC data
Date: Sat, 31 Jul 2021 02:10:35 +0300 [thread overview]
Message-ID: <CAPLW+4=yOETYdVWvG_YUzewRDg9wB1h+z4i3DRDxJQHeVgu1EQ@mail.gmail.com> (raw)
In-Reply-To: <5826bc3e-e9e8-a9bb-4541-21c1b944a60e@canonical.com>
On Fri, 30 Jul 2021 at 19:05, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> On 30/07/2021 16:49, Sam Protsenko wrote:
> > Add serial driver data for Exynos850 SoC. This driver data is basically
> > reusing EXYNOS_COMMON_SERIAL_DRV_DATA, which is common for all Exynos
> > chips, but also enables USI init, which was added in previous commit:
> > "tty: serial: samsung: Init USI to keep clocks running".
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > ---
> > drivers/tty/serial/samsung_tty.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> > index 75ccbb08df4a..d059b516a0f4 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > @@ -2814,11 +2814,19 @@ static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = {
> > .fifosize = { 64, 256, 16, 256 },
> > };
> >
> > +static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = {
> > + EXYNOS_COMMON_SERIAL_DRV_DATA_USI(1),
> > + .fifosize = { 0, },
>
> This does not look correct. You rely on samsung,uart-fifosize property
> but it is optional.
>
Good point. I will replace fifosize elements (in patch series v2) with
this code (the reasoning is below):
.fifosize = { 256, 64, 64, 64 }
TRM mentions that USI block has configurable FIFO of 16/32/64/128/256
byte. In vendor kernel they are setting default values in dtsi instead
of driver, that's where fifosize = { 0 } appeared from. And in vendor
dtsi they set 256 for serial_0 (USI UART instance), 64 for serial_1
(CMGP0 UART instance) and 64 for serial_2 (CMGP1 UART instance). I
tested 256 and 64 for serial_0 (which is used for serial console)
As for fifosize array elements count: though it's possible to
configure up to 7 UARTs in Exynos850 (it has 5 USI blocks and 2 CMGP
blocks, which can be configured as USIs), in a regular case it's only
3 UARTs (1 in USI and 2 in CMGP). This is how it's done in vendor's
device tree, and I doubt someone is going to need more than 3 serials
anyway, looks like very specific case for a mobile SoC. But
CONFIG_SERIAL_SAMSUNG_UARTS_4=y is set by default when using arm64
defconfig, and I'd like to keep minimal delta for this defconfig for
now.
Hope you are ok with this?
Thanks!
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2021-07-30 23:10 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 14:49 [PATCH 00/12] Add minimal support for Exynos850 SoC Sam Protsenko
2021-07-30 14:49 ` [PATCH 01/12] pinctrl: samsung: Fix pinctrl bank pin count Sam Protsenko
2021-07-30 14:49 ` [PATCH 02/12] pinctrl: samsung: Add Exynos850 SoC specific data Sam Protsenko
2021-07-30 15:22 ` Krzysztof Kozlowski
2021-08-02 19:24 ` Sam Protsenko
2021-07-30 14:49 ` [PATCH 03/12] dt-bindings: pinctrl: samsung: Add Exynos850 doc Sam Protsenko
2021-07-30 15:24 ` Krzysztof Kozlowski
2021-07-30 19:31 ` Sam Protsenko
2021-07-30 14:49 ` [PATCH 04/12] tty: serial: samsung: Init USI to keep clocks running Sam Protsenko
2021-07-30 16:31 ` Krzysztof Kozlowski
2021-08-02 23:06 ` Sam Protsenko
2021-08-03 7:37 ` Krzysztof Kozlowski
2021-08-03 11:41 ` Sam Protsenko
2021-07-30 14:49 ` [PATCH 05/12] tty: serial: samsung: Fix driver data macros style Sam Protsenko
2021-07-30 16:34 ` Krzysztof Kozlowski
2021-07-30 14:49 ` [PATCH 06/12] tty: serial: samsung: Add Exynos850 SoC data Sam Protsenko
2021-07-30 15:05 ` Andy Shevchenko
2021-07-30 16:05 ` Krzysztof Kozlowski
2021-07-30 23:10 ` Sam Protsenko [this message]
2021-07-31 7:12 ` Krzysztof Kozlowski
2021-07-30 14:49 ` [PATCH 07/12] dt-bindings: serial: samsung: Add Exynos850 doc Sam Protsenko
2021-07-30 16:35 ` Krzysztof Kozlowski
2021-07-30 19:04 ` Sam Protsenko
2021-07-30 14:49 ` [PATCH 08/12] MAINTAINERS: Cover Samsung clock YAML bindings Sam Protsenko
2021-07-30 15:06 ` Andy Shevchenko
2021-07-30 15:25 ` Krzysztof Kozlowski
2021-07-30 17:32 ` Sam Protsenko
2021-07-30 14:49 ` [PATCH 09/12] dt-bindings: clock: Add bindings for Exynos850 clock controller Sam Protsenko
2021-07-30 15:43 ` Krzysztof Kozlowski
2021-08-03 11:55 ` Sam Protsenko
2021-07-30 22:28 ` Rob Herring
2021-07-30 14:49 ` [PATCH 10/12] clk: samsung: Add Exynos850 clock driver stub Sam Protsenko
2021-07-30 15:11 ` Andy Shevchenko
2021-07-30 17:24 ` Sam Protsenko
2021-07-30 14:49 ` [PATCH 11/12] dt-bindings: interrupt-controller: Add IRQ constants for Exynos850 Sam Protsenko
2021-07-31 8:45 ` Krzysztof Kozlowski
2021-08-03 12:58 ` Sam Protsenko
2021-07-30 14:49 ` [PATCH 12/12] arm64: dts: exynos: Add Exynos850 SoC support Sam Protsenko
2021-07-30 16:50 ` Marc Zyngier
2021-08-04 14:39 ` Sam Protsenko
2021-08-04 15:01 ` Marc Zyngier
2021-08-04 18:37 ` Sam Protsenko
2021-08-05 7:39 ` Marc Zyngier
2021-08-05 15:30 ` Sam Protsenko
2021-08-05 15:50 ` Marc Zyngier
2021-08-04 18:36 ` Krzysztof Kozlowski
2021-08-04 21:30 ` Sam Protsenko
2021-08-05 7:17 ` Krzysztof Kozlowski
2021-08-05 7:30 ` Marc Zyngier
2021-08-05 7:35 ` Krzysztof Kozlowski
2021-07-31 9:03 ` Krzysztof Kozlowski
2021-08-05 23:06 ` Sam Protsenko
2021-08-06 7:48 ` Krzysztof Kozlowski
2021-08-06 12:07 ` Sam Protsenko
2021-08-06 12:32 ` Krzysztof Kozlowski
2021-08-06 12:48 ` Krzysztof Kozlowski
2021-08-06 16:57 ` Sam Protsenko
2021-08-06 20:32 ` Paweł Chmiel
2021-09-06 15:16 ` Sam Protsenko
2021-07-30 15:18 ` [PATCH 00/12] Add minimal support for Exynos850 SoC Krzysztof Kozlowski
2021-07-30 17:21 ` Krzysztof Kozlowski
2021-07-30 19:02 ` Sam Protsenko
2021-07-31 7:29 ` Krzysztof Kozlowski
2021-07-31 8:12 ` Krzysztof Kozlowski
2021-08-02 23:27 ` Sam Protsenko
2021-08-03 7:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPLW+4=yOETYdVWvG_YUzewRDg9wB1h+z4i3DRDxJQHeVgu1EQ@mail.gmail.com' \
--to=semen.protsenko@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.stultz@linaro.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=ryu.real@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tom.gall@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).