From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F157C432BE for ; Sun, 22 Aug 2021 11:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B2C461354 for ; Sun, 22 Aug 2021 11:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233344AbhHVLRX convert rfc822-to-8bit (ORCPT ); Sun, 22 Aug 2021 07:17:23 -0400 Received: from aposti.net ([89.234.176.197]:45274 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232822AbhHVLRX (ORCPT ); Sun, 22 Aug 2021 07:17:23 -0400 Date: Sun, 22 Aug 2021 12:16:29 +0100 From: Paul Cercueil Subject: Re: [PATCH 1/3] serial: 8250_ingenic: Use of_device_get_match_data To: Tang Bin Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, ldewangan@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux@prisktech.co.nz, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Zhang Shengju Message-Id: In-Reply-To: <20210822032806.3256-2-tangbin@cmss.chinamobile.com> References: <20210822032806.3256-1-tangbin@cmss.chinamobile.com> <20210822032806.3256-2-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi, Le dim., août 22 2021 at 11:28:04 +0800, Tang Bin a écrit : > Retrieve OF match data, it's better and cleaner to use > 'of_device_get_match_data' over 'of_match_device'. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Acked-by: Paul Cercueil Cheers, -Paul > --- > drivers/tty/serial/8250/8250_ingenic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_ingenic.c > b/drivers/tty/serial/8250/8250_ingenic.c > index 988bf6bcc..65402d05e 100644 > --- a/drivers/tty/serial/8250/8250_ingenic.c > +++ b/drivers/tty/serial/8250/8250_ingenic.c > @@ -209,16 +209,14 @@ static int ingenic_uart_probe(struct > platform_device *pdev) > struct uart_8250_port uart = {}; > struct ingenic_uart_data *data; > const struct ingenic_uart_config *cdata; > - const struct of_device_id *match; > struct resource *regs; > int irq, err, line; > > - match = of_match_device(of_match, &pdev->dev); > - if (!match) { > + cdata = of_device_get_match_data(&pdev->dev); > + if (!cdata) { > dev_err(&pdev->dev, "Error: No device match found\n"); > return -ENODEV; > } > - cdata = match->data; > > irq = platform_get_irq(pdev, 0); > if (irq < 0) > -- > 2.20.1.windows.1 > > >