From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE674C4338F for ; Fri, 13 Aug 2021 15:21:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B215E60F14 for ; Fri, 13 Aug 2021 15:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241710AbhHMPVk (ORCPT ); Fri, 13 Aug 2021 11:21:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:33678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242662AbhHMPSQ (ORCPT ); Fri, 13 Aug 2021 11:18:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D30D860EE4; Fri, 13 Aug 2021 15:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628867869; bh=97FxDBhO+gj5hTWln0ptZn6i/yb6QPwappDqtDluh0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LVeb2thJxXDJATCxsv91PjHEbhEmwPMZw6lcyLvj2UZIfPpWvNmUlmykXYJpviYHv cZR0Ju0yGs3qK4fZZmQMTvFO0WFfGY3JiI621qzAA2bfSW2Ip932jC0+KjhBSUxz2N bggO4B2ddBF1gUzIqJfJq0Q8fvQfCjL7MMKfe3AA= Date: Fri, 13 Aug 2021 17:14:08 +0200 From: gregkh To: Robin Murphy Cc: Qian Cai , =?utf-8?B?dG9tYmluZmFuKOiMg+WFtSk=?= , Bing Fan , linux-serial , linux-kernel , Linux ARM Subject: Re: [Internet]Re: [PATCH v5] arm pl011 serial: support multi-irq request Message-ID: References: <7535ae2f-6a12-8203-0498-8ac85ab0d9a7@arm.com> <290c01ec-173f-755f-788e-2a33a69586e8@quicinc.com> <0819592c-1baa-e98d-9118-5abde8b8c562@quicinc.com> <67cd6c830e33491e99ea4d2480f4a89d@tencent.com> <09918b566884413898f63b92ddd037a0@tencent.com> <0206c94d-c91b-b7da-8132-d06e23c9d964@quicinc.com> <0f77be70-08fd-6fdd-227d-611c01c54788@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f77be70-08fd-6fdd-227d-611c01c54788@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Aug 13, 2021 at 04:09:50PM +0100, Robin Murphy wrote: > On 2021-08-13 16:01, gregkh wrote: > > On Fri, Aug 13, 2021 at 09:42:52AM -0400, Qian Cai wrote: > > > > > > > > > On 8/12/2021 11:32 PM, tombinfan(范兵) wrote: > > > > hello, > > > > > > > > I have sent the modified patch to the following mailboxes. THX > > > > > > > > gregkh@linuxfoundation.org > > > > linux-serial@vger.kernel.org > > > > linux-kernel@vger.kernel.org > > > > > > Thanks for the pointer. It is good to get some reviews from Arm > > > people in the first place, so we don't break Arm like this. > > > > > > Anyway, for anyone who might be watching, here is the new patch, > > > > > > https://lore.kernel.org/linux-serial/1628825490-18937-1-git-send-email-hptsfb@gmail.com/ > > > > > > Unfortunately, I saw Greg mentioned that it was not based on > > > tty-next, so not something I can apply easily on linux-next here > > > as well. > > > > That is because the code in tty-next (and linux-next), looks to already > > do exactly what you submitted, right? > > > > So is this working now for everyone in linux-next? > > AFAICS commit b0819465be8b in linux-next still results in > amba_device-specific code being called from sbsa_uart_startup() and > sbsa_uart_shutdown(), which is what blows up. Ick, ok, can someone send me a revert with this information in it please? thanks, greg k-h