From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Jiri Slaby <jirislaby@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v4 2/5] tty: serial: sh-sci: Fix Rx on RZ/G2L SCI
Date: Wed, 29 Mar 2023 11:01:33 +0200 [thread overview]
Message-ID: <ZCP-bdhw585BSKdx@kroah.com> (raw)
In-Reply-To: <OS0PR01MB5922092AD985055F7376611486889@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On Tue, Mar 28, 2023 at 11:32:38AM +0000, Biju Das wrote:
> Hi Geert,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH v4 2/5] tty: serial: sh-sci: Fix Rx on RZ/G2L SCI
> >
> > On Tue, Mar 21, 2023 at 12:48 PM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > SCI IP on RZ/G2L alike SoCs do not need regshift compared to other SCI
> > > IPs on the SH platform. Currently, it does regshift and configuring Rx
> > > wrongly. Drop adding regshift for RZ/G2L alike SoCs.
> > >
> > > Fixes: dfc80387aefb ("serial: sh-sci: Compute the regshift value for
> > > SCI ports")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > > v3->v4:
> > > * Updated the fixes tag
> > > * Replaced sci_port->is_rz_sci with dev->dev.of_node as regshift are only
> > needed
> > > for sh770x/sh7750/sh7760, which don't use DT yet.
> > > * Dropped is_rz_sci variable from struct sci_port.
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > One can wonder how this ever worked on DT-based H8/300...
>
> Yep, it is interesting to see whether SCI ever worked on DT-based H8/300
> Assuming it has same register layout as RZ/G2L SoC.
This is already in Linus's tree now, right?
confused,
greg k-h
next prev parent reply other threads:[~2023-03-29 9:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 11:47 [PATCH v4 0/5] Renesas SCI fixes Biju Das
2023-03-21 11:47 ` [PATCH v4 1/5] tty: serial: sh-sci: Fix transmit end interrupt handler Biju Das
2023-03-27 9:12 ` Geert Uytterhoeven
2023-03-21 11:47 ` [PATCH v4 2/5] tty: serial: sh-sci: Fix Rx on RZ/G2L SCI Biju Das
2023-03-27 9:15 ` Geert Uytterhoeven
2023-03-28 11:32 ` Biju Das
2023-03-29 9:01 ` Greg Kroah-Hartman [this message]
2023-03-29 9:06 ` Biju Das
2023-03-29 9:20 ` Greg Kroah-Hartman
2023-03-29 9:31 ` Biju Das
2023-03-21 11:47 ` [PATCH v4 3/5] tty: serial: sh-sci: Fix Tx on SCI IP Biju Das
2023-04-06 6:50 ` Biju Das
2023-03-21 11:47 ` [PATCH v4 4/5] tty: serial: sh-sci: Add support for tx end interrupt handling Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCP-bdhw585BSKdx@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=stable@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).