linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mukesh, Savaliya" <msavaliy@codeaurora.org>
To: Greg KH <gregkh@linuxfoundation.org>, will@kernel.org
Cc: akashast@codeaurora.org, linux-serial@vger.kernel.org,
	saravanak@google.com, sspatil@google.com, tkjos@google.com
Subject: Re: [PATCH V2] serial: msm_geni_serial_console : Add Earlycon support
Date: Thu, 14 May 2020 19:02:49 +0530	[thread overview]
Message-ID: <a66f2bdc-57e6-e155-26ce-5643bbc045ad@codeaurora.org> (raw)
In-Reply-To: <20200506120237.GA3047211@kroah.com>


On 5/6/2020 5:32 PM, Greg KH wrote:
> On Wed, May 06, 2020 at 05:03:31PM +0530, Mukesh, Savaliya wrote:
>> +static void msm_geni_serial_wr_char(struct uart_port *uport, int ch)
>> +{
>> +	writel_relaxed(ch, uport->membase+SE_GENI_TX_FIFOn);
>> +	/*
>> +	 * Ensure FIFO write clear goes through before
>> +	 * next iteration.
>> +	 */
>> +	mb();
> Can't you just write the above two lines as:
> 	writel(ch, uport->membase+SE_GENI_TX_FIFOn);
> ?
>
> Why put a mb() after a _relaxed() call?
>
> Will, I know I asked you about this on irc a while ago, is the above
> really correct?
>
> This happens other places in the driver.
Removed mb() calls due to _relaxed() APIs taking care of the same.
>
> Also, Savaliya, please use checkpatch on your patch, you need some
> whitespace fixes in this code before I could accept it at the very
> least.

I ran the script now also on same patch, didn't any warning/error. Do 
you see the error ? Below is the output:

./scripts/checkpatch.pl 
0001-serial-msm_geni_serial_console-Add-Earlycon-support.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#58:
new file mode 100644

total: 0 errors, 1 warnings, 511 lines checked

>
> thanks,
>
> greg k-h

  parent reply	other threads:[~2020-05-14 13:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 11:33 [PATCH V2] serial: msm_geni_serial_console : Add Earlycon support Mukesh, Savaliya
2020-05-06 12:02 ` Greg KH
2020-05-06 12:48   ` Will Deacon
2020-05-06 12:59     ` Greg KH
2020-05-14 13:33       ` Mukesh, Savaliya
2020-05-14 13:32   ` Mukesh, Savaliya [this message]
2020-05-14 14:02     ` Greg KH
2020-05-06 12:05 ` Greg KH
2020-05-14 13:33   ` Mukesh, Savaliya
2020-05-14 14:02     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a66f2bdc-57e6-e155-26ce-5643bbc045ad@codeaurora.org \
    --to=msavaliy@codeaurora.org \
    --cc=akashast@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=saravanak@google.com \
    --cc=sspatil@google.com \
    --cc=tkjos@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).