From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68C5C4724C for ; Thu, 7 May 2020 12:53:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A8DE2082E for ; Thu, 7 May 2020 12:53:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cLbNb6du" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725947AbgEGMxK (ORCPT ); Thu, 7 May 2020 08:53:10 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:46580 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725948AbgEGMxK (ORCPT ); Thu, 7 May 2020 08:53:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588855988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hvqm5iDK+KZF8xmh4JNvSsVzvvifeygBB2w/QK0T3GY=; b=cLbNb6dudFgAztPNO8ufkYhABOViFCsfK4GRig1FmN5adTl9zXy7LjR9hq8jPGTlbpWiHS MclGgTcTq54WT+ss1yPFwXF32p73+d2F96zxvcnoGVstrp751gn555HcvOT7wwxFysp7VU FttHaLyERkRmtVBXVI1VBfdWtU4a4cE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-6-rDRNIkP9y90oprq60W5Q-1; Thu, 07 May 2020 08:53:07 -0400 X-MC-Unique: 6-rDRNIkP9y90oprq60W5Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7EB2280183C; Thu, 7 May 2020 12:53:05 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1F525C1BE; Thu, 7 May 2020 12:53:04 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id 047Cr4Ef028866; Thu, 7 May 2020 08:53:04 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id 047Cr3Ga028857; Thu, 7 May 2020 08:53:03 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Thu, 7 May 2020 08:53:03 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Greg Kroah-Hartman cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, Arnd Bergmann , linux-serial@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 2/2 v4] alpha: add a delay before serial port read In-Reply-To: <20200507111037.GB1490467@kroah.com> Message-ID: References: <20200506114711.GB3024358@kroah.com> <20200506154938.GA3537174@kroah.com> <20200506160823.GA3559699@kroah.com> <20200506174528.GB3711921@kroah.com> <20200507085201.GA1097552@kroah.com> <20200507111037.GB1490467@kroah.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, 7 May 2020, Greg Kroah-Hartman wrote: > On Thu, May 07, 2020 at 06:53:55AM -0400, Mikulas Patocka wrote: > > Index: linux-stable/include/linux/pci.h > > =================================================================== > > Is this coming from git? No - I use quilt. > > --- linux-stable.orig/include/linux/pci.h 2020-05-07 09:57:02.000000000 +0200 > > +++ linux-stable/include/linux/pci.h 2020-05-07 09:57:02.000000000 +0200 > > @@ -2384,6 +2384,10 @@ static inline bool pci_is_thunderbolt_at > > return false; > > } > > > > +#ifndef serial_port_needs_delay > > +#define serial_port_needs_delay 0 > > +#endif > > Anyway, why is this in pci.h? It has nothing to do with the PCI core. > > And the name needs a lot better description, something like: > alpha_has_b0rken_serial_ports_and_needs_delay > or something to prevent anyone else from ever using this, right? > > greg k-h OK - I moved it to asm/serial.h Mikulas