From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688BBC6FD19 for ; Thu, 16 Mar 2023 07:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbjCPHkj (ORCPT ); Thu, 16 Mar 2023 03:40:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjCPHki (ORCPT ); Thu, 16 Mar 2023 03:40:38 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DDAE8C97A for ; Thu, 16 Mar 2023 00:40:32 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id cy23so3844047edb.12 for ; Thu, 16 Mar 2023 00:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678952430; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fVjHSwxCcgK0nlIxtPzn0yGiuSzfP6fPLQyW4o2TIgc=; b=lZiB7LDRuktbamKmx3zqPK/7I17B5efX2zWYp9MdqdHgJ65b7/Et6KxeZoPBXSviDC C9I8xrBWnap4sZo/no1Uhw7801qi10JC+M3pm+abBkCklPjZDdSBLLQRk0kqIAjOdFbO Fjf/3BLkN/NVGYXwXarN4ArFP6Qwv1J3HIJTye1IBFsxpzdEWY05bX60uX7rqsnLZthe pTIESvXGqKrSsTAiMpxy6AvAzroKRIuz7lGModJnn3QGXjUoZYAQ8TSz+1HkeD2hT/Y+ 61Ow10PA/VIS6Q+rEWrgrZvvtDf3gvmi/JYShmAKZoc4e+5K9j08Rrkm7KyUrTi0LMJB HeFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678952430; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fVjHSwxCcgK0nlIxtPzn0yGiuSzfP6fPLQyW4o2TIgc=; b=ppxSFE7n6Oj5LBnYhhBf5g/LBzd6HD6lrm3v9K51AjbEas60wDjpceqI/xS+EGH5Jc zEKW880zoI28cX1w/iXqtVTpHeKFldpIXk1oxKvHvStcGYffXw6iDb6EEb86FidL5aUa J5MUGL2cXcitMq1mVTPrtY3M3brONPc4r4xYCYYaETPig6fA+bx9bi1WzwOlpRNw8HJO fkVNr/6K4Rp56w5I0QCrPqS53FnjnzCDY8mvmDxv+QmhGmLRDUs18s5F86r2lQjZo0yL OwHgZ47SsijCfk7vj5VfR2l2yEpOWkCVwxEr9YcJlQIakIv6akTXfCYksnTmSbbR5e60 mQ4g== X-Gm-Message-State: AO0yUKXaqWn3w+mDI981iP8AENOZAeel3gbHvIG/HwbmvgHFOFqqwsem p0aBCk3ZD0UymMiFFM+EpOl0vmFMbZWX+b8zaug= X-Google-Smtp-Source: AK7set/zaOdeDV+1veyboUDW+rU/G9F7W2HSrcB9dD46e6NttghzsH6r07UgLUXfK/oluu2fn4xh1A== X-Received: by 2002:a17:906:eea:b0:8da:69ae:6ff0 with SMTP id x10-20020a1709060eea00b008da69ae6ff0mr9971709eji.22.1678952430184; Thu, 16 Mar 2023 00:40:30 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9827:5f65:8269:a95f? ([2a02:810d:15c0:828:9827:5f65:8269:a95f]) by smtp.gmail.com with ESMTPSA id m18-20020a17090679d200b008e204a57e70sm3450710ejo.214.2023.03.16.00.40.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 00:40:29 -0700 (PDT) Message-ID: Date: Thu, 16 Mar 2023 08:40:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 10/15] dt-bindings: serial: Document ma35d1 uart controller bindings Content-Language: en-US To: Jacky Huang , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, schung@nuvoton.com, Jacky Huang References: <20230315072902.9298-1-ychuang570808@gmail.com> <20230315072902.9298-11-ychuang570808@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230315072902.9298-11-ychuang570808@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 15/03/2023 08:28, Jacky Huang wrote: > From: Jacky Huang > > Add documentation to describe nuvoton ma35d1 uart driver bindings. Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Jacky Huang > --- > .../serial/nuvoton,ma35d1-serial.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml > > diff --git a/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml b/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml > new file mode 100644 > index 000000000000..9daa2efd4734 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/serial/nuvoton,ma35d1-serial.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 Universal Asynchronous Receiver/Transmitter (UART) > + > +maintainers: > + - Min-Jen Chen > + - Jacky Huang > + > +allOf: > + - $ref: "serial.yaml" Drop quotes. Use some recent bindings as your starting point, so we do not have to give comments for things which were already fixed. > + > +properties: > + compatible: > + const: nuvoton,ma35d1-uart > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + aliases { > + serial0 = &uart0; > + }; Drop aliases. > + > + uart0:serial@40700000 { Drop label Best regards, Krzysztof